Attention is currently required from: Tony Huang, Tim Wawrzynczak, Zhuohao Lee.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67214 )
Change subject: mb/google/dedede/var/shotzo: Update DPTF parameters
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8415e0d25a79764f0c1d11688728b7caa3b3d6a4
Gerrit-Change-Number: 67214
Gerrit-PatchSet: 3
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 18:00:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Tarun Tuli, Subrata Banik, Tim Wawrzynczak, Wisley Chen.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65611 )
Change subject: drivers/intel/dptf: Add multiple fan support under dptf
......................................................................
Patch Set 7:
(1 comment)
File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/65611/comment/ed44511c_132f9900
PS6, Line 367: dptf_write_scope(participant);
:
: /* _FPS - Fan Performance States */
: acpigen_write_name("_FPS");
> I think this is a bit much; the function name says "verify", but this writes out some AML, I think i […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/65611
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96ead90e3b805bd20de03e4bef4fa4b9fbaaaedd
Gerrit-Change-Number: 65611
Gerrit-PatchSet: 7
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 17:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67278 )
Change subject: mb/google/brya/acpi: Move dGPU power checks earlier
......................................................................
mb/google/brya/acpi: Move dGPU power checks earlier
Linux always "turns on" a PowerResource when it boots, regardless of
_STA, so the _ON routine should be idempotent. In this case, it all is,
except for the LTR restore, which would restore a value of 0 when _ON is
run the first time, which means that LTR is disabled on the root port
from then on, as the save/restore routines will keep saving/restoring
that 0. THis patch fixes the problem by moving the power checks from
PGON/PGOF to GCOO/GCOI.
BUG=b:244409563
TEST=boot agah and verify that LTR is still enabled on the root port
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Change-Id: I4ed78323608eede5b8310598f1f1115497ab2b5b
---
M src/mainboard/google/brya/acpi/power.asl
1 file changed, 33 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/67278/1
diff --git a/src/mainboard/google/brya/acpi/power.asl b/src/mainboard/google/brya/acpi/power.asl
index 8940e60..f79a44a 100644
--- a/src/mainboard/google/brya/acpi/power.asl
+++ b/src/mainboard/google/brya/acpi/power.asl
@@ -182,12 +182,6 @@
/* GCOFF exit sequence */
Method (PGON, 0, Serialized)
{
- If (GPPS == GPU_POWER_STATE_ON)
- {
- Printf ("PGON: GPU already on")
- Return
- }
-
Local0 = Timer - GCOT
If (Local0 < MIN_OFF_TIME_TIMERS)
{
@@ -234,12 +228,6 @@
/* GCOFF entry sequence */
Method (PGOF, 0, Serialized)
{
- If (GPPS == GPU_POWER_STATE_OFF)
- {
- Printf ("GPU already off")
- Return
- }
-
/* Assert PERST# */
CTXS (GPIO_GPU_PERST_L)
@@ -278,6 +266,12 @@
/* GCOFF Out, i.e. full power-on sequence */
Method (GCOO, 0, Serialized)
{
+ If (GPPS == GPU_POWER_STATE_ON)
+ {
+ Printf ("PGON: GPU already on")
+ Return
+ }
+
SRCC (SRCCLK_ENABLE)
PGON ()
\_SB.PCI0.PEG0.LD23 ()
@@ -310,9 +304,14 @@
/* GCOFF In, i.e. full power-off sequence */
Method (GCOI, 0, Serialized)
{
+ If (GPPS == GPU_POWER_STATE_OFF)
+ {
+ Printf ("GPU already off")
+ Return
+ }
+
/* Save the PEG port's LTR setting */
SLTR = LREN
-
\_SB.PCI0.PEG0.DL23 ()
PGOF ()
SRCC (SRCCLK_DISABLE)
--
To view, visit https://review.coreboot.org/c/coreboot/+/67278
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ed78323608eede5b8310598f1f1115497ab2b5b
Gerrit-Change-Number: 67278
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newchange
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66605 )
Change subject: mb/google/skyrim: Add missing USB ports to device tree
......................................................................
mb/google/skyrim: Add missing USB ports to device tree
As part of investigating b/240690391 I noticed that we were missing
the daughter board ports. Not all SKUs have these ports connected,
but it doesn't hurt to have the extra ACPI nodes.
BUG=none
TEST=build
Signed-off-by: Raul E Rangel <rrangel(a)chromium.org>
Change-Id: Id6fc34acbfa30bc15e697043bf93bcf584256128
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66605
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Jon Murphy <jpmurphy(a)google.com>
---
M src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
1 file changed, 36 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Jon Murphy: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
index 80bc8ac..945ea19 100644
--- a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
+++ b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
@@ -40,7 +40,7 @@
register "port_count" = "4"
device usb 0.0 on # VL822 USB3 hub
chip drivers/usb/acpi
- register "desc" = ""USB3 Type-A Port A0 (DB)""
+ register "desc" = ""USB3 Type-A Port A0 (MLB)""
register "type" = "UPC_TYPE_USB3_A"
register "use_custom_pld" = "true"
register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(2, 2))"
@@ -57,6 +57,13 @@
register "enable_delay_ms" = "20"
device usb 3.1 on end
end
+ chip drivers/usb/acpi
+ register "desc" = ""USB3 Type-A Port A1 (DB)""
+ register "type" = "UPC_TYPE_USB3_A"
+ register "use_custom_pld" = "true"
+ register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, CENTER, ACPI_PLD_GROUP(3, 1))"
+ device usb 3.2 on end
+ end
end # VL822 USB3 hub
end
end # USB 3.1 port3
@@ -69,7 +76,7 @@
register "port_count" = "4"
device usb 0.0 on # VL822 USB2 hub
chip drivers/usb/acpi
- register "desc" = ""USB2 Type-A Port A0 (DB)""
+ register "desc" = ""USB2 Type-A Port A0 (MLB)""
register "type" = "UPC_TYPE_USB3_A"
register "use_custom_pld" = "true"
register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(2, 2))"
@@ -81,6 +88,13 @@
register "group" = "ACPI_PLD_GROUP(2, 2)"
device usb 2.1 on end
end
+ chip drivers/usb/acpi
+ register "desc" = ""USB2 Type-A Port A1 (DB)""
+ register "type" = "UPC_TYPE_USB3_A"
+ register "use_custom_pld" = "true"
+ register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, CENTER, ACPI_PLD_GROUP(3, 1))"
+ device usb 2.2 on end
+ end
end # VL822 USB2 hub
end
end # USB 2 port3
--
To view, visit https://review.coreboot.org/c/coreboot/+/66605
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6fc34acbfa30bc15e697043bf93bcf584256128
Gerrit-Change-Number: 66605
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged