Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66924 )
Change subject: util/docker/coreboot-sdk: Install GNAT 12
......................................................................
Patch Set 2:
(1 comment)
File util/docker/coreboot-sdk/Dockerfile:
https://review.coreboot.org/c/coreboot/+/66924/comment/d0441277_96e3fd06
PS2, Line 38: gnat-12
> shouldn't we use same version as gcc in util/crossgcc/buildgcc ? […]
Why? This is just the host toolchain..
--
To view, visit https://review.coreboot.org/c/coreboot/+/66924
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If00a05a0c8564e624809268a12fae28261e380a2
Gerrit-Change-Number: 66924
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 07 Sep 2022 05:46:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Ricky Chang.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67307 )
Change subject: mb/google/brya/var/kinox: Modify fan speed/duty table
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS3:
> Could we please separate this into 2 commits? One that update the acpigen_dptf. […]
CB:67390
--
To view, visit https://review.coreboot.org/c/coreboot/+/67307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458
Gerrit-Change-Number: 67307
Gerrit-PatchSet: 6
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 03:22:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Ricky Chang.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67307 )
Change subject: mb/google/brya/var/kinox: Modify fan speed/duty table
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Hi Sumeet and Tim,
Would you help to review again? Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5e885b96624d5fc31f1d42e3582c3ab01e08458
Gerrit-Change-Number: 67307
Gerrit-PatchSet: 6
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 03:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Sumeet R Pawnikar, Ricky Chang.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67390 )
Change subject: acpi/acpigen_dptf: Modify DPTF_MAX_FAN_PERF_STATES to 20
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Hi Sumeet and Tim,
Would you help to review? Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67390
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacd3ef0da926df5d174b215ab8ea4adc1a8b672e
Gerrit-Change-Number: 67390
Gerrit-PatchSet: 4
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 03:19:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tony Huang, Wisley Chen.
Hello build bot (Jenkins), Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67373
to look at the new patch set (#9).
Change subject: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix
......................................................................
mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix
Turn off the LAN power which is controlled by GPP_A10 in S0ix states.
For an USB device, the S0ix hook is needed for the on/off operationas
to take place.
BUG=b:245426120
BRANCH=firmware-dedede-13606.B
TEST=emerge-shotzo coreboot
check LAN LED off in S0ix states
check SSDT table has MS0X entry
Scope (\_SB)
{
Method (MS0X, 1, Serialized)
{
If ((Arg0 == One))
{
\_SB.PCI0.CTXS (0x41)
}
Else
{
\_SB.PCI0.STXS (0x41)
}
}
}
Change-Id: Id01089531503e62231c5ab19e4cd8056198b9acb
Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/mainboard.c
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/dedede/variants/shotzo/Makefile.inc
A src/mainboard/google/dedede/variants/shotzo/variant.c
4 files changed, 92 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/67373/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/67373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id01089531503e62231c5ab19e4cd8056198b9acb
Gerrit-Change-Number: 67373
Gerrit-PatchSet: 9
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tony Huang, Wisley Chen.
Hello build bot (Jenkins), Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67373
to look at the new patch set (#8).
Change subject: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix
......................................................................
mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix
Turn off the LAN power which is controlled by GPP_A10 in S0ix states.
For an USB device, the S0ix hook is needed for the on/off operationas
to take place.
BUG=b:245426120
BRANCH=firmware-dedede-13606.B
TEST=emerge-shotzo coreboot
check LAN LED off in S0ix states
check SSDT table has MS0X entry
Scope (\_SB)
{
Method (MS0X, 1, Serialized)
{
If ((Arg0 == One))
{
\_SB.PCI0.CTXS (0x41)
}
Else
{
\_SB.PCI0.STXS (0x41)
}
}
}
Change-Id: Id01089531503e62231c5ab19e4cd8056198b9acb
Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/mainboard.c
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/dedede/variants/shotzo/Makefile.inc
A src/mainboard/google/dedede/variants/shotzo/variant.c
4 files changed, 93 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/67373/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/67373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id01089531503e62231c5ab19e4cd8056198b9acb
Gerrit-Change-Number: 67373
Gerrit-PatchSet: 8
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Wisley Chen.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67373 )
Change subject: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix
......................................................................
Patch Set 7:
(5 comments)
File src/mainboard/google/dedede/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198):
https://review.coreboot.org/c/coreboot/+/67373/comment/96ae0734_3240de66
PS7, Line 98: */
code indent should use tabs where possible
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198):
https://review.coreboot.org/c/coreboot/+/67373/comment/d0c62b93_d805d38a
PS7, Line 19: S0IX_EXIT,
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198):
https://review.coreboot.org/c/coreboot/+/67373/comment/ec5912e3_b30900d0
PS7, Line 19: S0IX_EXIT,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198):
https://review.coreboot.org/c/coreboot/+/67373/comment/9ae3f353_f39c9724
PS7, Line 20: S0IX_ENTRY,
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158198):
https://review.coreboot.org/c/coreboot/+/67373/comment/94f19072_07f69428
PS7, Line 20: S0IX_ENTRY,
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/67373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id01089531503e62231c5ab19e4cd8056198b9acb
Gerrit-Change-Number: 67373
Gerrit-PatchSet: 7
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 03:04:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tony Huang.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67373 )
Change subject: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix
......................................................................
Patch Set 6:
(5 comments)
File src/mainboard/google/dedede/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197):
https://review.coreboot.org/c/coreboot/+/67373/comment/1f75dfaa_5697159b
PS6, Line 98: */
code indent should use tabs where possible
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197):
https://review.coreboot.org/c/coreboot/+/67373/comment/3c987db2_8df056e2
PS6, Line 19: S0IX_EXIT,
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197):
https://review.coreboot.org/c/coreboot/+/67373/comment/c0198bcf_3c07fd99
PS6, Line 19: S0IX_EXIT,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197):
https://review.coreboot.org/c/coreboot/+/67373/comment/6468336e_a755ece6
PS6, Line 20: S0IX_ENTRY,
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158197):
https://review.coreboot.org/c/coreboot/+/67373/comment/67221fa4_a575d213
PS6, Line 20: S0IX_ENTRY,
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/67373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id01089531503e62231c5ab19e4cd8056198b9acb
Gerrit-Change-Number: 67373
Gerrit-PatchSet: 6
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 03:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment