Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67332 )
Change subject: mb/google/rex: Add WWAN poweron sequencing
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/67332/comment/53858b88_24da643f
PS1, Line 373: /* GPP_B17 : [] ==> EN_WWAN_PWR */
> Here is the measured result of moving EN_WWAN_PWR to romstage. […]
`enable power in bootblock` meet start-up Timing Sequence (Tpr) but in romstage.
--
To view, visit https://review.coreboot.org/c/coreboot/+/67332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cda9348ef7f54efe5ba2358040596a1c2da1b13
Gerrit-Change-Number: 67332
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 09:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com>
Comment-In-Reply-To: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Mike Shih.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67397
to look at the new patch set (#5).
Change subject: [TEST ONLY] coreboot function test
......................................................................
[TEST ONLY] coreboot function test
gaelin test
BUG=None
TEST=None
BRANCH=firmware-brya-14505.B
Signed-off-by: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Change-Id: Iad93f2a8838ad9a3567374a8b05fa9e89363814c
---
A src/mainboard/google/brya/variants/gaelin/Makefile.inc
A src/mainboard/google/brya/variants/gaelin/gpio.c
M src/mainboard/google/brya/variants/gaelin/overridetree.cb
A src/mainboard/google/brya/variants/gaelin/test.txt
4 files changed, 476 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/67397/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/67397
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad93f2a8838ad9a3567374a8b05fa9e89363814c
Gerrit-Change-Number: 67397
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Mike Shih.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67397
to look at the new patch set (#4).
Change subject: [TEST ONLY] coreboot function test
......................................................................
[TEST ONLY] coreboot function test
gaelin test
BUG=None
TEST=None
BRANCH=firmware-brya-14505.B
Signed-off-by: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Change-Id: Iad93f2a8838ad9a3567374a8b05fa9e89363814c
---
A src/mainboard/google/brya/variants/gaelin/Makefile.inc
A src/mainboard/google/brya/variants/gaelin/gpio.c
M src/mainboard/google/brya/variants/gaelin/overridetree.cb
A src/mainboard/google/brya/variants/gaelin/test.txt
4 files changed, 477 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/67397/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/67397
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad93f2a8838ad9a3567374a8b05fa9e89363814c
Gerrit-Change-Number: 67397
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: V Sowmya, Tim Wawrzynczak.
Hello build bot (Jenkins), Kangheui Won, Reka Norman, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66929
to look at the new patch set (#3).
Change subject: mb/google/nissa: Disable the stylus GPIO pins based on fw_config
......................................................................
mb/google/nissa: Disable the stylus GPIO pins based on fw_config
TEST=Boot to OS on nivviks/nirwen and check that stylus GPIOs are
configured based on fw_config.
Signed-off-by: V Sowmya <v.sowmya(a)intel.com>
Change-Id: Ibbe9f379abe10a741642e11d4833d3a53489693a
---
M src/mainboard/google/brya/variants/nivviks/fw_config.c
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/66929/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/66929
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbe9f379abe10a741642e11d4833d3a53489693a
Gerrit-Change-Number: 66929
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Vidya Gopalakrishnan, Paul Fagerburg, Simon Yang.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67374 )
Change subject: soc/intel/alderlake: add power limits for Alder Lake-N 7W soc
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iefe17f5b574cc319fe9aad3850401a8aa8e31270
Gerrit-Change-Number: 67374
Gerrit-PatchSet: 3
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-CC: Kane Chen <kane.chen(a)intel.com>
Gerrit-CC: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 07:41:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Mike Shih.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67397
to look at the new patch set (#3).
Change subject: [TEST ONLY] coreboot function test
......................................................................
[TEST ONLY] coreboot function test
gaelin test
BUG=None
TEST=None
BRANCH=firmware-brya-14505.B
Signed-off-by: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Change-Id: Iad93f2a8838ad9a3567374a8b05fa9e89363814c
---
A src/mainboard/google/brya/variants/gaelin/Makefile.inc
A src/mainboard/google/brya/variants/gaelin/gpio.c
M src/mainboard/google/brya/variants/gaelin/overridetree.cb
A src/mainboard/google/brya/variants/gaelin/test.txt
4 files changed, 476 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/67397/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/67397
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad93f2a8838ad9a3567374a8b05fa9e89363814c
Gerrit-Change-Number: 67397
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Mike Shih <mikeshih(a)msi.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Nien, Himanshu Sahdev, Martin Roth.
Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67376 )
Change subject: guybrush: remove RO_GSCVD area from FMAP
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/67376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896b871bf2ac64e334514b979add9b8ac2c43945
Gerrit-Change-Number: 67376
Gerrit-PatchSet: 2
Gerrit-Owner: Himanshu Sahdev <himanshu.sahdev(a)intel.com>
Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 07:32:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment