coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4674 discussions

[S] Change in coreboot[master]: [RFC] mb/prodrive/hermes: Make board settings less error-prone
by Angel Pons (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Patrick Rudolph, Christian Walter. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67381 ) Change subject: [RFC] mb/prodrive/hermes: Make board settings less error-prone ...................................................................... [RFC] mb/prodrive/hermes: Make board settings less error-prone If the board settings definition differs between coreboot and the BMC, the CRC will not match. Allow coreboot to use the BMC settings provided by older BMC firmware revisions which have less settings, if the CRC of the first N bytes matches the expected CRC. TEST=Boot coreboot master with BMC FW 4.05, observe board settings being honored even though coreboot's definition has an extra option. Change-Id: I0f009b21ef0850a2af6edef1818c770171358314 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/prodrive/hermes/eeprom.c 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/67381/1 diff --git a/src/mainboard/prodrive/hermes/eeprom.c b/src/mainboard/prodrive/hermes/eeprom.c index 7a92fe3..8ce671b 100644 --- a/src/mainboard/prodrive/hermes/eeprom.c +++ b/src/mainboard/prodrive/hermes/eeprom.c @@ -51,6 +51,20 @@ if (crc != board_cfg->signature) { printk(BIOS_ERR, "CFG EEPROM: Board settings have invalid checksum\n"); + + /* + * coreboot's board settings definition may be newer than the BMC's, + * try to see if the CRC of the first i bytes matches the expected CRC. + */ + for (size_t i = 1; i < sizeof(board_cfg->raw_settings); i++) { + const uint32_t crc_part = CRC(&board_cfg->raw_settings, i, crc32_byte); + if (crc_part == board_cfg->signature) { + for (; i < sizeof(board_cfg->raw_settings); i++) + board_cfg->raw_settings[i] = 0; + printk(BIOS_ERR, "CFG EEPROM: Checksum OK for %zu bytes\n", i); + return true; + } + } return false; } return true; -- To view, visit https://review.coreboot.org/c/coreboot/+/67381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f009b21ef0850a2af6edef1818c770171358314 Gerrit-Change-Number: 67381 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/prodrive/hermes: Allow using the Intel iGPU as primary
by Angel Pons (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter. Angel Pons has uploaded a new patch set (#7) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/62649 ) Change subject: mb/prodrive/hermes: Allow using the Intel iGPU as primary ...................................................................... mb/prodrive/hermes: Allow using the Intel iGPU as primary Configure the Intel iGPU as primary video adapter if enabled according to EEPROM settings. The default is to use the ASPEED BMC as primary video adapter, which only has a VGA output and the remote KVM output. TODO: Figure out why iGPU video stops working after booting Linux and doing a warm (no power cycle) reboot. TEST=Test that DP and HDMI outputs work in pre-OS and on Linux using the Poseidon piggy-back board, which has two DisplayPort outputs and one HDMI output from a LSPCON. Change-Id: I24d9ebc2055dc246e7f257aa2f3853b22c8af370 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/prodrive/hermes/eeprom.h M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/prodrive/hermes/romstage.c 3 files changed, 56 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/62649/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/62649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24d9ebc2055dc246e7f257aa2f3853b22c8af370 Gerrit-Change-Number: 62649 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/amd/common/block/apob: Add hashed APOB support
by Fred Reitberger (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 ) Change subject: soc/amd/common/block/apob: Add hashed APOB support ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67301/comment/5fcf02b8_cde8215e PS4, Line 15: chausie > Can you try it on a guybrush device? I don't have a guybrush to test with. I did test this on chausie with the option both enabled and disabled, and it behaved as expected. I think it should work on guybrush, but have no way to verify. File src/soc/amd/common/block/apob/apob_cache.c: https://review.coreboot.org/c/coreboot/+/67301/comment/de952afd_1c15f4c3 PS4, Line 57: apob_header_ptr->size + MRC_HASH_SIZE > You could probably do this as a `_Static_assert` above If this check fails, the device can still boot. The actual size is not known at compile time. Added a temp variable to make this more readable. https://review.coreboot.org/c/coreboot/+/67301/comment/df2ebfc3_b0987a00 PS4, Line 195: xxh64 > I wonder if coreboot has an existing has function. […] I looked into vboot sha256, but it took ~800 microseconds compared to ~60 for xxhash. https://review.coreboot.org/c/coreboot/+/67301/comment/7126332c_90161071 PS4, Line 214: !update_needed && > You can probably skip this part since `apob_rom` will be `NULL` if `update_needed == true` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I241968b115aaf41af63445410660bdd5199ceaba Gerrit-Change-Number: 67301 Gerrit-PatchSet: 4 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Sep 2022 18:20:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/block/apob: Add hashed APOB support
by Fred Reitberger (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67301 to look at the new patch set (#5). Change subject: soc/amd/common/block/apob: Add hashed APOB support ...................................................................... soc/amd/common/block/apob: Add hashed APOB support Comparing the APOB in RAM to flash takes a significant amount of time (~11ms). Instead of comparing the entire APOB, use a fast hash function and compare just that. Reading, hashing, and comparing the hash take ~70 microseconds. BUG=b:193557430 TEST=compile and boot to OS in chausie with and without this option set Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I241968b115aaf41af63445410660bdd5199ceaba --- M src/soc/amd/common/block/apob/Kconfig M src/soc/amd/common/block/apob/apob_cache.c 2 files changed, 78 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/67301/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/67301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I241968b115aaf41af63445410660bdd5199ceaba Gerrit-Change-Number: 67301 Gerrit-PatchSet: 5 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: libpayload/Makefile.inc: Initialize vboot depending on UPDATED_SUBMOD...
by Nico Huber (Code Review) 06 Sep '22

06 Sep '22

Attention is currently required from: Bora Guvendik, Wonkyu Kim, Selma Bensaid, Jérémy Compostella, Nicholas Chin. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67118 ) Change subject: libpayload/Makefile.inc: Initialize vboot depending on UPDATED_SUBMODULES ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > I think providing the user the possibility to build with or without submodules is a nice feature. In such a case, it's user responsibility to ensure that all repos needed are installed properly. Absolutely. Hence I want us to look for a solution that works by definition and not by coincidence. It is coincidence that the depthcharge Makefile doesn't unexport COREBOOT_EXPORTS. For other payloads that do it, your solution won't work. And it might break if somebody updates the depthcharge Makefile. I can think some possible solutions: * add another variable that is meant to be set by the user and not unexported * never unexport UPDATED_SUBMODULES. but then we should rename it, e.g. put COREBOOT in the name so we don't leave a variable with generic name in the environment. You didn't anwser my question btw. maybe there is nothing to do here: To avoid a checkout of the wrong commit in a submodule, you can always add the change to the index. Would that solve your problem? File payloads/libpayload/Makefile.inc: https://review.coreboot.org/c/coreboot/+/67118/comment/b65e2598_0df89044 PS2, Line 91: ifneq ($(UPDATED_SUBMODULES),1) > Hi Nico, are you building manually libpayload? […] I meant Nicholas' case when running `make` in `payloads/coreinfo/`. I think it just calls `make` multiple times for libpayload. Once for the configuration and another time to actually build it. It's quite complicated. But in the end the result is the same as you'd type `make` twice, and the second invocation won't know what the first did. -- To view, visit https://review.coreboot.org/c/coreboot/+/67118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d58b863cf709930900c7e691e52cac71f88a349 Gerrit-Change-Number: 67118 Gerrit-PatchSet: 3 Gerrit-Owner: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 18:14:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Selma Bensaid <selma.bensaid(a)intel.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: lint/checkpatch: Fix incorrect camelcase detection on numeric constant
by Felix Held (Code Review) 06 Sep '22

06 Sep '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67337 ) Change subject: lint/checkpatch: Fix incorrect camelcase detection on numeric constant ...................................................................... lint/checkpatch: Fix incorrect camelcase detection on numeric constant This reduce the difference with linux v6.0-rc3. Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I15e1a935665c38b8a2109d412b1d16f935cbb402 Reviewed-on: https://review.coreboot.org/c/coreboot/+/67337 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M util/lint/checkpatch.pl 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 650ddff..ef2faee 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -5326,7 +5326,7 @@ $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ && #Ignore some three character SI units explicitly, like MiB and KHz $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) { - while ($var =~ m{($Ident)}g) { + while ($var =~ m{\b($Ident)}g) { my $word = $1; next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/); if ($check) { -- To view, visit https://review.coreboot.org/c/coreboot/+/67337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15e1a935665c38b8a2109d412b1d16f935cbb402 Gerrit-Change-Number: 67337 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Configure Acoustic noise mitigation
by Lean Sheng Tan (Code Review) 06 Sep '22

06 Sep '22

Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67380 ) Change subject: mb/prodrive/atlas: Configure Acoustic noise mitigation ...................................................................... mb/prodrive/atlas: Configure Acoustic noise mitigation - Enable Acoustic noise mitigation - Set slow slew rate VCCIA and VCCGT to 4 - Set FastPkgCRampDisable VCCIA and VCCGT to 1 Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: Ia344d9d939c3323bac82afdf25d5fff81081f9c8 --- M src/mainboard/prodrive/atlas/devicetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/67380/1 diff --git a/src/mainboard/prodrive/atlas/devicetree.cb b/src/mainboard/prodrive/atlas/devicetree.cb index 0a85541..d458dfa 100644 --- a/src/mainboard/prodrive/atlas/devicetree.cb +++ b/src/mainboard/prodrive/atlas/devicetree.cb @@ -22,6 +22,13 @@ [DDI_PORT_2] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, }" + # Acoustic settings + register "acoustic_noise_mitigation" = "1" + register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" + register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" + register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" + register "fast_pkg_c_ramp_disable[VR_DOMAIN_GT]" = "1" + # USB configuration register "usb2_ports[0]" = "USB2_PORT_MID(OC0)" register "usb2_ports[1]" = "USB2_PORT_MID(OC0)" -- To view, visit https://review.coreboot.org/c/coreboot/+/67380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia344d9d939c3323bac82afdf25d5fff81081f9c8 Gerrit-Change-Number: 67380 Gerrit-PatchSet: 1 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/lint/lint-stable-019-header-files: add test
by Felix Held (Code Review) 06 Sep '22

06 Sep '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67351 ) Change subject: util/lint/lint-stable-019-header-files: add test ...................................................................... util/lint/lint-stable-019-header-files: add test Add a test to make sure that the linter fails correctly. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I971951d4248dd10abe4c622025fdaf86e014c6cc Reviewed-on: https://review.coreboot.org/c/coreboot/+/67351 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/lint-stable-019-header-files 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/lint/lint-stable-019-header-files b/util/lint/lint-stable-019-header-files index 6495d15..f73e0e7 100755 --- a/util/lint/lint-stable-019-header-files +++ b/util/lint/lint-stable-019-header-files @@ -11,6 +11,28 @@ HEADER_FILES="k\?config rules compiler" +TESTFILE1="src/lib/version.c" +TESTFILE2="src/lib/string.c" +TESTFILE3="src/lib/malloc.c" +TESTFILE4="src/lib/hardwaremain.c" +EXPECTED_FAILURES=4 + +# Configure to make sure tests fail +if [ "$1" = "--test" ]; then + sed -i.bak "s|^.*SPDX-License-Identifier.*|&\n\n#include <config.h>\n|" "${TESTFILE1}" + sed -i.bak "s|^.*SPDX-License-Identifier.*|&\n\n#include \"kconfig.h\"\n|" "${TESTFILE2}" + sed -i.bak "s|^.*SPDX-License-Identifier.*|&\n\n#include \"compiler.h\"\n|" "${TESTFILE3}" + sed -i.bak "s|^.*SPDX-License-Identifier.*|&\n\n#include <rules.h>\n|" "${TESTFILE4}" + echo "Expect ${EXPECTED_FAILURES} failures." + exit 0 +elif [ "$1" = "--reset" ]; then + mv "${TESTFILE1}.bak" "${TESTFILE1}" + mv "${TESTFILE2}.bak" "${TESTFILE2}" + mv "${TESTFILE3}.bak" "${TESTFILE3}" + mv "${TESTFILE4}.bak" "${TESTFILE4}" + exit 0 +fi + # Use git grep if the code is in a git repo, otherwise use grep. if [ -n "$(command -v git)" ] && \ [ "$(git rev-parse --is-inside-work-tree 2>/dev/null)" = "true" ] -- To view, visit https://review.coreboot.org/c/coreboot/+/67351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I971951d4248dd10abe4c622025fdaf86e014c6cc Gerrit-Change-Number: 67351 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: util/lint: Add rules.h & compiler.h to 019-header-files linter
by Felix Held (Code Review) 06 Sep '22

06 Sep '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67350 ) Change subject: util/lint: Add rules.h & compiler.h to 019-header-files linter ...................................................................... util/lint: Add rules.h & compiler.h to 019-header-files linter The rules.h & compiler.h includes were removed in previous commits, so add the checks to keep them out to the linter. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: If4964ff26f5e83abbbdd26c2b1cd9a2eab5a0a0d Reviewed-on: https://review.coreboot.org/c/coreboot/+/67350 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/lint/lint-stable-019-header-files 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/lint/lint-stable-019-header-files b/util/lint/lint-stable-019-header-files index c839dc5..6495d15 100755 --- a/util/lint/lint-stable-019-header-files +++ b/util/lint/lint-stable-019-header-files @@ -9,8 +9,7 @@ INCLUDED_DIRS='^src/' EXCLUDED_FILES='src/include/kconfig.h' -# TODO: Add rules when those patches are complete -HEADER_FILES="k*config" +HEADER_FILES="k\?config rules compiler" # Use git grep if the code is in a git repo, otherwise use grep. if [ -n "$(command -v git)" ] && \ -- To view, visit https://review.coreboot.org/c/coreboot/+/67350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4964ff26f5e83abbbdd26c2b1cd9a2eab5a0a0d Gerrit-Change-Number: 67350 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: src/soc/intel: remove force-included header compiler.h from file
by Felix Held (Code Review) 06 Sep '22

06 Sep '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67349 ) Change subject: src/soc/intel: remove force-included header compiler.h from file ...................................................................... src/soc/intel: remove force-included header compiler.h from file The header file `compiler.h` is automatically included in the build by the top level makefile using the command: `-include $(src)/commonlib/bsd/include/commonlib/bsd/compiler.h`. Similar to `config.h`, 'kconfig.h`, and 'rules.h`, this file does not need to be included manually, so remove it. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I5d3eb3f5e5f940910b2d45e0a2ae508e5ce91609 Reviewed-on: https://review.coreboot.org/c/coreboot/+/67349 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/intel/common/block/scs/early_mmc.c 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/src/soc/intel/common/block/scs/early_mmc.c b/src/soc/intel/common/block/scs/early_mmc.c index caee7d9..4e76533 100644 --- a/src/soc/intel/common/block/scs/early_mmc.c +++ b/src/soc/intel/common/block/scs/early_mmc.c @@ -5,7 +5,6 @@ #include <commonlib/storage/sd_mmc.h> #include <commonlib/sd_mmc_ctrlr.h> #include <commonlib/sdhci.h> -#include <compiler.h> #include <console/console.h> #include <device/pci.h> #include <intelblocks/mmc.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/67349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d3eb3f5e5f940910b2d45e0a2ae508e5ce91609 Gerrit-Change-Number: 67349 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022