Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 )
Change subject: soc/amd/common/block/apob: Add hashed APOB support ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67301/comment/5fcf02b8_cde8215e PS4, Line 15: chausie
Can you try it on a guybrush device?
I don't have a guybrush to test with. I did test this on chausie with the option both enabled and disabled, and it behaved as expected. I think it should work on guybrush, but have no way to verify.
File src/soc/amd/common/block/apob/apob_cache.c:
https://review.coreboot.org/c/coreboot/+/67301/comment/de952afd_1c15f4c3 PS4, Line 57: apob_header_ptr->size + MRC_HASH_SIZE
You could probably do this as a `_Static_assert` above
If this check fails, the device can still boot. The actual size is not known at compile time. Added a temp variable to make this more readable.
https://review.coreboot.org/c/coreboot/+/67301/comment/df2ebfc3_b0987a00 PS4, Line 195: xxh64
I wonder if coreboot has an existing has function. […]
I looked into vboot sha256, but it took ~800 microseconds compared to ~60 for xxhash.
https://review.coreboot.org/c/coreboot/+/67301/comment/7126332c_90161071 PS4, Line 214: !update_needed &&
You can probably skip this part since `apob_rom` will be `NULL` if `update_needed == true`
Done