Attention is currently required from: Felix Singer, Ahamed Husni.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67341 )
Change subject: src/console: attach smbus console driver
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/smbus/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/67341/comment/5d4c0576_ebdf5b39
PS4, Line 2: bootblock-y += i2c_smbus_console.c
: romstage-y += i2c_smbus_console.c
: ramstage-y += i2c_smbus_console.c
why not `all-y += ... `
is there some reason not to use this in other stages?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a9bf64e59d529253bfdcdfa565bb2bb92975728
Gerrit-Change-Number: 67341
Gerrit-PatchSet: 4
Gerrit-Owner: Ahamed Husni
ahamedhusni73@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Ahamed Husni
ahamedhusni73@gmail.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 21:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment