Attention is currently required from: Felix Singer, Ahamed Husni.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 )
Change subject: drivers/smbus: SC16IS750 I2C to UART converter chip initialization
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/smbus/i2c_smbus_console.c:
https://review.coreboot.org/c/coreboot/+/67342/comment/3e4caa35_3f87d0bd
PS6, Line 10: #if (CONFIG(CONSOLE_I2C_SMBUS) && (ENV_ROMSTAGE || ENV_BOOTBLOCK))
: early_pch_init();
: #endif
: #if (CONFIG(SC16IS750_INIT) && (ENV_ROMSTAGE || ENV_BOOTBLOCK))
: sc16is750_init();
: #endif
I think you could refactor this like
```
if (ENV_ROMSTAGE || ENV_BOOTBLOCK) {
if (CONFIG(CONSOLE_I2C_SMBUS))
early_pch_init();
if (CONFIG(SC16IS750_INIT))
sc16is750_init();
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib31188b8c0f9b0ce9454da984e630eca9101d145
Gerrit-Change-Number: 67342
Gerrit-PatchSet: 6
Gerrit-Owner: Ahamed Husni
ahamedhusni73@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Ahamed Husni
ahamedhusni73@gmail.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 21:32:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment