Attention is currently required from: Raul Rangel, Tim Wawrzynczak.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67385 )
Change subject: Documentation: Add wake source info to device tree documentation ......................................................................
Patch Set 2:
(2 comments)
File Documentation/getting_started/devicetree.md:
https://review.coreboot.org/c/coreboot/+/67385/comment/904cf581_9eeeba2b PS2, Line 96: When this entry is processed during ramstage, it will create a device in the : ACPI SSDT table (all devices in devicetrees end up in the SSDT table). Can ramstage be updated to detect when multiple wake sources are registered and generate an error/warning message? Or should (can?) `ACPI_IRQ_WAKE_LEVEL_LOW()` be removed?
https://review.coreboot.org/c/coreboot/+/67385/comment/61d5509a_1fe6bbf0 PS2, Line 263: The linux kernel has great support for this method. Isn't the issue that the kernel doesn't warn the user/developer that they have both wake sources enabled? Windows may be going overboard by BSODing with that configuration, but silently allowing a config that is not advised and leads to subtle bugs isn't great either.
In a perfect world, a warning message is output indicating that the same device is registering multiple wake sources, which may lead to undefined behavior.