Attention is currently required from: Raul Rangel, Tim Wawrzynczak, Tim Van Patten.
Dmitry Torokhov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67385 )
Change subject: Documentation: Add wake source info to device tree documentation
......................................................................
Patch Set 2:
(1 comment)
File Documentation/getting_started/devicetree.md:
https://review.coreboot.org/c/coreboot/+/67385/comment/a6fe5a77_834eac21
PS2, Line 263: The linux kernel has great support for this method.
Isn't the issue that the kernel doesn't warn the user/developer that they have both wake sources ena […]
I'd argue warning users about messed up firmware is not Linux kernel's task. Quite often users of the message can't do anything about it, and the device might not be running Linux at all...
Can this be added to pre-upload/pre-commit checks?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdbd5371408784bf9b81c1ade90263de8c60e0f
Gerrit-Change-Number: 67385
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Dmitry Torokhov
dtor@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jon Murphy
jpmurphy@google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Mark Hasemeyer
markhas@google.com
Gerrit-CC: Robert Zieba
robertzieba@google.com
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 22:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment