Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38197 )
Change subject: [WIP] drivers/pc80/rtc: Drop ARCH_X86 guard in header
......................................................................
[WIP] drivers/pc80/rtc: Drop ARCH_X86 guard in header
Change-Id: I03c25ad5d9864406e1a021e39a5736ac72c8825a
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/drivers/elog/boot_count.c
M src/drivers/elog/elog.c
M src/include/pc80/mc146818rtc.h
M src/lib/bootblock.c
4 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/38197/1
diff --git a/src/drivers/elog/boot_count.c b/src/drivers/elog/boot_count.c
index a6efb01..6823a93 100644
--- a/src/drivers/elog/boot_count.c
+++ b/src/drivers/elog/boot_count.c
@@ -13,7 +13,6 @@
#include <console/console.h>
#include <ip_checksum.h>
-#include <pc80/mc146818rtc.h>
#include <stddef.h>
#include <stdint.h>
#include <elog.h>
diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c
index 11cbfba..7f6c75b 100644
--- a/src/drivers/elog/elog.c
+++ b/src/drivers/elog/elog.c
@@ -17,9 +17,6 @@
#include <bootstate.h>
#include <cbmem.h>
#include <console/console.h>
-#if CONFIG(ARCH_X86)
-#include <pc80/mc146818rtc.h>
-#endif
#include <bcd.h>
#include <boot_device.h>
#include <commonlib/region.h>
diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h
index 8cc2ed4..f6359f1 100644
--- a/src/include/pc80/mc146818rtc.h
+++ b/src/include/pc80/mc146818rtc.h
@@ -1,14 +1,23 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
#ifndef PC80_MC146818RTC_H
#define PC80_MC146818RTC_H
-#if CONFIG(ARCH_X86)
-
#include <arch/io.h>
#include <types.h>
-#ifndef RTC_BASE_PORT
#define RTC_BASE_PORT 0x70
-#endif
#define RTC_PORT(x) (RTC_BASE_PORT + (x))
@@ -181,8 +190,4 @@
int cmos_checksum_valid(int range_start, int range_end, int cks_loc);
void cmos_set_checksum(int range_start, int range_end, int cks_loc);
-#endif /* CONFIG_ARCH_X86 */
-
-void cmos_post_init(void);
-
#endif /* PC80_MC146818RTC_H */
diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c
index 386f4e3..166b3fe 100644
--- a/src/lib/bootblock.c
+++ b/src/lib/bootblock.c
@@ -19,7 +19,6 @@
#include <console/console.h>
#include <delay.h>
#include <option.h>
-#include <pc80/mc146818rtc.h>
#include <program_loading.h>
#include <symbols.h>
#include <timestamp.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/38197
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03c25ad5d9864406e1a021e39a5736ac72c8825a
Gerrit-Change-Number: 38197
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newchange
Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41808 )
Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................
mb/intel/tglrvp: Add support for RT 1308
Add support for RT 1308 audio amplifier in TGLRVP.
We are using the i2c generic driver here to generate
the SSDT file. Datasheet:ALC-1308-CG-version-08.
BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. In kernel console
use the "aplay -l" command to check souncard is listed.
Change-Id: I41d205a3ab87db85baf49e9e8a582c226ba5832d
Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com>
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/41808/1
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
index 7669b18..e06032d 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
@@ -187,6 +187,12 @@
end
device pci 15.0 on # I2C0 0xA0E8
+ chip drivers/i2c/generic
+ register "hid" = ""10EC1308""
+ register "name" = ""RTAM""
+ register "desc" = ""Realtek RT1308 Codec""
+ device i2c 10 on end
+ end
chip drivers/i2c/max98373
register "vmon_slot_no" = "4"
register "imon_slot_no" = "5"
--
To view, visit https://review.coreboot.org/c/coreboot/+/41808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41d205a3ab87db85baf49e9e8a582c226ba5832d
Gerrit-Change-Number: 41808
Gerrit-PatchSet: 1
Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-MessageType: newchange
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41019 )
Change subject: mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device
......................................................................
mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device
The ASL code is copied from the Purism Librem 13v3, and is not needed,
as the standard fixed power button is used. It was removed for the
Pursim devices in commit 2d977b2dcb (mb/purism: remove duplicate ACPI
power button).
Change-Id: I18155ea672e7309b367ad4170f2f00f0b3e557db
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/41019/1
diff --git a/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl b/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl
index 1563f57..680c2e2 100644
--- a/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl
+++ b/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl
@@ -25,16 +25,4 @@
}
}
- Device (PWRB)
- {
- Name (_HID, EisaId ("PNP0C0C"))
-
- Method (_STA)
- {
- Return (0xF)
- }
-
- Name (_PRW, Package () { 27, 4 })
- }
-
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/41019
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18155ea672e7309b367ad4170f2f00f0b3e557db
Gerrit-Change-Number: 41019
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange