Change in coreboot[master]: mb/intel/tglrvp: Add support for RT 1308

[Shaunak Saha (Code Review)]

Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41808 )

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

mb/intel/tglrvp: Add support for RT 1308

Add support for RT 1308 audio amplifier in TGLRVP.
We are using the i2c generic driver here to generate
the SSDT file. Datasheet:ALC-1308-CG-version-08.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. In kernel console
use the "aplay -l" command to check souncard is listed.

Change-Id: I41d205a3ab87db85baf49e9e8a582c226ba5832d
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/41808/1

diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
index 7669b18..e06032d 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
@@ -187,6 +187,12 @@
    	end

device pci 15.0 on	# I2C0			0xA0E8
+			chip drivers/i2c/generic
+				register "hid" = ""10EC1308""
+				register "name" = ""RTAM""
+				register "desc" = ""Realtek RT1308 Codec""
+				device i2c 10 on end
+			end
    		chip drivers/i2c/max98373
    			register "vmon_slot_no" = "4"
    			register "imon_slot_no" = "5"

[Sathyanarayana Nujella (Code Review)]

Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41808 )

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

Patch Set 1:

Can you please add the same to tglrvp_up4 devicetree?

[Shaunak Saha (Code Review)]

Hello Sathyanarayana Nujella, build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Srinidhi N Kaushik, Raj Astekar,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41808

to look at the new patch set (#2).

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

mb/intel/tglrvp: Add support for RT 1308

Add support for RT 1308 audio amplifier in TGLRVP.
We are using the i2c generic driver here to generate
the SSDT file. Datasheet:ALC-1308-CG-version-08.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. In kernel console
use the "aplay -l" command to check soundcard is listed.

Change-Id: I41d205a3ab87db85baf49e9e8a582c226ba5832d
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
2 files changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/41808/2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41808 )

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

Patch Set 2: Code-Review+2

[Sathyanarayana Nujella (Code Review)]

Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41808 )

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

Patch Set 2: Code-Review+1

Thank you Shaunak, for adding both UP3 & UP4 support.

[Srinidhi N Kaushik (Code Review)]

Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41808 )

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

Patch Set 2: Code-Review+2

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41808 )

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41808 )

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

mb/intel/tglrvp: Add support for RT 1308

Add support for RT 1308 audio amplifier in TGLRVP.
We are using the i2c generic driver here to generate
the SSDT file. Datasheet:ALC-1308-CG-version-08.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. In kernel console
use the "aplay -l" command to check soundcard is listed.

Change-Id: I41d205a3ab87db85baf49e9e8a582c226ba5832d
Signed-off-by: Shaunak Saha 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41808
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Sathyanarayana Nujella 
Reviewed-by: Srinidhi N Kaushik 
Reviewed-by: Wonkyu Kim 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Sathyanarayana Nujella: Looks good to me, but someone else must approve
  Srinidhi N Kaushik: Looks good to me, approved
  Wonkyu Kim: Looks good to me, approved

diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
index 582ee12..4550815 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
@@ -188,6 +188,12 @@
    	end

device pci 15.0 on	# I2C0			0xA0E8
+			chip drivers/i2c/generic
+				register "hid" = ""10EC1308""
+				register "name" = ""RTAM""
+				register "desc" = ""Realtek RT1308 Codec""
+				device i2c 10 on end
+			end
    		chip drivers/i2c/max98373
    			register "vmon_slot_no" = "4"
    			register "imon_slot_no" = "5"
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
index d15da30..d095ff3 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
@@ -184,6 +184,12 @@
    	end

device pci 15.0 on	# I2C0			0xA0E8
+			chip drivers/i2c/generic
+				register "hid" = ""10EC1308""
+				register "name" = ""RTAM""
+				register "desc" = ""Realtek RT1308 Codec""
+				device i2c 10 on end
+			end
    		chip drivers/i2c/max98373
    			register "vmon_slot_no" = "4"
    			register "imon_slot_no" = "5"

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41808 )

Change subject: mb/intel/tglrvp: Add support for RT 1308
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5028
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5027
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5026
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5025

Please note: This test is under development and might not be accurate at all!