Change in coreboot[master]: mb/google/octopus/variants/garg: Add G2Touch touchscreen support

[Tony Huang (Code Review)]

Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42036 )

Change subject: mb/google/octopus/variants/garg: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/garg: Add G2Touch touchscreen support

BUG=b:156564296
BRANCH=octopus
TEST=emerge-octopus coreboot

Change-Id: I99b04fec88da481e21b7a05807a4f1edeb3a5bdf
Signed-off-by: Tony Huang 
---
M src/mainboard/google/octopus/variants/garg/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/42036/1

diff --git a/src/mainboard/google/octopus/variants/garg/overridetree.cb b/src/mainboard/google/octopus/variants/garg/overridetree.cb
index 0230a29..a91a730 100644
--- a/src/mainboard/google/octopus/variants/garg/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/garg/overridetree.cb
@@ -172,6 +172,20 @@
    			register "has_power_resource" = "1"
    			device i2c 39 on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""GTCH7503""
+				register "generic.desc" = ""G2TOUCH Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
+				register "generic.reset_delay_ms" = "50"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)"
+				register "generic.enable_delay_ms" = "1"
+				register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 40 on end
+			end
    	end	# - I2C 7
    end

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42036 )

Change subject: mb/google/octopus/variants/garg: Add G2Touch touchscreen support
......................................................................

Patch Set 2: Code-Review+2

[Tony Huang (Code Review)]

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42036 )

Change subject: mb/google/octopus/variants/garg: Add G2Touch touchscreen support
......................................................................

Patch Set 2:

Hi Justin and reviewers,
Could you please help cherry-pick this CL to gerrit-ToT?
Thanks

[Tony Huang (Code Review)]

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42036 )

Change subject: mb/google/octopus/variants/garg: Add G2Touch touchscreen support
......................................................................

Patch Set 2:

Hi reviewers,

Please help to submit this CL to gerrit-ToT.

Thanks

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42036 )

Change subject: mb/google/octopus/variants/garg: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/garg: Add G2Touch touchscreen support

BUG=b:156564296
BRANCH=octopus
TEST=emerge-octopus coreboot

Change-Id: I99b04fec88da481e21b7a05807a4f1edeb3a5bdf
Signed-off-by: Tony Huang 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42036
Tested-by: build bot (Jenkins) 
Reviewed-by: Justin TerAvest 
---
M src/mainboard/google/octopus/variants/garg/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Justin TerAvest: Looks good to me, approved

diff --git a/src/mainboard/google/octopus/variants/garg/overridetree.cb b/src/mainboard/google/octopus/variants/garg/overridetree.cb
index 0230a29..a91a730 100644
--- a/src/mainboard/google/octopus/variants/garg/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/garg/overridetree.cb
@@ -172,6 +172,20 @@
    			register "has_power_resource" = "1"
    			device i2c 39 on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""GTCH7503""
+				register "generic.desc" = ""G2TOUCH Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
+				register "generic.reset_delay_ms" = "50"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)"
+				register "generic.enable_delay_ms" = "1"
+				register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 40 on end
+			end
    	end	# - I2C 7
    end

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42036 )

Change subject: mb/google/octopus/variants/garg: Add G2Touch touchscreen support
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5022
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5021
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5020
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5019

Please note: This test is under development and might not be accurate at all!