Change in coreboot[master]: mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41019 )
Change subject: mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device ......................................................................
mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device
The ASL code is copied from the Purism Librem 13v3, and is not needed, as the standard fixed power button is used. It was removed for the Pursim devices in commit 2d977b2dcb (mb/purism: remove duplicate ACPI power button).
Change-Id: I18155ea672e7309b367ad4170f2f00f0b3e557db Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl 1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/41019/1
diff --git a/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl b/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl index 1563f57..680c2e2 100644 --- a/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl +++ b/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl @@ -25,16 +25,4 @@ } }
- Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - - Method (_STA) - { - Return (0xF) - } - - Name (_PRW, Package () { 27, 4 }) - } - }
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41019 )
Change subject: mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device ......................................................................
Patch Set 2:
Wanting to add Johanna as reviewer, Gerrit does not list the name.
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41019 )
Change subject: mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device ......................................................................
Patch Set 2: Code-Review+1
Boot-tested and Powerbutton is still working as ACPI event in linux. Thank you for the work!
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41019 )
Change subject: mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41019 )
Change subject: mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device ......................................................................
mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device
The ASL code is copied from the Purism Librem 13v3, and is not needed, as the standard fixed power button is used. It was removed for the Pursim devices in commit 2d977b2dcb (mb/purism: remove duplicate ACPI power button).
Change-Id: I18155ea672e7309b367ad4170f2f00f0b3e557db Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/41019 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mimoja coreboot@mimoja.de Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl 1 file changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Mimoja: Looks good to me, but someone else must approve
diff --git a/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl b/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl index bf2896e..be4aa5d 100644 --- a/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl +++ b/src/mainboard/razer/blade_stealth_kbl/acpi/mainboard.asl @@ -24,16 +24,4 @@ } }
- Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - - Method (_STA) - { - Return (0xF) - } - - Name (_PRW, Package () { 27, 4 }) - } - }
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41019 )
Change subject: mb/razer/blade_stealth_kbl: Remove duplicate ACPI power button device ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5016 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5015 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5014 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5013
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Mimoja (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)