Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38197 )
Change subject: [WIP] drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
[WIP] drivers/pc80/rtc: Drop ARCH_X86 guard in header
Change-Id: I03c25ad5d9864406e1a021e39a5736ac72c8825a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/elog/boot_count.c M src/drivers/elog/elog.c M src/include/pc80/mc146818rtc.h M src/lib/bootblock.c 4 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/38197/1
diff --git a/src/drivers/elog/boot_count.c b/src/drivers/elog/boot_count.c index a6efb01..6823a93 100644 --- a/src/drivers/elog/boot_count.c +++ b/src/drivers/elog/boot_count.c @@ -13,7 +13,6 @@
#include <console/console.h> #include <ip_checksum.h> -#include <pc80/mc146818rtc.h> #include <stddef.h> #include <stdint.h> #include <elog.h> diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 11cbfba..7f6c75b 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -17,9 +17,6 @@ #include <bootstate.h> #include <cbmem.h> #include <console/console.h> -#if CONFIG(ARCH_X86) -#include <pc80/mc146818rtc.h> -#endif #include <bcd.h> #include <boot_device.h> #include <commonlib/region.h> diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h index 8cc2ed4..f6359f1 100644 --- a/src/include/pc80/mc146818rtc.h +++ b/src/include/pc80/mc146818rtc.h @@ -1,14 +1,23 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #ifndef PC80_MC146818RTC_H #define PC80_MC146818RTC_H
-#if CONFIG(ARCH_X86) - #include <arch/io.h> #include <types.h>
-#ifndef RTC_BASE_PORT #define RTC_BASE_PORT 0x70 -#endif
#define RTC_PORT(x) (RTC_BASE_PORT + (x))
@@ -181,8 +190,4 @@ int cmos_checksum_valid(int range_start, int range_end, int cks_loc); void cmos_set_checksum(int range_start, int range_end, int cks_loc);
-#endif /* CONFIG_ARCH_X86 */ - -void cmos_post_init(void); - #endif /* PC80_MC146818RTC_H */ diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c index 386f4e3..166b3fe 100644 --- a/src/lib/bootblock.c +++ b/src/lib/bootblock.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <delay.h> #include <option.h> -#include <pc80/mc146818rtc.h> #include <program_loading.h> #include <symbols.h> #include <timestamp.h>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38197
to look at the new patch set (#3).
Change subject: [WIP] drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
[WIP] drivers/pc80/rtc: Drop ARCH_X86 guard in header
Change-Id: I03c25ad5d9864406e1a021e39a5736ac72c8825a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/elog/boot_count.c M src/drivers/elog/elog.c M src/include/pc80/mc146818rtc.h 3 files changed, 13 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/38197/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38197
to look at the new patch set (#9).
Change subject: [WIP] drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
[WIP] drivers/pc80/rtc: Drop ARCH_X86 guard in header
Change-Id: I03c25ad5d9864406e1a021e39a5736ac72c8825a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/elog/boot_count.c M src/drivers/elog/elog.c M src/include/pc80/mc146818rtc.h 3 files changed, 3 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/38197/9
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38197
to look at the new patch set (#10).
Change subject: drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
drivers/pc80/rtc: Drop ARCH_X86 guard in header
Change-Id: I03c25ad5d9864406e1a021e39a5736ac72c8825a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/pc80/mc146818rtc.h 1 file changed, 3 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/38197/10
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38197 )
Change subject: drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
Patch Set 10: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38197 )
Change subject: drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
Patch Set 10:
The file is still included by elog. Do we need better abstraction of cmos_read/write?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38197 )
Change subject: drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
Patch Set 10:
Patch Set 10:
The file is still included by elog. Do we need better abstraction of cmos_read/write?
What should be done on platforms without cmos? AFAIK the problem with elog is that it uses cmos, but it is also used on non-x86
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38197
to look at the new patch set (#11).
Change subject: drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
drivers/pc80/rtc: Drop ARCH_X86 guard in header
Change-Id: I03c25ad5d9864406e1a021e39a5736ac72c8825a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/pc80/mc146818rtc.h 1 file changed, 2 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/38197/11
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38197 )
Change subject: drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
Patch Set 12: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38197 )
Change subject: drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
drivers/pc80/rtc: Drop ARCH_X86 guard in header
Change-Id: I03c25ad5d9864406e1a021e39a5736ac72c8825a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38197 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/pc80/mc146818rtc.h 1 file changed, 2 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h index c9e054b..a2c65cb 100644 --- a/src/include/pc80/mc146818rtc.h +++ b/src/include/pc80/mc146818rtc.h @@ -1,14 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + #ifndef PC80_MC146818RTC_H #define PC80_MC146818RTC_H
-#if CONFIG(ARCH_X86) - #include <arch/io.h> #include <types.h>
-#ifndef RTC_BASE_PORT #define RTC_BASE_PORT 0x70 -#endif
#define RTC_PORT(x) (RTC_BASE_PORT + (x))
@@ -181,7 +179,4 @@ int cmos_checksum_valid(int range_start, int range_end, int cks_loc); void cmos_set_checksum(int range_start, int range_end, int cks_loc);
-#endif /* CONFIG_ARCH_X86 */ - - #endif /* PC80_MC146818RTC_H */
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38197 )
Change subject: drivers/pc80/rtc: Drop ARCH_X86 guard in header ......................................................................
Patch Set 13:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5058 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5057 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5056 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5055
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)