[PATCH] Don't select SERCON when target is coreboot

[Arthur Heymans]

CONFIG_SERCON=y breaks coreboot S3 (boots into payload instead of OS
reset vector).

Signed-off-by: Arthur Heymans

diff --git a/src/Kconfig b/src/Kconfig
index 55a87cb..597d4ce 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -308,6 +308,7 @@ menu "Hardware support"
             Support serial ports.  This also enables int 14 serial port calls.
     config SERCON
         bool "Serial console"
+        depends on !COREBOOT
         default y
         help
             Support redirecting vga output to the serial console.

[Gerd Hoffmann]

On Sun, Dec 24, 2017 at 02:53:27PM +0100, Arthur Heymans wrote:
> CONFIG_SERCON=y breaks coreboot S3 (boots into payload instead of OS
> reset vector).

Any clue why this is happening?

I can't see a fundamental incompatibility, and I think sercon can be
quite useful on coreboot too.  So finding and fixing the root cause
would be better than just disabling it ...

cheers,
  Gerd