On Wed, Mar 30, 2016 at 07:50:33PM +0200, Jenkins Build Host wrote:
See http://jenkins.xeni.kraxel.org:8080/job/seabios/220/changes
Changes:
[kevin] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e
[...]
Compile checking out/src/hw/mpt-scsi.o src/hw/mpt-scsi.c: In function 'init_mpt_scsi': src/hw/mpt-scsi.c:281:5: error: 'for' loop initial declarations are only allowed in C99 mode for (int i = 0; i < 7; i++) ^ src/hw/mpt-scsi.c:281:5: note: use option -std=c99 or -std=gnu99 to compile your code make: *** [out/src/hw/mpt-scsi.o] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.YLsXMX (%build)
It's interesting that newer compilers accept the 'int i' declaration inside of for loops - I didn't realize that was allowed in C99. In any case, I pulled the declaration outside the loop to suppress the error, and I committed the change.
-Kevin
On 31/03/2016 03:44, Kevin O'Connor wrote:
Compile checking out/src/hw/mpt-scsi.o src/hw/mpt-scsi.c: In function 'init_mpt_scsi': src/hw/mpt-scsi.c:281:5: error: 'for' loop initial declarations are only allowed in C99 mode for (int i = 0; i < 7; i++) ^ src/hw/mpt-scsi.c:281:5: note: use option -std=c99 or -std=gnu99 to compile your code make: *** [out/src/hw/mpt-scsi.o] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.YLsXMX (%build)
It's interesting that newer compilers accept the 'int i' declaration inside of for loops - I didn't realize that was allowed in C99. In any case, I pulled the declaration outside the loop to suppress the error, and I committed the change.
My fault, I did that on purpose---because SeaBIOS uses mixed declarations and statements I assumed that it was using -std=gnu99 already.
Paolo
Do you want to move the builds to our jenkins instance on qa.coreboot.org? We're already building coreboot, filo, flashrom and SerialICE and some other stuff.
Stefan
On 03/30/2016 06:44 PM, Kevin O'Connor wrote:
On Wed, Mar 30, 2016 at 07:50:33PM +0200, Jenkins Build Host wrote:
See http://jenkins.xeni.kraxel.org:8080/job/seabios/220/changes
Changes:
[kevin] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e
[...]
Compile checking out/src/hw/mpt-scsi.o src/hw/mpt-scsi.c: In function 'init_mpt_scsi': src/hw/mpt-scsi.c:281:5: error: 'for' loop initial declarations are only allowed in C99 mode for (int i = 0; i < 7; i++) ^ src/hw/mpt-scsi.c:281:5: note: use option -std=c99 or -std=gnu99 to compile your code make: *** [out/src/hw/mpt-scsi.o] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.YLsXMX (%build)
It's interesting that newer compilers accept the 'int i' declaration inside of for loops - I didn't realize that was allowed in C99. In any case, I pulled the declaration outside the loop to suppress the error, and I committed the change.
-Kevin
SeaBIOS mailing list SeaBIOS@seabios.org https://www.coreboot.org/mailman/listinfo/seabios
On Do, 2016-03-31 at 19:05 -0700, Stefan Reinauer wrote:
Do you want to move the builds to our jenkins instance on qa.coreboot.org? We're already building coreboot, filo, flashrom and SerialICE and some other stuff.
That jenkins instance builds firmware for qemu, packages things up as rpm, and pushes to https://www.kraxel.org/repos/ It also has coreboot builds (qemu-i440fx and qemu-q35) btw.
The main focus isn't doing testbuilds, catching build failures is more a (useful) side effect. So doing testbuilds @ qa.coreboot.org probably wouldn't be able to replace this. Nevertheless I wouldn't mind doing builds @ qa.coreboot.org too.
cheers, Gerd
-
Gerd Hoffmann -
Kevin O'Connor -
Paolo Bonzini -
Stefan Reinauer