This was somehow dropped during the iterations of the original Xen patches. It's actually harmless at the moment since there are no users of hypercalls but patches are being written to support Xen PV block devices which need this.
It's not clear exactly how early this needs to be but I think it needs to be at least before init_hw() (since that would detect disk devices). I put it first in maininit() since the only dependency is malloc().
Signed-off-by: Ian Campbell ian.campbell@citrix.com --- src/post.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/post.c b/src/post.c index d98941c..b2f6d51 100644 --- a/src/post.c +++ b/src/post.c @@ -210,6 +210,9 @@ startBoot(void) static void maininit(void) { + // Setup Xen hypercalls + xen_init_hypercalls(); + // Setup ivt/bda/ebda init_ivt(); init_bda();
On Wed, 2011-07-13 at 11:51 +0100, Ian Campbell wrote:
This was somehow dropped during the iterations of the original Xen patches. It's actually harmless at the moment since there are no users of hypercalls but patches are being written to support Xen PV block devices which need this.
It's not clear exactly how early this needs to be but I think it needs to be at least before init_hw() (since that would detect disk devices). I put it first in maininit() since the only dependency is malloc().
Signed-off-by: Ian Campbell ian.campbell@citrix.com
Ping?
src/post.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/post.c b/src/post.c index d98941c..b2f6d51 100644 --- a/src/post.c +++ b/src/post.c @@ -210,6 +210,9 @@ startBoot(void) static void maininit(void) {
- // Setup Xen hypercalls
- xen_init_hypercalls();
- // Setup ivt/bda/ebda init_ivt(); init_bda();
On Wed, Jul 20, 2011 at 10:38:49AM +0100, Ian Campbell wrote:
On Wed, 2011-07-13 at 11:51 +0100, Ian Campbell wrote:
This was somehow dropped during the iterations of the original Xen patches. It's actually harmless at the moment since there are no users of hypercalls but patches are being written to support Xen PV block devices which need this.
It's not clear exactly how early this needs to be but I think it needs to be at least before init_hw() (since that would detect disk devices). I put it first in maininit() since the only dependency is malloc().
Signed-off-by: Ian Campbell ian.campbell@citrix.com
Ping?
Sorry for the delay. I'm okay with the patch. If it doesn't need to be at the top of maininit though, I'd prefer to move it down a bit. How about after smm_init?
-Kevin
On Wed, 2011-07-20 at 13:44 +0100, Kevin O'Connor wrote:
On Wed, Jul 20, 2011 at 10:38:49AM +0100, Ian Campbell wrote:
On Wed, 2011-07-13 at 11:51 +0100, Ian Campbell wrote:
This was somehow dropped during the iterations of the original Xen patches. It's actually harmless at the moment since there are no users of hypercalls but patches are being written to support Xen PV block devices which need this.
It's not clear exactly how early this needs to be but I think it needs to be at least before init_hw() (since that would detect disk devices). I put it first in maininit() since the only dependency is malloc().
Signed-off-by: Ian Campbell ian.campbell@citrix.com
Ping?
Sorry for the delay. I'm okay with the patch. If it doesn't need to be at the top of maininit though, I'd prefer to move it down a bit. How about after smm_init?
Sure, Works For Me.
8<-------------------------------------------------------------
From 56ee604a43c2af652ffe4c2924e77175ecc693a3 Mon Sep 17 00:00:00 2001
From: Ian Campbell ian.campbell@citrix.com Date: Wed, 13 Jul 2011 11:46:40 +0100 Subject: [PATCH] xen: actually setup hypercalls.
This was somehow dropped during the iterations of the original Xen patches. It's actually harmless at the moment since there are no users of hypercalls but patches are being written to support Xen PV block devices which need this.
It's not clear exactly how early this needs to be but I think it needs to be at least before init_hw() (since that would detect disk devices).
Signed-off-by: Ian Campbell ian.campbell@citrix.com --- src/post.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/post.c b/src/post.c index d98941c..eb5a311 100644 --- a/src/post.c +++ b/src/post.c @@ -226,6 +226,9 @@ maininit(void) pci_setup(); smm_init();
+ // Setup Xen hypercalls + xen_init_hypercalls(); + // Initialize internal tables boot_setup();
On Wed, Jul 20, 2011 at 02:06:53PM +0100, Ian Campbell wrote:
On Wed, 2011-07-20 at 13:44 +0100, Kevin O'Connor wrote:
On Wed, Jul 20, 2011 at 10:38:49AM +0100, Ian Campbell wrote:
Ping?
Sorry for the delay. I'm okay with the patch. If it doesn't need to be at the top of maininit though, I'd prefer to move it down a bit. How about after smm_init?
Sure, Works For Me.
Thanks. I applied it.
-Kevin
On Thu, 2011-07-21 at 01:41 +0100, Kevin O'Connor wrote:
On Wed, Jul 20, 2011 at 02:06:53PM +0100, Ian Campbell wrote:
On Wed, 2011-07-20 at 13:44 +0100, Kevin O'Connor wrote:
On Wed, Jul 20, 2011 at 10:38:49AM +0100, Ian Campbell wrote:
Ping?
Sorry for the delay. I'm okay with the patch. If it doesn't need to be at the top of maininit though, I'd prefer to move it down a bit. How about after smm_init?
Sure, Works For Me.
Thanks. I applied it.
Thank you.
Ian.
-
Ian Campbell -
Ian Campbell -
Kevin O'Connor