Kevin,
Did you ever get a chance to look over this patch?
Thanks, Dave
----- Original Message -----
From: "Dave Frodin" dave.frodin@se-eng.com To: "Kevin O'Connor" kevin@koconnor.net Cc: "seabios" seabios@seabios.org Sent: Wednesday, June 5, 2013 8:45:11 AM Subject: Re: [SeaBIOS] [PATCH] Seabios: allow mapping of multiple PCI option ROMs to one
Kevin,
Attached is the new option rom mapping patch. I was hunting around for an existing SeaBIOS ftn that would convert ascii strings to a binary value (i.e. sscanf) but couldn't find one. If there's already one in the code I can replace the text_to_binary() with it.
I tested this on a AMD family14 platform. The vendev-map file I added to CBFS looks like this...
10029803-10029802 10029804-10029802 10029805-10029802 10029806-10029802 10029807-10029802 10029808-10029802 10029809-10029802
Each line ends with a NEWLINE character (0x0A).
On my test platform the actual graphics ID of the part is 10029804. The vgabios gets added to CBFS with the name "pci1002,9802.rom".
Thanks, Dave _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
On Tue, Jul 02, 2013 at 07:40:17AM -0500, Dave Frodin wrote:
Kevin,
Did you ever get a chance to look over this patch?
I don't see the gain in introducing a config file parser for this task. What was wrong with the approach of creating "alias" files?
-Kevin