Re: [SeaBIOS] [PATCH 3/6] Add runningOnQEMU() and runningOnXEN() ror runtime platform detection.

[Kevin O'Connor]

On Sat, Feb 09, 2013 at 08:42:31PM +0100, Fred . wrote:
> runningOnXEN()
>
> It is Xen not XEN. It is not capitalized.

I've updated the Kconfig comments in my tree.
> Also, hypercall_xen_version() has underscore, but runningOnXEN() has
> camelcase.
> Maybe runningOnXEN() should be named running_on_Xen() ?

For better or worse, SeaBIOS has no standard wrt camelcase names.

-Kevin

[PATCH 3/6] Add runningOnQEMU() and runningOnXEN() ror runtime platform detection.

[Fred .]

Maybe time to get a naming standard before it gets too messy?

Perhaps adapt the current naming standard used by the Linux kernel or
something?

Either way, there is no reason for Xen to be named XEN.

On Mon, Feb 11, 2013 at 4:27 AM, Kevin O'Connor  wrote:
> On Sat, Feb 09, 2013 at 08:42:31PM +0100, Fred . wrote:
> > runningOnXEN()
> >
> > It is Xen not XEN. It is not capitalized.
>
> I've updated the Kconfig comments in my tree.
> > Also, hypercall_xen_version() has underscore, but runningOnXEN() has
> > camelcase.
> > Maybe runningOnXEN() should be named running_on_Xen() ?
>
> For better or worse, SeaBIOS has no standard wrt camelcase names.
>
> -Kevin