On Mon, Sep 03, 2012 at 06:12:34PM +0200, Christian Gmeiner wrote:
2012/9/3 Kevin O'Connor kevin@koconnor.net:
On Sat, Sep 01, 2012 at 05:12:59PM +0200, Christian Gmeiner wrote:
* Bit(s) Description (Table 04082)* 15 preserve display memory on mode change* 14 (VBE v2.0+) use linear (flat) frame buffer* 13 (VBE/AF 1.0P) VBE/AF initializes accelerator hardware* 12 reserved for VBE/AF* 11 (VBE v3.0) user user-specified CRTC refresh rate values* 10-9 reserved for future expansion* 8-0 video mode number (0xxh are non-VESA modes, 1xxh are VESA-defined)** see http://www.ctyme.com/intr/rb-0274.htm*/This is true for the call to set mode (vbe_104f02), but the spec does not say this for the get mode info call (104f01). It would be odd to pass in these additional bits when the caller just wants to get info on the given mode.
But if I want more information's about mode 0x101 with linear framebuffer support - thats the only way to get it. Also this is triggered by src/bootsplash.c so it seems to be a valid use-case.
Hrmm - it seems odd - I don't think one can get info with "linear framebuffer support". I don't see anything in the spec that indicates they can. Definitely odd that bootsplash is doing that.
Does this mean you will not merge it?
I want to understand it first. If this is the right thing to do, then of course I'll merge it.
-Kevin
-
Kevin O'Connor