On Wed, Jun 09, 2010 at 05:38:41PM +0800, Liu, Jinsong wrote:
Gleb Natapov wrote:
Currently we didn't test it with Windows 2008 datacenter.
However, similar patch we also used for Xen (now already in Xen upstream). At Xen side, our QA team has tested with Windows 2008 datacenter. For vcpu hot-add, it worked well, the new CPUs can be found on both device manager and task manager. For vcpu hot-remove, as you said, it cannot work since cpu hot-remove is not supported by any Windows yet.
At KVM side, we test the patch with linux 2.6.32, vcpu hot-add and hot-remove both worked well. If you need, we can co-work with our QA to test our KVM patch with Windows 2008 datacenter.
It will be very helpful! Can you ask them to test the patch please?
Gleb,
Shaohui has done KVM vcpu hotplug test with Windows 2008 datacenter. For vcpu hot-add, new CPUs can be found on device manager. Thanks a lot for Shaohui's help!
Can't compile it:
$ make Compiling whole program out/ccode.16.s Compiling (16bit) out/code16.o Compiling whole program out/ccode32flat.o src/acpi.c:274:28: error: acpi-ssdt-15.hex: No such file or directory src/acpi.c:275:32: error: acpi-ssdt-anycpu.hex: No such file or directory src/acpi.c: In function 'build_fadt': src/acpi.c:307: error: 'acpi_dsdt' undeclared (first use in this function) src/acpi.c:307: error: (Each undeclared identifier is reported only once src/acpi.c:307: error: for each function it appears in.) src/acpi.c: In function 'build_ssdt': src/acpi.c:435: error: 'acpi_ssdt_anycpu' undeclared (first use in this function) src/acpi.c:436: error: 'acpi_ssdt_15' undeclared (first use in this function) make: *** [out/ccode32flat.o] Error 1
-- Gleb.
Gleb Natapov wrote:
On Wed, Jun 09, 2010 at 05:38:41PM +0800, Liu, Jinsong wrote:
Gleb Natapov wrote:
Currently we didn't test it with Windows 2008 datacenter.
However, similar patch we also used for Xen (now already in Xen upstream). At Xen side, our QA team has tested with Windows 2008 datacenter. For vcpu hot-add, it worked well, the new CPUs can be found on both device manager and task manager. For vcpu hot-remove, as you said, it cannot work since cpu hot-remove is not supported by any Windows yet.
At KVM side, we test the patch with linux 2.6.32, vcpu hot-add and hot-remove both worked well. If you need, we can co-work with our QA to test our KVM patch with Windows 2008 datacenter.
It will be very helpful! Can you ask them to test the patch please?
Gleb,
Shaohui has done KVM vcpu hotplug test with Windows 2008 datacenter. For vcpu hot-add, new CPUs can be found on device manager. Thanks a lot for Shaohui's help!
Can't compile it:
$ make Compiling whole program out/ccode.16.s Compiling (16bit) out/code16.o Compiling whole program out/ccode32flat.o src/acpi.c:274:28: error: acpi-ssdt-15.hex: No such file or directory src/acpi.c:275:32: error: acpi-ssdt-anycpu.hex: No such file or directory src/acpi.c: In function 'build_fadt': src/acpi.c:307: error: 'acpi_dsdt' undeclared (first use in this function) src/acpi.c:307: error: (Each undeclared identifier is reported only once src/acpi.c:307: error: for each function it appears in.) src/acpi.c: In function 'build_ssdt': src/acpi.c:435: error: 'acpi_ssdt_anycpu' undeclared (first use in this function) src/acpi.c:436: error: 'acpi_ssdt_15' undeclared (first use in this function) make: *** [out/ccode32flat.o] Error 1
Gleb,
Which patch do you use? I have send 2 patches before: 1st patch is mis-send test patch which need manually build, 2nd is updated patch to fix makefile issue, as attached email.
Thanks, Jinsong
-
Gleb Natapov -
Liu, Jinsong