Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code

[Moore, Robert]

Yes, you are correct, the listing no longer includes the comments.

Sorry for causing you a problem.

What is happening is that the preprocessor parser is stripping the comments during the creation of the .i file. Then, the compiler is invoked on the .i file -- thus, the comments are gone.

This is going to take a bit of work to correct, but we will do it.

In the meantime, try using the -Pn flag to disable the preprocessor. When this flag is set, the  preprocessor is completely bypassed and the compiler should function as it did previously.

Example below:

/*
 * Intel ACPI Component Architecture
 * iASL Compiler/Disassembler version 20120711-32 [Jul 30 2012]
 * Copyright (c) 2000 - 2012 Intel Corporation
 * 
 * Template for [DSDT] ACPI Table
 */

DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", "Template", 0x00000001)
{
    /* Comment for MAIN method */

Method (MAIN, 0, NotSerialized)
    {
        Return (Zero)
    }
}

C:\Acpi\listing>iasl -l -Pn dsdt.asl

Intel ACPI Component Architecture
ASL Optimizing Compiler version 20120711-32 [Jul 30 2012]
Copyright (c) 2000 - 2012 Intel Corporation

ASL Input:     dsdt.asl - 19 lines, 377 bytes, 2 keywords
AML Output:    dsdt.aml - 45 bytes, 1 named objects, 1 executable opcodes
Listing File:  dsdt.lst - 1536 bytes

Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations

dsdt.lst
--------

Intel ACPI Component Architecture
ASL Optimizing Compiler version 20120711-32 [Jul 30 2012]
Copyright (c) 2000 - 2012 Intel Corporation

Compilation of "dsdt.asl" - Mon Jul 30 12:37:36 2012

1..../*
       2.... * Intel ACPI Component Architecture
       3.... * iASL Compiler/Disassembler version 20120711-32 [Jul 19 2012]
       4.... * Copyright (c) 2000 - 2012 Intel Corporation
       5.... * 
       6.... * Template for [DSDT] ACPI Table
       7.... */
       8....
       9....DefinitionBlock ("dsdt.aml", "DSDT", 2, "Intel", "Template", 0x00000001)

00000000....44 53 44 54 2D 00 00 00     "DSDT-..."
00000008....02 03 49 6E 74 65 6C 00     "..Intel."
00000010....54 65 6D 70 6C 61 74 65     "Template"
00000018....01 00 00 00 49 4E 54 4C     "....INTL"
00000020....11 07 12 20 ............    "... "

10....{
      11....    /* Comment for MAIN method */
      12....
      13....    Method (MAIN, 0, NotSerialized)

00000024....14 08 4D 41 49 4E 00 ...    "..MAIN."

14....    {
      15....        Return (Zero)

0000002B....A4 00 ..................    ".."
      16....    }
      17....}
      18....
      19....
> -----Original Message-----
> From: Moore, Robert
> Sent: Monday, July 30, 2012 10:57 AM
> To: 'Idwer Vollering'
> Cc: Michael S. Tsirkin; Kevin O'Connor; [e-mail]
> Subject: RE: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with
> its ACPI code
>
> OK, I will take a look at it.
>
> Are all the comments throughout the code stripped from the listing?
> > -----Original Message-----
> > From: Idwer Vollering [mailto:[e-mail]]
> > Sent: Monday, July 30, 2012 10:35 AM
> > To: Moore, Robert
> > Cc: Michael S. Tsirkin; Kevin O'Connor; [e-mail]
> > Subject: Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems
> > with its ACPI code
> >
> > 2012/7/30 Moore, Robert :
> > > We have made some fixes regarding listing support in conjunction
> > > with
> >
> > the new preprocessor.
> > > Please try the very latest iASL compiler, version 20120711.
> > >
> > > Thanks,
> > > Bob
> >
> > Actually I have tried acpica-unix-20120711 (and acpica-unix-20120320,
> > acpica-unix-20120420, acpica-unix-20120518, acpica-unix-20120620).
> > The last version of iASL that worked (for me) with SeaBIOS is acpica-
> > unix-20120215.
> >
> > Idwer