Signed-off-by: Stefan Weil sw@weilnetz.de --- scripts/kconfig/lxdialog/util.c | 2 +- src/Kconfig | 2 +- src/biosvar.h | 2 +- src/bmp.c | 2 +- src/fw/shadow.c | 2 +- src/hw/pci_regs.h | 2 +- src/misc.c | 2 +- src/sha1.c | 4 ++-- src/std/LegacyBios.h | 4 ++-- src/std/bda.h | 2 +- src/string.c | 2 +- src/types.h | 2 +- src/vgahooks.c | 2 +- vgasrc/geodevga.h | 2 +- 14 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/scripts/kconfig/lxdialog/util.c b/scripts/kconfig/lxdialog/util.c index f7abdeb..2a0d182 100644 --- a/scripts/kconfig/lxdialog/util.c +++ b/scripts/kconfig/lxdialog/util.c @@ -376,7 +376,7 @@ void print_title(WINDOW *dialog, const char *title, int width) /* * Print a string of text in a window, automatically wrap around to the * next line if the string is too long to fit on one line. Newline - * characters '\n' are propperly processed. We start on a new line + * characters '\n' are properly processed. We start on a new line * if there is no room for at least 4 nonblanks following a double-space. */ void print_autowrap(WINDOW * win, const char *prompt, int width, int y, int x) diff --git a/src/Kconfig b/src/Kconfig index b873cd3..95bf087 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -20,7 +20,7 @@ choice Configure for an emulated machine (QEMU, Xen, KVM, or Bochs).
config CSM - bool "Build as Compatibilty Support Module for EFI BIOS" + bool "Build as Compatibility Support Module for EFI BIOS" help Configure to be used by EFI firmware as Compatibility Support module (CSM) to provide legacy BIOS services. diff --git a/src/biosvar.h b/src/biosvar.h index 58bcbce..3b40957 100644 --- a/src/biosvar.h +++ b/src/biosvar.h @@ -12,7 +12,7 @@
/**************************************************************** - * Interupt vector table + * Interrupt vector table ****************************************************************/
#define GET_IVT(vector) \ diff --git a/src/bmp.c b/src/bmp.c index d8e76b7..96a2b3f 100644 --- a/src/bmp.c +++ b/src/bmp.c @@ -1,6 +1,6 @@ /* * Basic BMP data process and Raw picture data handle functions. -* Could be used to adjust pixel data format, get infomation, etc. +* Could be used to adjust pixel data format, get information, etc. * * Copyright (C) 2011 Wayne Xia xiawenc@cn.ibm.com * diff --git a/src/fw/shadow.c b/src/fw/shadow.c index 4f00006..936ae28 100644 --- a/src/fw/shadow.c +++ b/src/fw/shadow.c @@ -65,7 +65,7 @@ make_bios_writable_intel(u16 bdf, u32 pam0) if (!(reg & 0x10)) { // QEMU doesn't fully implement the piix shadow capabilities - // if ram isn't backing the bios segment when shadowing is - // disabled, the code itself wont be in memory. So, run the + // disabled, the code itself won't be in memory. So, run the // code from the high-memory flash location. u32 pos = (u32)__make_bios_writable_intel + BIOS_SRC_OFFSET; void (*func)(u16 bdf, u32 pam0) = (void*)pos; diff --git a/src/hw/pci_regs.h b/src/hw/pci_regs.h index e5effd4..f7a455d 100644 --- a/src/hw/pci_regs.h +++ b/src/hw/pci_regs.h @@ -221,7 +221,7 @@ #define PCI_PM_CAP_PME_CLOCK 0x0008 /* PME clock required */ #define PCI_PM_CAP_RESERVED 0x0010 /* Reserved field */ #define PCI_PM_CAP_DSI 0x0020 /* Device specific initialization */ -#define PCI_PM_CAP_AUX_POWER 0x01C0 /* Auxilliary power support mask */ +#define PCI_PM_CAP_AUX_POWER 0x01C0 /* Auxiliary power support mask */ #define PCI_PM_CAP_D1 0x0200 /* D1 power state support */ #define PCI_PM_CAP_D2 0x0400 /* D2 power state support */ #define PCI_PM_CAP_PME 0x0800 /* PME pin supported */ diff --git a/src/misc.c b/src/misc.c index 8caaf31..f02237c 100644 --- a/src/misc.c +++ b/src/misc.c @@ -56,7 +56,7 @@ void VISIBLE16 handle_10(struct bregs *regs) { debug_enter(regs, DEBUG_HDL_10); - // dont do anything, since the VGA BIOS handles int10h requests + // don't do anything, since the VGA BIOS handles int10h requests }
// NMI handler diff --git a/src/sha1.c b/src/sha1.c index 352114f..2ecb3cb 100644 --- a/src/sha1.c +++ b/src/sha1.c @@ -33,7 +33,7 @@ sha1_block(u32 *w, sha1_ctx *ctx) static const u32 sha_ko[4] = { 0x5a827999, 0x6ed9eba1, 0x8f1bbcdc, 0xca62c1d6 };
- /* change endianess of given data */ + /* change endianness of given data */ for (i = 0; i < 16; i++) w[i] = be32_to_cpu(w[i]);
@@ -120,7 +120,7 @@ sha1_do(sha1_ctx *ctx, const u8 *data32, u32 length)
sha1_block(w, ctx);
- /* need to switch result's endianess */ + /* need to switch result's endianness */ for (num = 0; num < 5; num++) ctx->h[num] = cpu_to_be32(ctx->h[num]); } diff --git a/src/std/LegacyBios.h b/src/std/LegacyBios.h index 5170c37..e0c40d6 100644 --- a/src/std/LegacyBios.h +++ b/src/std/LegacyBios.h @@ -219,7 +219,7 @@ typedef struct { /// value of the start of the PCI Express memory-mapped configuration registers and /// must be filled in prior to EfiCompatibility code issuing the Compatibility16 function /// Compatibility16InitializeYourself(). - /// Compatibility16InitializeYourself() is defined in Compatability16 + /// Compatibility16InitializeYourself() is defined in Compatibility16 /// Functions. /// UINT32 PciExpressBase; @@ -252,7 +252,7 @@ typedef struct {
/// /// Functions provided by the CSM binary which communicate between the EfiCompatibility -/// and Compatability16 code. +/// and Compatibility16 code. /// /// Inconsistent with the specification here: /// The member's name started with "Compatibility16" [defined in Intel Framework diff --git a/src/std/bda.h b/src/std/bda.h index c321266..4ad6605 100644 --- a/src/std/bda.h +++ b/src/std/bda.h @@ -7,7 +7,7 @@
/**************************************************************** - * Interupt vector table + * Interrupt vector table ****************************************************************/
struct rmode_IVT { diff --git a/src/string.c b/src/string.c index 2e4e437..adb8198 100644 --- a/src/string.c +++ b/src/string.c @@ -227,7 +227,7 @@ strtcpy(char *dest, const char *src, size_t len) return dest; }
-// locate first occurance of character c in the string s +// locate first occurrence of character c in the string s char * strchr(const char *s, int c) { diff --git a/src/types.h b/src/types.h index 097372c..19d9f6c 100644 --- a/src/types.h +++ b/src/types.h @@ -70,7 +70,7 @@ extern void __force_link_error__only_in_16bit(void) __noreturn; # define VARFSEG __section(".discard.varfseg." UNIQSEC) __VISIBLE __weak // Designate a variable at a specific address in the f-segment. # define VARFSEGFIXED(addr) __section(".discard.varfixed." UNIQSEC) __VISIBLE __weak -// Verify a variable is only accessable via 32bit "init" functions +// Verify a variable is only accessible via 32bit "init" functions # define VARVERIFY32INIT __section(".discard.varinit." UNIQSEC) // Designate top-level assembler as 16bit only. # define ASM16(code) __ASM(code) diff --git a/src/vgahooks.c b/src/vgahooks.c index 6a4acfe..48efb08 100644 --- a/src/vgahooks.c +++ b/src/vgahooks.c @@ -124,7 +124,7 @@ getAMDRamSpeed(void)
/* int 0x15 - 5f18
- ECX = unknown/dont care + ECX = unknown/don't care EBX[3..0] Frame Buffer Size 2^N MiB EBX[7..4] Memory speed: 0: SDR 66Mhz diff --git a/vgasrc/geodevga.h b/vgasrc/geodevga.h index 61d7808..c99f54b 100644 --- a/vgasrc/geodevga.h +++ b/vgasrc/geodevga.h @@ -2,7 +2,7 @@ // // Copyright (C) 2009 Chris Kindt // -// Writen for Google Summer of Code 2009 for the coreboot project +// Written for Google Summer of Code 2009 for the coreboot project // // This file may be distributed under the terms of the GNU LGPLv3 license.
This makes checks with codespell easier.
Signed-off-by: Stefan Weil sw@weilnetz.de --- scripts/kconfig/conf.c | 6 +++--- scripts/kconfig/confdata.c | 2 +- scripts/kconfig/lkc_proto.h | 2 +- scripts/kconfig/mconf.c | 10 +++++----- scripts/kconfig/nconf.c | 10 +++++----- scripts/kconfig/qconf.cc | 2 +- scripts/kconfig/symbol.c | 2 +- 7 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index fef75fc..3db0406 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -91,7 +91,7 @@ static int conf_askvalue(struct symbol *sym, const char *def) line[0] = '\n'; line[1] = 0;
- if (!sym_is_changable(sym)) { + if (!sym_is_changeable(sym)) { printf("%s\n", def); line[0] = '\n'; line[1] = 0; @@ -240,7 +240,7 @@ static int conf_choice(struct menu *menu)
sym = menu->sym; is_new = !sym_has_value(sym); - if (sym_is_changable(sym)) { + if (sym_is_changeable(sym)) { conf_sym(menu); sym_calc_value(sym); switch (sym_get_tristate_value(sym)) { @@ -427,7 +427,7 @@ static void check_conf(struct menu *menu)
sym = menu->sym; if (sym && !sym_has_value(sym)) { - if (sym_is_changable(sym) || + if (sym_is_changeable(sym) || (sym_is_choice(sym) && sym_get_tristate_value(sym) == yes)) { if (input_mode == listnewconfig) { if (sym->name && !sym_is_choice_value(sym)) { diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 08e7559..bb44bce 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -690,7 +690,7 @@ int conf_write_defconfig(const char *filename) goto next_menu; sym->flags &= ~SYMBOL_WRITE; /* If we cannot change the symbol - skip */ - if (!sym_is_changable(sym)) + if (!sym_is_changeable(sym)) goto next_menu; /* If symbol equals to default value - skip */ if (strcmp(sym_get_string_value(sym), sym_get_string_default(sym)) == 0) diff --git a/scripts/kconfig/lkc_proto.h b/scripts/kconfig/lkc_proto.h index ecdb965..a6e30c7 100644 --- a/scripts/kconfig/lkc_proto.h +++ b/scripts/kconfig/lkc_proto.h @@ -45,7 +45,7 @@ P(sym_toggle_tristate_value,tristate,(struct symbol *sym)); P(sym_string_valid,bool,(struct symbol *sym, const char *newval)); P(sym_string_within_range,bool,(struct symbol *sym, const char *str)); P(sym_set_string_value,bool,(struct symbol *sym, const char *newval)); -P(sym_is_changable,bool,(struct symbol *sym)); +P(sym_is_changeable,bool,(struct symbol *sym)); P(sym_get_choice_prop,struct property *,(struct symbol *sym)); P(sym_get_default_prop,struct property *,(struct symbol *sym)); P(sym_get_string_value,const char *,(struct symbol *sym)); diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c index 14cea74..68720ed 100644 --- a/scripts/kconfig/mconf.c +++ b/scripts/kconfig/mconf.c @@ -537,7 +537,7 @@ static void build_conf(struct menu *menu) }
val = sym_get_tristate_value(sym); - if (sym_is_changable(sym)) { + if (sym_is_changeable(sym)) { switch (type) { case S_BOOLEAN: item_make("[%c]", val == no ? ' ' : '*'); @@ -588,7 +588,7 @@ static void build_conf(struct menu *menu) } else { switch (type) { case S_BOOLEAN: - if (sym_is_changable(sym)) + if (sym_is_changeable(sym)) item_make("[%c]", val == no ? ' ' : '*'); else item_make("-%c-", val == no ? ' ' : '*'); @@ -601,7 +601,7 @@ static void build_conf(struct menu *menu) case mod: ch = 'M'; break; default: ch = ' '; break; } - if (sym_is_changable(sym)) { + if (sym_is_changeable(sym)) { if (sym->rev_dep.tri == mod) item_make("{%c}", ch); else @@ -618,7 +618,7 @@ static void build_conf(struct menu *menu) if (tmp < 0) tmp = 0; item_add_str("%*c%s%s", tmp, ' ', _(menu_get_prompt(menu)), - (sym_has_value(sym) || !sym_is_changable(sym)) ? + (sym_has_value(sym) || !sym_is_changeable(sym)) ? "" : _(" (NEW)")); item_set_tag('s'); item_set_data(menu); @@ -626,7 +626,7 @@ static void build_conf(struct menu *menu) } } item_add_str("%*c%s%s", indent + 1, ' ', _(menu_get_prompt(menu)), - (sym_has_value(sym) || !sym_is_changable(sym)) ? + (sym_has_value(sym) || !sym_is_changeable(sym)) ? "" : _(" (NEW)")); if (menu->prompt->type == P_MENU) { item_add_str(" %s", menu_is_empty(menu) ? "----" : "--->"); diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c index 984489e..7323e08 100644 --- a/scripts/kconfig/nconf.c +++ b/scripts/kconfig/nconf.c @@ -801,7 +801,7 @@ static void build_conf(struct menu *menu) }
val = sym_get_tristate_value(sym); - if (sym_is_changable(sym)) { + if (sym_is_changeable(sym)) { switch (type) { case S_BOOLEAN: item_make(menu, 't', "[%c]", @@ -855,7 +855,7 @@ static void build_conf(struct menu *menu) } else { switch (type) { case S_BOOLEAN: - if (sym_is_changable(sym)) + if (sym_is_changeable(sym)) item_make(menu, 't', "[%c]", val == no ? ' ' : '*'); else @@ -874,7 +874,7 @@ static void build_conf(struct menu *menu) ch = ' '; break; } - if (sym_is_changable(sym)) { + if (sym_is_changeable(sym)) { if (sym->rev_dep.tri == mod) item_make(menu, 't', "{%c}", ch); @@ -894,14 +894,14 @@ static void build_conf(struct menu *menu) item_add_str("%*c%s%s", tmp, ' ', _(menu_get_prompt(menu)), (sym_has_value(sym) || - !sym_is_changable(sym)) ? "" : + !sym_is_changeable(sym)) ? "" : _(" (NEW)")); goto conf_childs; } } item_add_str("%*c%s%s", indent + 1, ' ', _(menu_get_prompt(menu)), - (sym_has_value(sym) || !sym_is_changable(sym)) ? + (sym_has_value(sym) || !sym_is_changeable(sym)) ? "" : _(" (NEW)")); if (menu->prompt && menu->prompt->type == P_MENU) { item_add_str(" %s", menu_is_empty(menu) ? "----" : "--->"); diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index 9d3b04b..be8935f 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qconf.cc @@ -169,7 +169,7 @@ void ConfigItem::updateMenu(void) case S_TRISTATE: char ch;
- if (!sym_is_changable(sym) && list->optMode == normalOpt) { + if (!sym_is_changeable(sym) && list->optMode == normalOpt) { setPixmap(promptColIdx, 0); setText(noColIdx, QString::null); setText(modColIdx, QString::null); diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c index 7caabdb..8fe9765 100644 --- a/scripts/kconfig/symbol.c +++ b/scripts/kconfig/symbol.c @@ -781,7 +781,7 @@ const char *sym_get_string_value(struct symbol *sym) return (const char *)sym->curr.val; }
-bool sym_is_changable(struct symbol *sym) +bool sym_is_changeable(struct symbol *sym) { return sym->visible > sym->rev_dep.tri; }
Am Freitag, den 02.10.2015, 08:46 +0200 schrieb Stefan Weil:
This makes checks with codespell easier.
Signed-off-by: Stefan Weil sw@weilnetz.de
scripts/kconfig/conf.c | 6 +++--- scripts/kconfig/confdata.c | 2 +- scripts/kconfig/lkc_proto.h | 2 +- scripts/kconfig/mconf.c | 10 +++++----- scripts/kconfig/nconf.c | 10 +++++----- scripts/kconfig/qconf.cc | 2 +- scripts/kconfig/symbol.c | 2 +- 7 files changed, 17 insertions(+), 17 deletions(-)
[…]
The misspelled name was just `sym_is_changeable`, right?
Acked-by: Paul Menzel paulepanter@users.sourceforge.net
Thanks,
Paul
Am 02.10.2015 um 09:03 schrieb Paul Menzel:
Am Freitag, den 02.10.2015, 08:46 +0200 schrieb Stefan Weil:
This makes checks with codespell easier.
Signed-off-by: Stefan Weil sw@weilnetz.de
scripts/kconfig/conf.c | 6 +++--- scripts/kconfig/confdata.c | 2 +- scripts/kconfig/lkc_proto.h | 2 +- scripts/kconfig/mconf.c | 10 +++++----- scripts/kconfig/nconf.c | 10 +++++----- scripts/kconfig/qconf.cc | 2 +- scripts/kconfig/symbol.c | 2 +- 7 files changed, 17 insertions(+), 17 deletions(-)
[…]
The misspelled name was just `sym_is_changeable`, right?
Yes, that's correct.
Regards Stefan
On Fri, Oct 02, 2015 at 08:46:41AM +0200, Stefan Weil wrote:
This makes checks with codespell easier.
Signed-off-by: Stefan Weil sw@weilnetz.de
scripts/kconfig/conf.c | 6 +++--- scripts/kconfig/confdata.c | 2 +- scripts/kconfig/lkc_proto.h | 2 +- scripts/kconfig/mconf.c | 10 +++++----- scripts/kconfig/nconf.c | 10 +++++----- scripts/kconfig/qconf.cc | 2 +- scripts/kconfig/symbol.c | 2 +- 7 files changed, 17 insertions(+), 17 deletions(-)
Thanks, but kconfig is pulled in from Linux. The above would need to be fixed in upstream - if it gets fixed there I'll resynch kconfig in seabios.
-Kevin
On Fri, Oct 02, 2015 at 08:46:40AM +0200, Stefan Weil wrote:
Signed-off-by: Stefan Weil sw@weilnetz.de
scripts/kconfig/lxdialog/util.c | 2 +- src/Kconfig | 2 +- src/biosvar.h | 2 +- src/bmp.c | 2 +- src/fw/shadow.c | 2 +- src/hw/pci_regs.h | 2 +- src/misc.c | 2 +- src/sha1.c | 4 ++-- src/std/LegacyBios.h | 4 ++-- src/std/bda.h | 2 +- src/string.c | 2 +- src/types.h | 2 +- src/vgahooks.c | 2 +- vgasrc/geodevga.h | 2 +- 14 files changed, 16 insertions(+), 16 deletions(-)
Thanks. The LegacyBios.h and pci_regs.h are external files and so I don't think it's worth fixing spelling errors in them. The other changes look good to me.
-Kevin
On Fri, Oct 02, 2015 at 08:46:40AM +0200, Stefan Weil wrote:
Signed-off-by: Stefan Weil sw@weilnetz.de
scripts/kconfig/lxdialog/util.c | 2 +- src/Kconfig | 2 +- src/biosvar.h | 2 +- src/bmp.c | 2 +- src/fw/shadow.c | 2 +- src/hw/pci_regs.h | 2 +- src/misc.c | 2 +- src/sha1.c | 4 ++-- src/std/LegacyBios.h | 4 ++-- src/std/bda.h | 2 +- src/string.c | 2 +- src/types.h | 2 +- src/vgahooks.c | 2 +- vgasrc/geodevga.h | 2 +- 14 files changed, 16 insertions(+), 16 deletions(-)
I removed the changes to pci_regs.h and LegacyBios.h and committed this patch.
Thanks, -Kevin
-
Kevin O'Connor -
Paul Menzel -
Stefan Weil