On Fri, Dec 04, 2015 at 09:04:35PM +0000, edward wandasiewicz wrote:
Here's what happens with x1 Philips USB attached and x1 Mushkin attached, and we cold boot with Kevin's patched SeaBIOS
FIXED - when Philips drive is detected, it appears only once and once only in the list of bootable devices - cbmem -c attached
BROKE - the Mushkin drive hardly ever gets detected - Google ChromeOS recovery SeaBIOS would always find it
BROKEN - when Mushkin drive is detected, only the Mushkin is showing in the list, no Philips in the list of bootable devices - cbmem -c attached (reboot following a cold boot with Philips only showing)
Sometimes Mushkin will appear on a cold boot - not very often, with no Philips showing in the list, with both devices plugged in on boot up.
[...]
|7cddd000| xhci_address: enable slot: got slotid 1 |7cddd000| xhci_cmd_address_device: slotid 1 |7cddd000| xhci_trb_queue: ring 0x7ce39d00 [nidx 2, len 0] |7cddd000| xhci_process_events: ring 0x7ce39d00 [trb 0x7ce39d10, evt 0x7ce39e00, type 33, eidx 2, cc 4] |7cddd000| xhci_cmd_disable_slot: slotid 1 |7cddd000| xhci_trb_queue: ring 0x7ce39d00 [nidx 3, len 0] |7cddd000| xhci_process_events: ring 0x7ce39d00 [trb 0x7ce39d20, evt 0x7ce39e00, type 33, eidx 3, cc 1] |7cddd000| xhci_address: disable failed (cc 1/4)
It looks like I messed up the error check on the patch. I uploaded a new patch. Can you clone the "testing" branch again and retry?
Thanks, -Kevin