Re: [SeaBIOS] [PATCH] KVM vcpu hotplug seabios infrastructure

[Gleb Natapov]

On Tue, May 18, 2010 at 05:08:29PM +0800, Liu, Jinsong wrote:
> Hi, Kevin, Gleb, Avi, and Yunhong
>
> I have updated vcpu hotplug seabios infrastructure, as attached. Please kindly review it, thanks!

Applied it to upstream Seabios, but can't compile:

src/acpi.c:274:28: error: acpi-ssdt-15.hex: No such file or directory
src/acpi.c:275:32: error: acpi-ssdt-anycpu.hex: No such file or
directory
src/acpi.c: In function 'build_fadt':
src/acpi.c:307: error: 'acpi_dsdt' undeclared (first use in this
function)
src/acpi.c:307: error: (Each undeclared identifier is reported only once
src/acpi.c:307: error: for each function it appears in.)
src/acpi.c: In function 'build_ssdt':
src/acpi.c:435: error: 'acpi_ssdt_anycpu' undeclared (first use in this
function)
src/acpi.c:436: error: 'acpi_ssdt_15' undeclared (first use in this
function)
make: *** [out/ccode32flat.o] Error 1

[PATCH] KVM vcpu hotplug seabios infrastructure

[Liu, Jinsong]

Gleb,

Thanks a lot for comments!
It's my fault when I presented patch last time, I manually build 15.c and anycpu.c at my desktop.

I update the patch, as attached, 
and test at my desktop, it now build & work OK.

The process to apply patch and build in my desktop is:
$ git apply kvm-vcpu-hotplug-seabios.patch
$ git add src/acpi-ssdt.dsl
$ git add src/mk_ssdt.c
$ git commit -a
$ make

Thanks,
Jinsong

Gleb Natapov wrote:
> On Tue, May 18, 2010 at 05:08:29PM +0800, Liu, Jinsong wrote:
> > Hi, Kevin, Gleb, Avi, and Yunhong
> >
> > I have updated vcpu hotplug seabios infrastructure, as attached.
> > Please kindly review it, thanks!
>
> Applied it to upstream Seabios, but can't compile:
>
> src/acpi.c:274:28: error: acpi-ssdt-15.hex: No such file or directory
> src/acpi.c:275:32: error: acpi-ssdt-anycpu.hex: No such file or
> directory
> src/acpi.c: In function 'build_fadt':
> src/acpi.c:307: error: 'acpi_dsdt' undeclared (first use in this
> function)
> src/acpi.c:307: error: (Each undeclared identifier is reported only
> once src/acpi.c:307: error: for each function it appears in.)
> src/acpi.c: In function 'build_ssdt':
> src/acpi.c:435: error: 'acpi_ssdt_anycpu' undeclared (first use in
> this function)
> src/acpi.c:436: error: 'acpi_ssdt_15' undeclared (first use in this
> function)
> make: *** [out/ccode32flat.o] Error 1