Re: [SeaBIOS] Kconfig for SeaBIOS finally
On Mon, Jan 17, 2011 at 09:13:47PM +0100, Marc Bertens wrote:
Kevin,
This is the final patch for Kconfig for SeaBIOS.
Tested-by Marc Bertens <mbertens@xs4all.nl> Signed-off Marc Bertens <mbertens@xs4all.nl>
Its now all in one big patch, it has now one config.h file. This should be straight forward.
Thanks. Unfortunately, it's still too big for the mailing list. Can you post this in two patches - one that adds the tools/kconfig/ files, and one that modifies the SeaBIOS files (Makefile, src/*). I can put the tools/kconfig/ part on the web, and we can discuss the seabios parts on the mailing list. Some comments on that patch: The patch seems to be missing src/Kconfig. [...]
+#elif CONFIG_NAME_QEMU +/* the Q-Emu name was selected */ +#define CONFIG_APPNAME "QEMU" +#define CONFIG_CPUNAME8 "QEMUCPU " +#define CONFIG_APPNAME6 "QEMU " +#define CONFIG_APPNAME4 "QEMU" + +#elif CONFIG_NAME_COREBOOT +/* the Coreboot name was selected */ +#define CONFIG_APPNAME "Coreboot" +#define CONFIG_CPUNAME8 "CRBTCPU " +#define CONFIG_APPNAME6 "COREBT" +#define CONFIG_APPNAME4 "CRBT"
This adds new names - which is a topic in itself. Lets have the first kconfig patch just add in the basic capabilities, and then we can add new features on top of it. I suggest leaving the names hard coded in config.h for now - setting them via kconfig can be a follow up patch. Thanks for working on this. -Kevin
Did it the old way, so that i can understand what i'm sending so that i can check what i'm doing is correct, at least to my opinion :-) Marc On Mon, 2011-01-17 at 15:40 -0500, Kevin O'Connor wrote:
On Mon, Jan 17, 2011 at 09:13:47PM +0100, Marc Bertens wrote:
Kevin,
This is the final patch for Kconfig for SeaBIOS.
Tested-by Marc Bertens <mbertens@xs4all.nl> Signed-off Marc Bertens <mbertens@xs4all.nl>
Its now all in one big patch, it has now one config.h file. This should be straight forward.
Thanks. Unfortunately, it's still too big for the mailing list.
Can you post this in two patches - one that adds the tools/kconfig/ files, and one that modifies the SeaBIOS files (Makefile, src/*). I can put the tools/kconfig/ part on the web, and we can discuss the seabios parts on the mailing list.
Some comments on that patch:
The patch seems to be missing src/Kconfig.
[...]
+#elif CONFIG_NAME_QEMU +/* the Q-Emu name was selected */ +#define CONFIG_APPNAME "QEMU" +#define CONFIG_CPUNAME8 "QEMUCPU " +#define CONFIG_APPNAME6 "QEMU " +#define CONFIG_APPNAME4 "QEMU" + +#elif CONFIG_NAME_COREBOOT +/* the Coreboot name was selected */ +#define CONFIG_APPNAME "Coreboot" +#define CONFIG_CPUNAME8 "CRBTCPU " +#define CONFIG_APPNAME6 "COREBT" +#define CONFIG_APPNAME4 "CRBT"
This adds new names - which is a topic in itself. Lets have the first kconfig patch just add in the basic capabilities, and then we can add new features on top of it. I suggest leaving the names hard coded in config.h for now - setting them via kconfig can be a follow up patch.
Thanks for working on this. -Kevin
On Mon, Jan 17, 2011 at 10:40:58PM +0100, Marc Bertens wrote:
Did it the old way, so that i can understand what i'm sending so that i can check what i'm doing is correct, at least to my opinion :-)
Hi Marc, Your patch doesn't look complete. I get build failures when trying different build options and when selecting different configuration options. Also, I think pulling kconfig from the latest linux source would be preferable to pulling from coreboot. There seems to be a number of improvements in the linux version of kconfig. If I get time I'll look at doing this. -Kevin
Kevin, What kind of errors on which options ? so that i can check my work, i use only seabios with coreboot and at the moment only with the defaults. But i'm ready to experiment with different options on seabios, due that my machine does not have keyboard, mouse, video, floppy or printer port. So therefore I need to make some different build either of seabios. And yes always a good idea to check the latest version, i just needed a version that worked and was quickly available that's why i take the coreboot version, i did known of any differences. Marc On Sun, 2011-01-23 at 12:58 -0500, Kevin O'Connor wrote:
can check what i'm doing is correct, at least to my opinion :-)
Hi Marc,
Your patch doesn't look complete. I get build failures when trying different build options and when selecting different configuration options.
Also, I think pulling kconfig from the latest linux source would be preferable to pulling from coreboot. There seems to be a number of improvements in the linux version of kconfig. If I get time I'll look at doing this.
-Kevin
On Sun, Jan 23, 2011 at 07:55:23PM +0100, Marc Bertens wrote:
Kevin,
What kind of errors on which options ? so that i can check my work, i use only seabios with coreboot and at the moment only with the defaults. But i'm ready to experiment with different options on seabios, due that my machine does not have keyboard, mouse, video, floppy or printer port. So therefore I need to make some different build either of seabios.
And yes always a good idea to check the latest version, i just needed a version that worked and was quickly available that's why i take the coreboot version, i did known of any differences.
Hi Marc, Just turning off CONFIG_COREBOOT causes compiler failures for me. I get errors about undefined symbols like the following: src/misc.c:18:21: error: ‘CONFIG_MAX_BIOSTABLE’ undeclared here (not in a function) Compiling with the defconfig you mailed me had the same issue. -Kevin
Kevin, I'm currently underway of fixing the Kconfig errors, already fixed coreboot Y/N issue. But i notice that this takes some work due to the way its currently coded. i did already boot.c, coreboot.c and ramdisk.c and there will be changes all over the place :-) So this will be a mega patch Marc
On Sun, Jan 23, 2011 at 09:01:41PM +0100, Marc Bertens wrote:
Kevin,
I'm currently underway of fixing the Kconfig errors, already fixed coreboot Y/N issue. But i notice that this takes some work due to the way its currently coded. i did already boot.c, coreboot.c and ramdisk.c and there will be changes all over the place :-)
So this will be a mega patch
No. No. Kconfig must change to seabios; seabios source code should not change to use kconfig. -Kevin
Kevin, You're right and it was easier than i expected :-) I removed the "depends" from the Kconfig file. and that solves most of the errors. i'll will continue testing it but I cannot test it all. Here is the new Kconfig file for testing, I hope that you have some time too for testing this. On Sun, 2011-01-23 at 15:39 -0500, Kevin O'Connor wrote:
On Sun, Jan 23, 2011 at 09:01:41PM +0100, Marc Bertens wrote:
Kevin,
I'm currently underway of fixing the Kconfig errors, already fixed coreboot Y/N issue. But i notice that this takes some work due to the way its currently coded. i did already boot.c, coreboot.c and ramdisk.c and there will be changes all over the place :-)
So this will be a mega patch
No. No. Kconfig must change to seabios; seabios source code should not change to use kconfig.
-Kevin
Kevin, I tested many different combinations and i could not find any errors in compiling or running SeaBIOS. Note that when I run SeaBIOS thats with coreboot on a PIII, I440BX, 83371 hardware (Nokia-IP530). Sign-off: Marc Bertens <mbertens@xs4all.nl> Can you tell me why the SeaBIOS code keeps all its functions even when there are not needed? Would it nicer to exclude whole pieces of code that are not required? Marc On Mon, 2011-01-24 at 09:50 +0100, Marc Bertens wrote:
Kevin,
You're right and it was easier than i expected :-) I removed the "depends" from the Kconfig file. and that solves most of the errors.
i'll will continue testing it but I cannot test it all.
Here is the new Kconfig file for testing, I hope that you have some time too for testing this.
On Sun, 2011-01-23 at 15:39 -0500, Kevin O'Connor wrote:
On Sun, Jan 23, 2011 at 09:01:41PM +0100, Marc Bertens wrote:
Kevin,
I'm currently underway of fixing the Kconfig errors, already fixed coreboot Y/N issue. But i notice that this takes some work due to the way its currently coded. i did already boot.c, coreboot.c and ramdisk.c and there will be changes all over the place :-)
So this will be a mega patch
No. No. Kconfig must change to seabios; seabios source code should not change to use kconfig.
-Kevin
_______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
On Mon, Jan 24, 2011 at 10:50:49AM +0100, Marc Bertens wrote:
Can you tell me why the SeaBIOS code keeps all its functions even when there are not needed? Would it nicer to exclude whole pieces of code that are not required?
The build arranges for the compiler and linker to remove the unused code automatically. -Kevin
Kevin O'Connor wrote:
+#define CONFIG_APPNAME "Coreboot" .. This adds new names - which is a topic in itself. Lets have the first kconfig patch just add in the basic capabilities,
Note that coreboot should always be written without capitals. //Peter
participants (3)
-
Kevin O'Connor -
Marc Bertens -
Peter Stuge