Re: [SeaBIOS] [PATCH] KVM vcpu hotplug seabios infrastructure

[Gleb Natapov]

On Wed, Jun 09, 2010 at 10:01:47PM +0800, Liu, Jinsong wrote:
> Gleb Natapov wrote:
> > On Wed, Jun 09, 2010 at 09:20:07PM +0800, Liu, Jinsong wrote:
> > > Which patch do you use?
> > > I have send 2 patches before:
> > > 1st patch is mis-send test patch which need manually build,
> > > 2nd is updated patch to fix makefile issue, as attached email.
> >
> > The patch you attached now compiles for me. Thanks.
>
> Kevin, Gleb, and All
>
> Currently KVM vcpu hotplug patch status is,
> 1). works OK with Linux 2.6.32 (hot-add and hot-remove);
> 2). works OK with Windows 2008 datacenter (hot-add);

FWIW looks good to me. This patch removes dynamic creation of Processor
scope and supports only 15/255 cpus configuration, but given that new
code is much more complex that old one I don't see other possibilities
(unless we'll add aml compiler to seabios runtime).
> As for iasl, I notice that current Makefile use iasl at dsdt build rules. I understand for user it seldom used if no change dsdt.
> In our patch, how about use iasl (ssdt build rules) in Makefile, and I will build ssdt in my local server, and then send the compile result to you which contain acpi-ssdt[] aml array (that will be a big size patch)? We provide user a full built bios.bin and user don't need run 'iasl' when Makefile.
>
> Thanks,
> Jinsong

[PATCH] KVM vcpu hotplug seabios infrastructure

[Liu, Jinsong]

Gleb Natapov wrote:
> On Wed, Jun 09, 2010 at 10:01:47PM +0800, Liu, Jinsong wrote:
> > Gleb Natapov wrote:
> > > On Wed, Jun 09, 2010 at 09:20:07PM +0800, Liu, Jinsong wrote:
> > > > Which patch do you use?
> > > > I have send 2 patches before:
> > > > 1st patch is mis-send test patch which need manually build,
> > > > 2nd is updated patch to fix makefile issue, as attached email.
> > >
> > > The patch you attached now compiles for me. Thanks.
> >
> > Kevin, Gleb, and All
> >
> > Currently KVM vcpu hotplug patch status is,
> > 1). works OK with Linux 2.6.32 (hot-add and hot-remove);
> > 2). works OK with Windows 2008 datacenter (hot-add);
>
> FWIW looks good to me. This patch removes dynamic creation of
> Processor scope and supports only 15/255 cpus configuration, but
> given that new code is much more complex that old one I don't see
> other possibilities (unless we'll add aml compiler to seabios
> runtime).

Thanks Gleb for comments!

Kevin, what's your comments?

Thanks,
Jinsong
> > As for iasl, I notice that current Makefile use iasl at dsdt build
> > rules. I understand for user it seldom used if no change dsdt. 
> > In our patch, how about use iasl (ssdt build rules) in Makefile, and
> > I will build ssdt in my local server, and then send the compile
> > result to you which contain acpi-ssdt[] aml array (that will be a
> > big size patch)? We provide user a full built bios.bin and user
> > don't need run 'iasl' when Makefile.
> >
> > Thanks,
> > Jinsong