Re: [SeaBIOS] [PATCH v10 3/6] Support for BIOS interrupt handler

[Stefan Berger]

On 04/30/2015 09:21 AM, Xu, Quan wrote:
 
 Stefan,
 	Sorry to reply so late to you. I try to make it compatible with Xen vTPM by below patch
 Against your serious of patch(https://github.com/KevinOConnor/seabios/tree/tcg-testing
).
 Also I have tested this patch, which is working.
Thanks.



 

 ### >>> patch
 commit 2c556064695b0a979adb4039f13db1b29a19d3cf
 Author: Quan Xu <quan.xu(a)intel.com>
 Date:   Thu Apr 30 19:43:04 2015 -0400

      make SeaBios compatible with Xen vTPM.

      Signed-off-by: Quan Xu <quan.xu(a)intel.com>

 diff --git a/src/tcgbios.c b/src/tcgbios.c
 index c837ab6..4cda800 100644
 --- a/src/tcgbios.c
 +++ b/src/tcgbios.c
 @@ -23,7 +23,7 @@
   #include "std/acpi.h"  // RSDP_SIGNATURE, rsdt_descriptor
   #include "bregs.h" // struct bregs
   #include "sha1.h" // sha1
 -
 +#include "fw/paravirt.h" // runningOnXen

   static const u8 Startup_ST_CLEAR[2] = { 0x00, TPM_ST_CLEAR };
   static const u8 Startup_ST_STATE[2] = { 0x00, TPM_ST_STATE };
 @@ -494,6 +494,8 @@ tpm_start(void)
           return 0;

       tpm_acpi_init();
 +    if (runningOnXen())
 +        return 0;

       return tpm_startup();
   }

 ### <<< patch
Kevin, I think this should be good to add after 3/6 ?

    Stefan

[PATCH v10 3/6] Support for BIOS interrupt handler

[Kevin O'Connor]

On Thu, Apr 30, 2015 at 11:34:20AM -0400, Stefan Berger wrote:
  On 04/30/2015 09:21 AM, Xu, Quan wrote:
 >
 >Stefan,
 >	Sorry to reply so late to you. I try to make it compatible with Xen vTPM by below
patch
 >Against your serious of
patch(https://github.com/KevinOConnor/seabios/tree/tcg-testing ).
 >Also I have tested this patch, which is working.
[...]
  
 Kevin, I think this should be good to add after 3/6 ?
Thanks - I applied the first three tpm patches along with this patch.

-Kevin

[PATCH v10 3/6] Support for BIOS interrupt handler

[Xu, Quan]

  -----Original Message-----
 From: Kevin O'Connor [mailto:[e-mail]]
 Sent: Friday, May 22, 2015 1:20 AM
 To: Stefan Berger
 Cc: Xu, Quan; seabios(a)seabios.org; stefano.stabellini(a)eu.citrix.com;
 xen-devel(a)lists.xen.org; Daniel De Graaf; wei.liu2(a)citrix.com
 Subject: Re: [PATCH v10 3/6] Support for BIOS interrupt handler
 
 On Thu, Apr 30, 2015 at 11:34:20AM -0400, Stefan Berger wrote:
  On 04/30/2015 09:21 AM, Xu, Quan wrote:
 >
 >Stefan,
 >	Sorry to reply so late to you. I try to make it compatible with Xen
 >vTPM by below patch Against your serious of
patch(https://github.com/KevinOConnor/seabios/tree/tcg-testing ).
  >Also I have tested this patch, which is
working.
 [...]
 
 Kevin, I think this should be good to add after 3/6 ?
 
 Thanks - I applied the first three tpm patches along with this patch.
 
 -Kevin
Thanks :))


Quan