On Thu, Nov 19, 2015 at 02:59:43PM +0100, Jenkins Build Host wrote:
See http://jenkins.xeni.kraxel.org:8080/job/seabios/198/changes
Changes:
[...]
[kevin] acpi: Don't build SSDT files on every build; store them in git
[...]
Total size: 130700 Fixed: 58336 Free: 372 (used 99.7% of 128KiB rom) Creating out/bios.bin
- make EXTRAVERSION=-16.b198.gdc8eb67-git-snapshot-by-kraxel.org out/bios.bin
make: `out/bios.bin' is up to date.
- cp out/bios.bin rpm.bin/bios-qemu.bin
- cp 'out/src/fw/*dsdt*.aml' rpm.bin/
cp: cannot stat 'out/src/fw/*dsdt*.aml': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.PsDRHn (%build)
Looks like the rpm build has a dependency on the acpi-dsdt.aml and q35-acpi-dsdt.aml files.
I'd prefer not to require iasl for every seabios build. We could create a new makefile target (eg, make aml) and then update the rpm to call both "make" and "make aml".
Thoughts? -Kevin
On Thu, Nov 19, 2015 at 09:42:40AM -0500, Kevin O'Connor wrote:
On Thu, Nov 19, 2015 at 02:59:43PM +0100, Jenkins Build Host wrote:
See http://jenkins.xeni.kraxel.org:8080/job/seabios/198/changes
Changes:
[...]
[kevin] acpi: Don't build SSDT files on every build; store them in git
[...]
Total size: 130700 Fixed: 58336 Free: 372 (used 99.7% of 128KiB rom) Creating out/bios.bin
- make EXTRAVERSION=-16.b198.gdc8eb67-git-snapshot-by-kraxel.org out/bios.bin
make: `out/bios.bin' is up to date.
- cp out/bios.bin rpm.bin/bios-qemu.bin
- cp 'out/src/fw/*dsdt*.aml' rpm.bin/
cp: cannot stat 'out/src/fw/*dsdt*.aml': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.PsDRHn (%build)
Looks like the rpm build has a dependency on the acpi-dsdt.aml and q35-acpi-dsdt.aml files.
I'd prefer not to require iasl for every seabios build. We could create a new makefile target (eg, make aml) and then update the rpm to call both "make" and "make aml".
It looks like only q35-acpi-dsdt.aml is needed. And, SeaBIOS never uses that file. So, another possibility would be to move that blob into qemu.
-Kevin
Hi,
It looks like only q35-acpi-dsdt.aml is needed. And, SeaBIOS never uses that file.
I think I just change the spec file to not include the aml files any more.
So, another possibility would be to move that blob into qemu.
That happened already. The file is only there to serve old qemu versions. It is basically the CONFIG_ACPI_DSDT=y equivalent for q35.
cheers, Gerd
On Thu, Nov 19, 2015 at 05:21:43PM +0100, Gerd Hoffmann wrote:
Hi,
It looks like only q35-acpi-dsdt.aml is needed. And, SeaBIOS never uses that file.
I think I just change the spec file to not include the aml files any more.
The QEMU code hw/i386/pc_q35.c has pc_acpi_init("q35-acpi-dsdt.aml"). So, I guess it still needs to get the file from somewhere. But, if that can be changed (or I missed something) then not generating the file does sound best.
-Kevin
On Do, 2015-11-19 at 11:27 -0500, Kevin O'Connor wrote:
On Thu, Nov 19, 2015 at 05:21:43PM +0100, Gerd Hoffmann wrote:
Hi,
It looks like only q35-acpi-dsdt.aml is needed. And, SeaBIOS never uses that file.
I think I just change the spec file to not include the aml files any more.
The QEMU code hw/i386/pc_q35.c has pc_acpi_init("q35-acpi-dsdt.aml").
Oh, I'll double-check ...
cheers, Gerd