Signed-off-by: Piotr Król piotr.krol@3mdeb.com --- docs/Debugging.md | 4 ++-- docs/Execution_and_code_flow.md | 10 +++++----- docs/Runtime_config.md | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/docs/Debugging.md b/docs/Debugging.md index 7ab5d02d8cad..13cee4dce592 100644 --- a/docs/Debugging.md +++ b/docs/Debugging.md @@ -60,7 +60,7 @@ mkfifo qemudebugpipe qemu -chardev pipe,path=qemudebugpipe,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios ... ```
-and then in another session: +And then in another session:
`/path/to/seabios/scripts/readserial.py -nf qemudebugpipe`
@@ -77,7 +77,7 @@ Debugging with gdb on QEMU ==========================
One can use gdb with QEMU to debug system images. To do this, add '-s --S' to the qemu command line. For example: +-S' to the QEMU command line. For example:
`qemu -bios out/bios.bin -fda myfdimage.img -s -S`
diff --git a/docs/Execution_and_code_flow.md b/docs/Execution_and_code_flow.md index a54776eef140..4a7ba8d9e4ad 100644 --- a/docs/Execution_and_code_flow.md +++ b/docs/Execution_and_code_flow.md @@ -30,7 +30,7 @@ called in 32bit mode. This then calls post.c:handle_post(). On CSM, the build arranges for romlayout.S:entry_csm() to be called (in 16bit mode). This then calls csm.c:handle_csm() in 32bit mode. Unlike on the emulators and coreboot, the SeaBIOS CSM POST phase is -orchastrated with UEFI and there are several calls back and forth +orchestrated with UEFI and there are several calls back and forth between SeaBIOS and UEFI via handle_csm() throughout the POST process.
@@ -58,7 +58,7 @@ transition to 32bit mode and call boot.c:handle_19() or boot.c:handle_18().
The boot phase is technically also part of the "runtime" phase of -SeaBIOS. It is typically invoked immiediately after the POST phase, +SeaBIOS. It is typically invoked immediately after the POST phase, but it can also be invoked by an operating system or be invoked multiple times in an attempt to find a valid boot media. Although the boot phase C code runs in 32bit mode it does not have write access to @@ -120,7 +120,7 @@ atomic memory accesses and complex locking is not required.
The goal of these threads is to reduce overall boot time by parallelizing hardware delays. (For example, by allowing the wait for -an ATA harddrive to spinup and respond to commands to occur in +an ATA hard drive to spin-up and respond to commands to occur in parallel with the wait for a PS/2 keyboard to respond to a setup command.) These hardware setup threads are only available during the "setup" sub-phase of the [POST phase](#POST_phase). @@ -144,7 +144,7 @@ interrupts disabled. The first reason is that external software may override the default SeaBIOS handlers that are called on a hardware interrupt event. Indeed, it is common for DOS based applications to do this. These legacy third party interrupt handlers may have -undocumented expections (such as stack location and stack size) and +undocumented expectations (such as stack location and stack size) and may attempt to call back into the various SeaBIOS software services. Greater compatibility and more reproducible results can be achieved by only permitting hardware interrupts at specific points (via yield() @@ -171,7 +171,7 @@ memory"](Memory Model). It ensures SeaBIOS uses a minimal amount of a callers stack (typically no more than 16 bytes) for these legacy calls. (More recently defined BIOS interfaces such as those that support 16bit protected and 32bit protected mode calls standardize a -minimum stack size with adequete space, and SeaBIOS generally will not +minimum stack size with adequate space, and SeaBIOS generally will not use its extra stack in these cases.)
The code to implement this stack "hopping" is in romlayout.S and in diff --git a/docs/Runtime_config.md b/docs/Runtime_config.md index 517129621e15..a2617481a6be 100644 --- a/docs/Runtime_config.md +++ b/docs/Runtime_config.md @@ -157,7 +157,7 @@ into bootorder. For example, the file: /pci@i0cf8/*@f/drive@1/disk@0 ```
-will instruct SeaBIOS to attempt to boot from the given USB drive +Will instruct SeaBIOS to attempt to boot from the given USB drive first and then attempt the given ATA harddrive second.
SeaBIOS also supports a special "HALT" directive. If a line that
On Sun, Oct 16, 2016 at 10:31:46PM +0200, Piotr Król wrote:
Signed-off-by: Piotr Król piotr.krol@3mdeb.com
Thanks. Except for the last part, I committed your patch.
[...]
--- a/docs/Runtime_config.md +++ b/docs/Runtime_config.md @@ -157,7 +157,7 @@ into bootorder. For example, the file: /pci@i0cf8/*@f/drive@1/disk@0
-will instruct SeaBIOS to attempt to boot from the given USB drive +Will instruct SeaBIOS to attempt to boot from the given USB drive first and then attempt the given ATA harddrive second. SeaBIOS also supports a special "HALT" directive. If a line that
The text here is is a continuation of the sentence above it and is not a start of a new sentence.
-Kevin
On Tue, Oct 18, 2016 at 07:33:18PM -0400, Kevin O'Connor wrote:
On Sun, Oct 16, 2016 at 10:31:46PM +0200, Piotr Król wrote:
Signed-off-by: Piotr Król piotr.krol@3mdeb.com
Thanks. Except for the last part, I committed your patch.
Thanks Kevin,
[...]
--- a/docs/Runtime_config.md +++ b/docs/Runtime_config.md @@ -157,7 +157,7 @@ into bootorder. For example, the file: /pci@i0cf8/*@f/drive@1/disk@0
-will instruct SeaBIOS to attempt to boot from the given USB drive +Will instruct SeaBIOS to attempt to boot from the given USB drive first and then attempt the given ATA harddrive second. SeaBIOS also supports a special "HALT" directive. If a line that
The text here is is a continuation of the sentence above it and is not a start of a new sentence.
So this is inconsistent across documentation in most places there is big letter after code section, this was the only place where small letter was used.
ie. big letter after code section:
https://review.coreboot.org/cgit/seabios.git/tree/docs/Runtime_config.md#n15... https://review.coreboot.org/cgit/seabios.git/tree/docs/Runtime_config.md#n49
I'm not sure how those are different then:
https://review.coreboot.org/cgit/seabios.git/tree/docs/Runtime_config.md#n16...
This is just minor nit. I you don't feel this fix is needed, then ok.
On Wed, Oct 19, 2016 at 01:35:04PM +0200, Piotr Król wrote:
On Tue, Oct 18, 2016 at 07:33:18PM -0400, Kevin O'Connor wrote:
On Sun, Oct 16, 2016 at 10:31:46PM +0200, Piotr Król wrote:
-will instruct SeaBIOS to attempt to boot from the given USB drive +Will instruct SeaBIOS to attempt to boot from the given USB drive first and then attempt the given ATA harddrive second.
SeaBIOS also supports a special "HALT" directive. If a line that
The text here is is a continuation of the sentence above it and is not a start of a new sentence.
So this is inconsistent across documentation in most places there is big letter after code section, this was the only place where small letter was used.
ie. big letter after code section:
https://review.coreboot.org/cgit/seabios.git/tree/docs/Runtime_config.md#n15... https://review.coreboot.org/cgit/seabios.git/tree/docs/Runtime_config.md#n49
I'm not sure how those are different then:
It didn't seem right to capitalize it because "will instruct SeaBIOS to attempt to boot from the given USB drive ..." is not a valid sentence - it lacks a subject. It could be reworded into a sentence and then capitalized.
-Kevin
On Wed, Oct 19, 2016 at 07:57:59AM -0400, Kevin O'Connor wrote:
On Wed, Oct 19, 2016 at 01:35:04PM +0200, Piotr Król wrote:
On Tue, Oct 18, 2016 at 07:33:18PM -0400, Kevin O'Connor wrote:
On Sun, Oct 16, 2016 at 10:31:46PM +0200, Piotr Król wrote:
-will instruct SeaBIOS to attempt to boot from the given USB drive +Will instruct SeaBIOS to attempt to boot from the given USB drive first and then attempt the given ATA harddrive second.
SeaBIOS also supports a special "HALT" directive. If a line that
The text here is is a continuation of the sentence above it and is not a start of a new sentence.
So this is inconsistent across documentation in most places there is big letter after code section, this was the only place where small letter was used.
ie. big letter after code section:
https://review.coreboot.org/cgit/seabios.git/tree/docs/Runtime_config.md#n15... https://review.coreboot.org/cgit/seabios.git/tree/docs/Runtime_config.md#n49
I'm not sure how those are different then:
It didn't seem right to capitalize it because "will instruct SeaBIOS to attempt to boot from the given USB drive ..." is not a valid sentence - it lacks a subject. It could be reworded into a sentence and then capitalized.
Ok agree - I'm not native English, so this was not clear to me.