Re: [SeaBIOS] [PATCH] Introduce config option to select which IO port to send debug output on

[Kevin O'Connor]

On Mon, Jan 30, 2012 at 05:23:19PM +0000, [e-mail] wrote:
> --- a/src/output.c
> +++ b/src/output.c
> @@ -75,9 +75,9 @@ putc_debug(struct putcinfo *action, char c)
>  {
>      if (! CONFIG_DEBUG_LEVEL)
>          return;
> if (! CONFIG_COREBOOT)
> if (! CONFIG_DEBUG_IO)

Inverted test?

-Kevin
>      // Send character to debug port.
>    outb(c, PORT_BIOS_DEBUG);
>    outb(c, CONFIG_DEBUG_IO_PORT);
> if (c == '\n')
>        debug_serial('\r');
>    debug_serial(c);

[PATCH] Introduce config option to select which IO port to send debug output on

[Julian Pidancet]

On Wed, Feb 1, 2012 at 4:00 AM, Kevin O'Connor  wrote:
> On Mon, Jan 30, 2012 at 05:23:19PM +0000, [e-mail] wrote:
> > --- a/src/output.c
> > +++ b/src/output.c
> > @@ -75,9 +75,9 @@ putc_debug(struct putcinfo *action, char c)
> >  {
> >      if (! CONFIG_DEBUG_LEVEL)
> >          return;
> > if (! CONFIG_COREBOOT)
> > if (! CONFIG_DEBUG_IO)
>
> Inverted test?

Oops, apologies. V2 Sent.