[RFC PATCH] VGA BIOS init fails if first mode used is graphical

[David Woodhouse]

When booting with OVMF+CSM, the first video mode that we ask for is mode
0x143. This doesn't seem to work; the qemu display window doesn't change
size, and remains blank.

If the first thing we ask for is a *text* mode, then things work fine.
This is arguably a bug, but I'm not about to go chasing it. Most video
BIOSes will enter mode 3 for themselves as part of the POST anyway,
won't they? And that's sufficient to work around the problem for me...

Signed-off-by: David Woodhouse

diff --git a/vgasrc/vgabios.c b/vgasrc/vgabios.c
index 3e26e32..82aa5fc 100644
--- a/vgasrc/vgabios.c
+++ b/vgasrc/vgabios.c
@@ -1320,4 +1320,6 @@ vga_post(struct bregs *regs)
     u8 sum = -checksum_far(get_global_seg(), 0,
                            GET_GLOBAL(_rom_header_size) * 512);
     SET_VGA(_rom_header_checksum, sum);
+
+    vga_set_mode(3, 0);
 }

[Fred .]

It would be nice with native resolution video mode.
Such as 1920x1200.

On Fri, Feb 8, 2013 at 4:06 PM, David Woodhouse  wrote:
> When booting with OVMF+CSM, the first video mode that we ask for is mode
> 0x143. This doesn't seem to work; the qemu display window doesn't change
> size, and remains blank.
>
> If the first thing we ask for is a *text* mode, then things work fine.
> This is arguably a bug, but I'm not about to go chasing it. Most video
> BIOSes will enter mode 3 for themselves as part of the POST anyway,
> won't they? And that's sufficient to work around the problem for me...
>
> Signed-off-by: David Woodhouse
>
> diff --git a/vgasrc/vgabios.c b/vgasrc/vgabios.c
> index 3e26e32..82aa5fc 100644
> --- a/vgasrc/vgabios.c
> +++ b/vgasrc/vgabios.c
> @@ -1320,4 +1320,6 @@ vga_post(struct bregs *regs)
>      u8 sum = -checksum_far(get_global_seg(), 0,
>                             GET_GLOBAL(_rom_header_size) * 512);
>      SET_VGA(_rom_header_checksum, sum);
> vga_set_mode(3, 0);
>
> }
>
> SeaBIOS mailing list
> [e-mail]
> http://www.seabios.org/mailman/listinfo/seabios

[RFC PATCH] VGA BIOS init fails if first mode used is graphical

[David Woodhouse]

On Fri, 2013-02-08 at 15:06 +0000, David Woodhouse wrote:
> When booting with OVMF+CSM, the first video mode that we ask for is mode
> 0x143. This doesn't seem to work; the qemu display window doesn't change
> size, and remains blank.
>
> If the first thing we ask for is a *text* mode, then things work fine.
> This is arguably a bug, but I'm not about to go chasing it.

I should know never to say things like that; if I'm offended by
something it's almost always a lie to say that I won't actually go and
hunt it down. This patch is more minimal and highlights the actual
problem. Not sure what *else* is missing...

Signed-off-by: David Woodhouse

diff --git a/vgasrc/bochsvga.c b/vgasrc/bochsvga.c
index bb5a64d..b0ba1ec 100644
--- a/vgasrc/bochsvga.c
+++ b/vgasrc/bochsvga.c
@@ -319,6 +319,7 @@ bochsvga_set_mode(struct vgamode_s *vmode_g, int flags)
         stdvga_sequ_mask(0x04, 0x00, 0x08);
         stdvga_grdc_mask(0x05, 0x20, 0x40);
     }
+    stdvga_attrindex_write(0x20);

return 0;
 }

[RFC PATCH] VGA BIOS init fails if first mode used is graphical

[Kevin O'Connor]

On Fri, Feb 08, 2013 at 03:19:19PM +0000, David Woodhouse wrote:
> On Fri, 2013-02-08 at 15:06 +0000, David Woodhouse wrote:
> > When booting with OVMF+CSM, the first video mode that we ask for is mode
> > 0x143. This doesn't seem to work; the qemu display window doesn't change
> > size, and remains blank.
> >
> > If the first thing we ask for is a *text* mode, then things work fine.
> > This is arguably a bug, but I'm not about to go chasing it.
>
> I should know never to say things like that; if I'm offended by
> something it's almost always a lie to say that I won't actually go and
> hunt it down. This patch is more minimal and highlights the actual
> problem. Not sure what *else* is missing...

Thanks.  The patch looks fine to me.  However, "-vga std" has stopped
working for me (both before and after your patch) and I still need to
track that down.

-Kevin

[Fred .]

Can SeaBIOS init to a high resolution video mode such as 1920x1200?

On Wed, Feb 13, 2013 at 3:24 AM, Kevin O'Connor  wrote:
> On Fri, Feb 08, 2013 at 03:19:19PM +0000, David Woodhouse wrote:
> > On Fri, 2013-02-08 at 15:06 +0000, David Woodhouse wrote:
> > > When booting with OVMF+CSM, the first video mode that we ask for is
>
> mode
> > > 0x143. This doesn't seem to work; the qemu display window doesn't
>
> change
> > > size, and remains blank.
> > >
> > > If the first thing we ask for is a *text* mode, then things work fine.
> > > This is arguably a bug, but I'm not about to go chasing it.
> >
> > I should know never to say things like that; if I'm offended by
> > something it's almost always a lie to say that I won't actually go and
> > hunt it down. This patch is more minimal and highlights the actual
> > problem. Not sure what *else* is missing...
>
> Thanks.  The patch looks fine to me.  However, "-vga std" has stopped
> working for me (both before and after your patch) and I still need to
> track that down.
>
> -Kevin
>
> SeaBIOS mailing list
> [e-mail]
> http://www.seabios.org/mailman/listinfo/seabios