Re: [SeaBIOS] (no subject)

[Gerd Hoffmann]

On 09/13/12 22:12, Jason Baron wrote:
> [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail]
> Message-Id: 
> In-Reply-To: 
> References: 
> Subject: [PATCH 9/9] seabios: q35: add basic hotplug support
>
> Add support for acpi hotplug to q35. Copied from the piix acpi table.

Do we really wanna bring that in?

q35 has pcie slots which are hot-pluggable.

qemu also has a pci-pci bridge which supports hotplug for all devices
behind it.

It's not like we can't hotplug pci devices at all like it used to be
back in the days when acpi hotplug was added to piix4.

cheers,
  Gerd

(no subject)

[Jason Baron]

On Fri, Sep 14, 2012 at 10:08:19AM +0200, Gerd Hoffmann wrote:
> On 09/13/12 22:12, Jason Baron wrote:
> > [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail]
> > Message-Id: 
> > In-Reply-To: 
> > References: 
> > Subject: [PATCH 9/9] seabios: q35: add basic hotplug support
> >
> > Add support for acpi hotplug to q35. Copied from the piix acpi table.
>
> Do we really wanna bring that in?
>
> q35 has pcie slots which are hot-pluggable.
>
> qemu also has a pci-pci bridge which supports hotplug for all devices
> behind it.
>
> It's not like we can't hotplug pci devices at all like it used to be
> back in the days when acpi hotplug was added to piix4.
>
> cheers,
>   Gerd

So I was trying to get q35 to be on feature parity with piix, with the
least amount of work :) I'm not sure how hard pcie hotplug would be to
implement, Michael, do you have any idea?

Thanks,

-Jason