On Wed, Jul 14, 2010 at 02:03:02AM +0200, Peter Stuge wrote:
Isaku Yamahata wrote:
I choice to abstract it at register offset level.
If you want more high level abstract, I'll
respin the patch set.
If abstracted on a higher level then it will quite likely duplicate a
lot of infrastructure which is already in coreboot.
Yes - there is overlap between SeaBIOS' hardware setup and coreboot,
and these patches increase that overlap.
It would be possible to extend the hardware setup in coreboot, and
then champion a coreboot+seabios solution for qemu. To do so would
require supporting all the qemu specific stuff in coreboot - it's the
stuff in: src/acpi-dsdt.dsl, src/acpi.c, src/dev-i440fx.c,
src/mptable.c, src/mtrr.c, src/paravirt.c, src/pciinit.c, src/shadow.c
src/smbios.c, src/smm.c, src/smp.c. Coreboot and this code do many
similar things, but coreboot isn't currently a replacement. For
example, coreboot would need to handle the fw_cfg and cmos reading to
get config settings. Qemu isn't just one machine, it's a whole class
of machines. Coreboot would need to be able to support them
If there's a desire to do this, I wont object. However, someone will
need to step forward and start enhancing coreboot. In the meantime, I
wont hold up on patches to SeaBIOS.