Re: [SeaBIOS] [PATCH 2/4] KVM: Rework VCPU state writeback API

[Kevin O'Connor]

On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote:
> The regression seems to be caused by seabios commit d7e998f. Kevin, the
> failure can be seen on the attached screenshot, which happens on the
> first reboot of WinXP 32 installation (after copying files etc).

Sorry - I also noticed a bug in that commit recently.  I pushed the
fix I had in my local tree.

-Kevin

[PATCH 2/4] KVM: Rework VCPU state writeback API

[Marcelo Tosatti]

On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote:
> On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote:
> > The regression seems to be caused by seabios commit d7e998f. Kevin, the
> > failure can be seen on the attached screenshot, which happens on the
> > first reboot of WinXP 32 installation (after copying files etc).
>
> Sorry - I also noticed a bug in that commit recently.  I pushed the
> fix I had in my local tree.

Thanks, it does fix the issue here. Anthony can you please update
seabios?

TIA

[PATCH 2/4] KVM: Rework VCPU state writeback API

[Kevin O'Connor]

On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote:
> On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote:
> > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote:
> > > The regression seems to be caused by seabios commit d7e998f. Kevin, the
> > > failure can be seen on the attached screenshot, which happens on the
> > > first reboot of WinXP 32 installation (after copying files etc).
> >
> > Sorry - I also noticed a bug in that commit recently.  I pushed the
> > fix I had in my local tree.
>
> Thanks, it does fix the issue here. Anthony can you please update
> seabios?

Neither commit d7e998f nor the fix 8f469b96 are on the SeaBIOS stable
branch.  Is qemu ready to pull in bigger changes now?

-Kevin

[PATCH 2/4] KVM: Rework VCPU state writeback API

[Marcelo Tosatti]

On Fri, Mar 05, 2010 at 09:37:26PM -0500, Kevin O'Connor wrote:
> On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote:
> > On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote:
> > > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote:
> > > > The regression seems to be caused by seabios commit d7e998f. Kevin, the
> > > > failure can be seen on the attached screenshot, which happens on the
> > > > first reboot of WinXP 32 installation (after copying files etc).
> > >
> > > Sorry - I also noticed a bug in that commit recently.  I pushed the
> > > fix I had in my local tree.
> >
> > Thanks, it does fix the issue here. Anthony can you please update
> > seabios?
>
> Neither commit d7e998f nor the fix 8f469b96 are on the SeaBIOS stable
> branch.  Is qemu ready to pull in bigger changes now?

Anthony pulls in seabios master into qemu.git master periodically.

[PATCH 2/4] KVM: Rework VCPU state writeback API

[Anthony Liguori]

On 03/08/2010 02:33 PM, Marcelo Tosatti wrote:
> On Fri, Mar 05, 2010 at 09:37:26PM -0500, Kevin O'Connor wrote:
> > On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote:
> > > On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote:
> > > > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote:
> > > > > The regression seems to be caused by seabios commit d7e998f. Kevin, the
> > > > > failure can be seen on the attached screenshot, which happens on the
> > > > > first reboot of WinXP 32 installation (after copying files etc).
> > > >
> > > > Sorry - I also noticed a bug in that commit recently.  I pushed the
> > > > fix I had in my local tree.
> > >
> > > Thanks, it does fix the issue here. Anthony can you please update
> > > seabios?
> >
> > Neither commit d7e998f nor the fix 8f469b96 are on the SeaBIOS stable
> > branch.  Is qemu ready to pull in bigger changes now?
>
> Anthony pulls in seabios master into qemu.git master periodically.

We should be up to date now FWIW.

Regards,

Anthony Liguori