seabios regression in 1.11.1

[Olaf Hering]

Recently both qemu.git and xen.git updated their copy of seabios.
Qemu is broken quite some time already, now also xen fails after
updating from rel-1.10.2 to rel-1.11.1.

This happens in SLE11 which uses gcc-4.3:

[   86s]   Compile checking out/src/hw/blockcmd.o
[   86s] src/hw/blockcmd.c: In function 'scsi_rep_luns_scan':
[   86s] src/hw/blockcmd.c:229: error: unknown field 'cdbcmd' specified in initializer
[   86s] src/hw/blockcmd.c:229: warning: missing braces around initializer
[   86s] src/hw/blockcmd.c:229: warning: (near initialization for 'op.<anonymous>')
[   86s] src/hw/blockcmd.c:229: warning: initialization makes integer from pointer without a cast
[   86s] make[7]: *** [out/src/hw/blockcmd.o] Error 1

How can this be fixed?

Olaf

[Kevin O'Connor]

On Thu, Mar 29, 2018 at 05:00:03PM +0200, Olaf Hering wrote:
> Recently both qemu.git and xen.git updated their copy of seabios.
> Qemu is broken quite some time already, now also xen fails after
> updating from rel-1.10.2 to rel-1.11.1.
>
> This happens in SLE11 which uses gcc-4.3:
>
> [   86s]   Compile checking out/src/hw/blockcmd.o
> [   86s] src/hw/blockcmd.c: In function 'scsi_rep_luns_scan':
> [   86s] src/hw/blockcmd.c:229: error: unknown field 'cdbcmd' specified in initializer
> [   86s] src/hw/blockcmd.c:229: warning: missing braces around initializer
> [   86s] src/hw/blockcmd.c:229: warning: (near initialization for 'op.<anonymous>')
> [   86s] src/hw/blockcmd.c:229: warning: initialization makes integer from pointer without a cast
> [   86s] make[7]: *** [out/src/hw/blockcmd.o] Error 1
>
> How can this be fixed?

See: https://mail.coreboot.org/pipermail/seabios/2017-November/011932.html

Gcc v4.6 was released seven years ago, so I don't think it's
unreasonable to require it.

-Kevin