Re: [SeaBIOS] [PATCH 5/8] Setup output based on .config

On Tue, Oct 02, 2012 at 05:28:04PM +0200, Christian Gmeiner wrote:
2012/10/2 Kevin O'Connor <kevin@koconnor.net>:
On Mon, Oct 01, 2012 at 02:02:46PM +0200, Christian Gmeiner wrote:
The geode hardware can be configured to use different outputs. This patch adds support this feature based on the current .config [...] + if (CONFIG_VGA_OUTPUT_PANEL || CONFIG_VGA_OUTPUT_CRT_PANEL) {
This patch seems to use kconfig defines that are only defined in patch 6. When sending a multi-series patch, it's important that each individual commit compiles and functions properly.
Otherwise, the patch series seems fine to me.
Shall I resend a v2 which corrects this?
Nah. If there's no other comments, I can reorder them and add a "geodevga:" prefix when I commit. -Kevin
participants (1)
-
Kevin O'Connor