Re: [SeaBIOS] [Qemu-devel] [PATCH v7 1/4] hw/pci: introduce pcie-pci-bridge device

[Marcel Apfelbaum]

On 20/09/2017 12:52, Aleksandr Bezzubikov wrote:
> ср, 20 сент. 2017 г. в 10:13, Marcel Apfelbaum <[e-mail] 
> >:
> On 19/09/2017 23:34, Eduardo Habkost wrote:
>  > On Fri, Aug 18, 2017 at 02:36:47AM +0300, Aleksandr Bezzubikov wrote:
>  >> Introduce a new PCIExpress-to-PCI Bridge device,
>  >> which is a hot-pluggable PCI Express device and
>  >> supports devices hot-plug with SHPC.
>  >>
>  >> This device is intended to replace the DMI-to-PCI Bridge.
>  >>
>  >> Signed-off-by: Aleksandr Bezzubikov <[e-mail]
> <mailto:[e-mail]>>
>  >> Reviewed-by: Marcel Apfelbaum <[e-mail]
> <mailto:[e-mail]>>
>  >
>  > It's possible to crash QEMU by instantiating this device, with;
>  >
>  >    $ qemu-system-ppc64 -machine prep -device pcie-pci-bridge
>  >    qemu-system-ppc64: qemu/memory.c:1533: memory_region_finalize:
> Assertion `!mr->container' failed.
>  >    Aborted
>
> Hi Edurado,
>
>  >
>  > I didn't investigate the root cause.
>  >
>
> Thanks for reporting it!
> Aleksandr, can you have a look? Maybe we should not compile
> the device for ppc arch. (x86 and arm is enough)
>
>
> I will see what can we do. Is x86 and arm really enough?

Well, I am being selfish, and it works for me lately :).

Seriously speaking, the new generic PCI Express
Port was restricted to x86 and arm for reasons I don't remember.
Since your work has the same scope, the restriction makes sense.

Please grep for CONFIG_PCIE_PORT to convince yourself
and to help coding it.

Thanks,
Marcel
> Appreciated,
> Marcel