Re: [SeaBIOS] Alt SeaBIOS SSDT cpu hotplug

[Liu, Jinsong]

Zheng, Shaohui wrote:
> In our experiences, windows 2008 datacenter is the only version to
> support CPU hotplug, and we did not find any official announce for
> other windows, so we tested windows 2008 data center only.
>
> Thanks for Kevin pointing out it, we will try windows7 hotplug
> feature.
>
> Thanks & Regards,
> Shaohui
>
> -----Original Message-----
> From: Kevin O'Connor [mailto:[e-mail]]
> Sent: Tuesday, August 03, 2010 1:27 AM
> To: Avi Kivity
> Cc: Alexander Graf; Liu, Jinsong; [e-mail];
> [e-mail]; Jiang, Yunhong; Li, Xin; Zheng, Shaohui; Zhang,
> Jianwu; You, Yongkang  
> Subject: Re: Alt SeaBIOS SSDT cpu hotplug
>
> On Mon, Aug 02, 2010 at 07:13:34PM +0300, Avi Kivity wrote:
> > On 08/02/2010 06:55 PM, Kevin O'Connor wrote:
> > > On Mon, Aug 02, 2010 at 10:12:31AM +0200, Alexander Graf wrote:
> > > > On 02.08.2010, at 07:49, Kevin O'Connor wrote:
> > > > > On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote:
> > > > > It seems the Windows acpi interpreter is significantly different
> > > > > from the Linux one.  The only guess I have is that Windows
> > > > > doesn't like one of the ASL constructs even though they all look
> > > > > valid.  I'd try to debug this by commenting out parts of the ASL
> > > > > until I narrowed down the parts causing the problem. 
> > > > > Unfortunately, I don't have Windows 2008 to do this directly.
> > > > >
> > > > > Any other ideas?
> > > >
> > > > Just grab yourself a free copy of the Hyper-V server 2008:
> > > >
> > > > http://arstechnica.com/microsoft/news/2009/08/microsoft-hyper-v-server-2008-...
> > >
> > > I downloaded and installed it, but I can't reproduce the crash.  It
> > > seems like a really stripped down version of Windows, so I can't
> > > tell if it actually worked or not either.
> >
> > I thought only the Datacenter edition supported cpu hotplug.
>
> I just tried an old Win 7 Ultimate beta (build 7100) I had on my HD.
> It looks like it supports cpu hotplug.  However, I don't see any
> failures - it seems to work fine.  (After running "cpu_set 1 online",
> the event pops up in the system event log as a UserPnP event, and the
> CPU appears in the system devices list.)
>
> -Kevin

Kevin,

I just test your new patch with Windows 2008 DataCenter at my platform, it works OK! We can hot-add new cpus and they appear at Device Manager.
(BTW, yesterday I test your new patch with linux 2.6.32 hvm, it works fine, we can add-remove-add-remove... cpus)
Sorry for make you spend more time. It's our fault.

Thanks,
Jinsong