[PATCH] Change pvscsi to use BAR 1.

[Don Koch]

From: Don Koch

Change pvscsi to use BAR 1 (mmio) instead of BAR 0 (ioport).

Signed-off-by: Don Koch 
---
I found that when using bar 0, the VM wouldn't boot where
using bar 1 worked. Cced Evgeny for review.

src/hw/pvscsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/hw/pvscsi.c b/src/hw/pvscsi.c
index 6911230..1204a4c 100644
--- a/src/hw/pvscsi.c
+++ b/src/hw/pvscsi.c
@@ -326,7 +326,7 @@ init_pvscsi(struct pci_device *pci)
     struct pvscsi_ring_dsc_s *ring_dsc = NULL;
     int i;
     u16 bdf = pci->bdf;
-    u32 iobase = pci_config_readl(pci->bdf, PCI_BASE_ADDRESS_0)
+    u32 iobase = pci_config_readl(pci->bdf, PCI_BASE_ADDRESS_1)
         & PCI_BASE_ADDRESS_MEM_MASK;

pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER);

[Kevin O'Connor]

On Wed, Jan 08, 2014 at 02:39:19PM -0500, Don Koch wrote:
> From: Don Koch
>
> Change pvscsi to use BAR 1 (mmio) instead of BAR 0 (ioport).
> Signed-off-by: Don Koch
>
> I found that when using bar 0, the VM wouldn't boot where
> using bar 1 worked. Cced Evgeny for review.

What command do you use to test?  I can't get pvscsi to work with or
without your patch.  I used this command:

../qemu/qemu-1.7.0/x86_64-softmmu/qemu-system-x86_64 -k en-us -snapshot -L test -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios -m 512 -device pvscsi,id=pvscsi0 -device scsi-disk,bus=pvscsi0.0,drive=drive0 -drive id=drive0,if=none,file=dos-drivec-new -boot menu=on

-Kevin

[Don Koch]

On 01/08/2014 06:04 PM, Kevin O'Connor wrote:
> On Wed, Jan 08, 2014 at 02:39:19PM -0500, Don Koch wrote:
> > From: Don Koch
> >
> > Change pvscsi to use BAR 1 (mmio) instead of BAR 0 (ioport).
> > Signed-off-by: Don Koch
> >
> > I found that when using bar 0, the VM wouldn't boot where
> > using bar 1 worked. Cced Evgeny for review.
>
> What command do you use to test?  I can't get pvscsi to work with or
> without your patch.  I used this command:
>
> ../qemu/qemu-1.7.0/x86_64-softmmu/qemu-system-x86_64 -k en-us -snapshot -L test -chardev stdio,id=seabios -device isa-debugcon,iobase=0x402,chardev=seabios -m 512 -device pvscsi,id=pvscsi0 -device scsi-disk,bus=pvscsi0.0,drive=drive0 -drive id=drive0,if=none,file=dos-drivec-new -boot menu=on

I've been booting with xen. I tried something similar to your command
and it failed. I will look into it.
> -Kevin

-d