Seabios build failure with gcc 6.2.0 in Debian Sid

[Dario Faggioli]

Hi,

I'm reporting a build issue that I'm seeing when building Xen's
userspace tools, when the build process clones and build Seabios, on
Debian Sid, with gcc '6.2.0 20161019 (Debian 6.2.0-9)'.

The error looks like this (http://pastebin.com/99cubDZ3):

make -C seabios-dir all
make[6]: Entering directory '/home/SOURCES/xen/xen.git/tools/firmware/seabios-dir-remote'
  Compile checking out/src/stacks.o
src/stacks.c: Assembler messages:
src/stacks.c:567: Error: found `(', expected: `)'
src/stacks.c:567: Error: junk `(%ebp))' after expression
src/stacks.c:568: Warning: indirect call without `*'
Makefile:133: recipe for target 'out/src/stacks.o' failed
make[6]: *** [out/src/stacks.o] Error 1
make[6]: Leaving directory '/home/SOURCES/xen/xen.git/tools/firmware/seabios-dir-remote'
/home/SOURCES/xen/xen.git/tools/firmware/../../tools/Rules.mk:218: recipe for target 'subdir-all-seabios-dir' failed

Seabios folks may be aware of this already, as it looks very similar to
this:
https://www.mail-archive.com/[e-mail]/msg1463516.ht...

And even more to this:
https://lists.debian.org/debian-gcc/2016/10/msg00147.html

A colleague of mine (Cc-ed) said in chat that gcc 6.2.1 (don't know on
what distro) seems to build all fine.

Regards,
Dario

[Kevin O'Connor]

On Fri, Nov 04, 2016 at 07:06:07PM +0100, Dario Faggioli wrote:
> Hi,
>
> I'm reporting a build issue that I'm seeing when building Xen's
> userspace tools, when the build process clones and build Seabios, on
> Debian Sid, with gcc '6.2.0 20161019 (Debian 6.2.0-9)'.
>
> The error looks like this (http://pastebin.com/99cubDZ3):
>
> make -C seabios-dir all
> make[6]: Entering directory '/home/SOURCES/xen/xen.git/tools/firmware/seabios-dir-remote'
>   Compile checking out/src/stacks.o
> src/stacks.c: Assembler messages:
> src/stacks.c:567: Error: found `(', expected: `)'
> src/stacks.c:567: Error: junk `(%ebp))' after expression
> src/stacks.c:568: Warning: indirect call without `*'
> Makefile:133: recipe for target 'out/src/stacks.o' failed
> make[6]: *** [out/src/stacks.o] Error 1
> make[6]: Leaving directory '/home/SOURCES/xen/xen.git/tools/firmware/seabios-dir-remote'
> /home/SOURCES/xen/xen.git/tools/firmware/../../tools/Rules.mk:218: recipe for target 'subdir-all-seabios-dir' failed
>
> Seabios folks may be aware of this already, as it looks very similar to
> this:
> https://www.mail-archive.com/[e-mail]/msg1463516.ht...
>
> And even more to this:
> https://lists.debian.org/debian-gcc/2016/10/msg00147.html
>
> A colleague of mine (Cc-ed) said in chat that gcc 6.2.1 (don't know on
> what distro) seems to build all fine.

The SeaBIOS build was updated to work around this with commit
99e3316d59.  What version of SeaBIOS are you attempting to build?

-Kevin

[Xen-devel] Seabios build failure with gcc 6.2.0 in Debian Sid

[Dario Faggioli]

On Fri, 2016-11-04 at 14:36 -0400, Kevin O'Connor wrote:
> On Fri, Nov 04, 2016 at 07:06:07PM +0100, Dario Faggioli wrote:
> > And even more to this:
> > https://lists.debian.org/debian-gcc/2016/10/msg00147.html
> >
> > A colleague of mine (Cc-ed) said in chat that gcc 6.2.1 (don't know
> > on
> > what distro) seems to build all fine.
>
> The SeaBIOS build was updated to work around this with commit
> 99e3316d59.  What version of SeaBIOS are you attempting to build?

I'm building what Xen's build system tries to build by default which
appears to be e2fc41e24ee0ada aka rel-1.9.3.

Wei, maybe we need to update to another changeset/release?

Regards,
Dario

[Xen-devel] Seabios build failure with gcc 6.2.0 in Debian Sid

[Wei Liu]

On Sat, Nov 05, 2016 at 02:09:22PM +0100, Dario Faggioli wrote:
> On Fri, 2016-11-04 at 14:36 -0400, Kevin O'Connor wrote:
> > On Fri, Nov 04, 2016 at 07:06:07PM +0100, Dario Faggioli wrote:
> > > And even more to this:
> > > https://lists.debian.org/debian-gcc/2016/10/msg00147.html
> > >
> > > A colleague of mine (Cc-ed) said in chat that gcc 6.2.1 (don't know
> > > on
> > > what distro) seems to build all fine.
> >
> > The SeaBIOS build was updated to work around this with commit
> > 99e3316d59.  What version of SeaBIOS are you attempting to build?
>
> I'm building what Xen's build system tries to build by default which
> appears to be e2fc41e24ee0ada aka rel-1.9.3.
>
> Wei, maybe we need to update to another changeset/release?

I'm inclined to believe this is a gcc issue. This is discovered due to
Debian has -fpie when building.

After going through the list of changes between 1.9.3 and 1.10.0 I think
I would be fine with updating our in tree version to that.

Wei.
> Regards,
> Dario
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
>
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
> SeaBIOS mailing list
> [e-mail]
> https://www.coreboot.org/mailman/listinfo/seabios