Re: [SeaBIOS] [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

[Kevin O'Connor]

On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote:
> Signed-off-by: Vasilis Liaskovitis

The SeaBIOS change is okay with me, but the qemu/kvm change needs to
be accepted first.

[...]
>      Method (CPEJ, 2, NotSerialized) {
>          // _EJ0 method - eject callback
>        Store(ShiftLeft(1, Arg0), PRE)
>        Sleep(200)
>    }

Is the Sleep() still needed?

-Kevin

[PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

[Vasilis Liaskovitis]

On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote:
> On Fri, Jan 13, 2012 at 12:11:30PM +0100, Vasilis Liaskovitis wrote:
> > Signed-off-by: Vasilis Liaskovitis
>
> The SeaBIOS change is okay with me, but the qemu/kvm change needs to
> be accepted first.
>
> [...]
> >      Method (CPEJ, 2, NotSerialized) {
> >          // _EJ0 method - eject callback
> >        Store(ShiftLeft(1, Arg0), PRE)
> >        Sleep(200)
> >    }
>
> Is the Sleep() still needed?

I believe it's unneccesary. I 'll test without it and resend.
thanks,

- Vasilis

[PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback

[Vasilis Liaskovitis]

On Fri, Jan 13, 2012 at 07:27:01PM -0500, Kevin O'Connor wrote:
> [...]
> >      Method (CPEJ, 2, NotSerialized) {
> >          // _EJ0 method - eject callback
> >        Store(ShiftLeft(1, Arg0), PRE)
> >        Sleep(200)
> >    }

I have another question here: the PCI _EJO callback seems to return 0x0, but
the CPU _EJ0 doesn't return anything. THe ACPIspec4.0a draft section 6.3.3
mentions that _EJx methods have no return value. Is the above difference
intentional?

thanks,

- Vasilis