Patch 2, 4 and 5 looks good to me. Patch 6 causes artifacts on mode change, if the new mode is smaller than the previous.
Would it be possible to include a 32bit memset into seavgabios ? That way there is no need to call a BIOS routine to clear the memory.
Regards, Patrick
On Thu, 2018-05-31 at 08:33 +0200, Gerd Hoffmann wrote:
Add support for the new bochs-display device in qemu.
Gerd Hoffmann (6): pci,optionrom: enable non-vga display devices cbvga: factor out cbvga_setup_modes() qemu: add bochs-display support cbvga_setup_modes: use real mode number instead of 0x140 cbvga_list_modes: don't list current mode twice [workaround] cbvga_set_mode: disable clearmem
vgasrc/vgahw.h | 28 ++++++------ vgasrc/vgautil.h | 1 + src/fw/pciinit.c | 15 +++++-- src/optionroms.c | 29 ++++++++++++- vgasrc/cbvga.c | 127 +++++++++++++++++++++++++++++++++++++++++++------------ vgasrc/Kconfig | 17 ++++++++ 6 files changed, 173 insertions(+), 44 deletions(-)
On Thu, May 31, 2018 at 10:47:05AM +0200, Patrick Rudolph wrote:
Patch 2, 4 and 5 looks good to me. Patch 6 causes artifacts on mode change, if the new mode is smaller than the previous.
Indeed. But I had no better idea (thats why it is tagged as "workaround"). Suggestions are welcome.
Would it be possible to include a 32bit memset into seavgabios ? That way there is no need to call a BIOS routine to clear the memory.
We are running real mode, so the framebuffer is out of reach[1]. As far I know the bios routines switch to 32bit mode temporarely. seavgabios could try to do that directly instead. But I have my doubts that it will work better (havn't actually tried though).
cheers, Gerd
[1] except for the setup code which runs in big real mode so 32bit access works there.
-
Gerd Hoffmann -
Patrick Rudolph