Pending patch summary

[Kevin O'Connor]

Patches pending:

Eduard - Gabriel Munteanu: 20100828:
  iommu: introduce AMD IOMMU support, initialize it

* Likely for post v0.6.1 release

Isaku Yamahata: 20100722:
  acpi: allow qemu to load dsdt as external acpi table.

* Needs resolution on acpi patches

Isaku Yamahata: 20100819:
  seabios: acpi: add mcfg table.

* Needs resolution on acpi patches

Patches pending with author:

Isaku Yamahata: 20100726:
  seabios: pciinit: fix overflow when bar allocation.

* Isaku was looking at another approach

Sebastian Herbszt: 20100731:
  EDD fixes

* Initial patch looked like it may break backwards compatibility; I
    haven't seen a new patch.

Patches not applied:

Arseny Klimovsky: 20100621:
  Added ACPI SLIC table

* There was no explicit patch sent, and approach (eg, recompile
    seabios) doesn't look scalable.

Eduardo Habkost: 20100618:
  Allow acpi and smbios default strings to be set on config.h

* Should no longer be needed now that smbios strings can be passed
    in via fwcfg.

Christopher Gautier: 20100723:
  Impossible to distinguish between two '/' keys

* No explicit patch sent, and I didn't understand the description.

Gleb Natapov: 20100614:
  load hpet info for HPET ACPI table from qemu

* Gleb withdrew this patch due to a bug.  Concept is pending ACPI
    resolution.

Please let me know if I've missed any thing.
-Kevin

[Sebastian Herbszt]

Kevin O'Connor wrote:
> Sebastian Herbszt: 20100731:
>  EDD fixes
> Initial patch looked like it may break backwards compatibility; I
> haven't seen a new patch.

We could use an union to keep backwards compatibility. Something like the
following (for Bochs):

typedef struct {
    Bit16u  size;
    Bit16u  infos;
    Bit32u  cylinders;
    Bit32u  heads;
    Bit32u  spt;
    Bit32u  sector_count1;
    Bit32u  sector_count2;
    Bit16u  blksize;
    Bit16u  dpte_offset;
    Bit16u  dpte_segment;
    Bit16u  key;
    union {
        struct {
            Bit8u   dpi_length;
            Bit8u   reserved1;
            Bit16u  reserved2;
            Bit8u   host_bus[4];
            Bit8u   iface_type[8];
            Bit8u   iface_path[8];
            Bit8u   device_path[8];
            Bit8u   reserved3;
            Bit8u   checksum;
          } phoenix;
        struct {
            Bit8u   dpi_length;
            Bit8u   reserved1;
            Bit16u  reserved2;
            Bit8u   host_bus[4];
            Bit8u   iface_type[8];
            Bit8u   iface_path[8];
            Bit8u   device_path[16];
            Bit8u   reserved3;
            Bit8u   checksum;
          } t13;
      } dpi;
  } dpt_t;

Use dpi.phoenix for size = 66 and dpi.t13 for size = 74.
Since the first part of phoenix and t13 is same the union could start at
device_path.

Sebastian

[Kevin O'Connor]

On Fri, Sep 24, 2010 at 09:38:58PM +0200, Sebastian Herbszt wrote:
> Kevin O'Connor wrote:
> > Sebastian Herbszt: 20100731:
> > EDD fixes
> > Initial patch looked like it may break backwards compatibility; I
> > haven't seen a new patch.
>
> We could use an union to keep backwards compatibility. Something like the
> following (for Bochs):

[...]
> Use dpi.phoenix for size = 66 and dpi.t13 for size = 74.
> Since the first part of phoenix and t13 is same the union could start at
> device_path.

I'm not sure the union would be needed - one could use the t13 struct
and just use the fact that the checksum is in the last byte.  I'm okay
with either approach though.

-Kevin