On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote:
On 13 May 2013 21:01, Michael S. Tsirkin mst@redhat.com wrote:
This fills in guest info table with misc information of interest to the guest. Will be used by ACPI table generation code.
Bunch of coding style violations in this patch which will need fixing at some point in the RFC->patch process.
thanks -- PMM
I went over it again and found one: + if (ram_size <= 0x80000000) + guest_info->pci_info.w32.begin = 0x80000000; + else if (ram_size <= 0xc0000000) + guest_info->pci_info.w32.begin = 0xc0000000; + else + guest_info->pci_info.w32.begin = 0xe0000000;
should use {}.
One is not a bunch so I obviously missed some - it might be helpful if you pointed them out.
Thanks,