Re: [SeaBIOS] [PATCH 5/6] update dsdt ressources at runtime

[Kevin O'Connor]

On Tue, May 22, 2012 at 11:55:02AM +0200, Gerd Hoffmann wrote:
> On 05/18/12 05:07, Kevin O'Connor wrote:
> > I think we should really define a struct here instead of an array -
> > that should make it more obvious what's going on.
>
> Done, also created a virtual device in the dsdt to access those fields
> so we have a single place in the dsdt we have to keep in sync with
> acpi.h in case we are going to add more stuff there (as discussed for s3).
>
> Comments?

This version does look better to me.

[...]
> /****************************************************************
> Data area filled by seabios (see acpi.h, struct bfld)
> ****************************************************************/
> Scope(_SB) {
>    Device(BFLD) {
>        External (\_SB.BDAT)
>        Field(\_SB.BDAT, QWordAcc, NoLock, Preserve) {
>            P0S, 64,
>            P0E, 64,
>            P0L, 64,
>            P1S, 64,
>            P1E, 64,
>            P1L, 64,
>        }
>        Field(\_SB.BDAT, DWordAcc, NoLock, Preserve) {
>            P0SL, 64,

Should be 32?

Thanks.
-Kevin