SeaBIOS

seabios@seabios.org

3783 discussions

[PATCH v1 0/3] tpm: Support 2.0 TPM devices connected to a TIS host
by Stephen Douthit 15 Mar '18

15 Mar '18

Changes from v0 -> v1 Patch 1/3 *Rename sts to value Patch 2/3 *No Change Patch 3/3 *No longer sending command to the TPM. Instead check the InterfaceVersion field in the TPM_INTF_CAPABILITY register if necessary. *Removed "Tested-by:" since I wasn't able to find 1.2 hardware for regression test. Stephen Douthit (3): tpm: Refactor duplicated wait code in tis_wait_sts() & crb_wait_reg() tpm: Wait for interface startup when probing tpm: Handle unimplemented TIS_REG_IFACE_ID in tis_get_tpm_version() src/hw/tpm_drivers.c | 113 +++++++++++++++++++++++++++------------------------ 1 file changed, 60 insertions(+), 53 deletions(-) -- 2.14.3

4 30

New build warnings from GCC 8
by Paul Menzel 13 Mar '18

13 Mar '18

Dear SeaBIOS folks, Building SeaBIOS with GCC 8, the warnings below are shown. ``` $ gcc-8 --version gcc-8 (Debian 8-20180218-1) 8.0.1 20180218 (experimental) [trunk revision 257787] […] $ git log --oneline -1 5adc8bd (HEAD -> master, origin/master, origin/HEAD) tpm: Handle unimplemented TIS_REG_IFACE_ID in tis_get_tpm_version() $ make CC=gcc-8 scripts/kconfig/conf --olddefconfig /dev/shm/seabios2/src/Kconfig # # configuration written to /dev/shm/seabios2/.config # Build Kconfig config file Compile checking out/src/misc.o Compile checking out/src/stacks.o Compile checking out/src/output.o Compile checking out/src/string.o Compile checking out/src/block.o Compile checking out/src/cdrom.o Compile checking out/src/disk.o Compile checking out/src/mouse.o Compile checking out/src/kbd.o Compile checking out/src/system.o Compile checking out/src/serial.o Compile checking out/src/sercon.o Compile checking out/src/clock.o Compile checking out/src/resume.o Compile checking out/src/pnpbios.o Compile checking out/src/vgahooks.o Compile checking out/src/pcibios.o Compile checking out/src/apm.o Compile checking out/src/cp437.o Compile checking out/src/hw/pci.o Compile checking out/src/hw/timer.o Compile checking out/src/hw/rtc.o Compile checking out/src/hw/dma.o Compile checking out/src/hw/pic.o Compile checking out/src/hw/ps2port.o Compile checking out/src/hw/serialio.o Compile checking out/src/hw/usb.o Compile checking out/src/hw/usb-uhci.o Compile checking out/src/hw/usb-ohci.o Compile checking out/src/hw/usb-ehci.o Compile checking out/src/hw/usb-hid.o Compile checking out/src/hw/usb-msc.o Compile checking out/src/hw/usb-uas.o Compile checking out/src/hw/blockcmd.o Compile checking out/src/hw/floppy.o Compile checking out/src/hw/ata.o Compile checking out/src/hw/ramdisk.o Compile checking out/src/hw/lsi-scsi.o Compile checking out/src/hw/esp-scsi.o Compile checking out/src/hw/megasas.o Compile checking out/src/hw/mpt-scsi.o Compile checking out/src/post.o Compile checking out/src/e820map.o Compile checking out/src/malloc.o Compile checking out/src/romfile.o Compile checking out/src/x86.o Compile checking out/src/optionroms.o Compile checking out/src/pmm.o Compile checking out/src/font.o Compile checking out/src/boot.o Compile checking out/src/bootsplash.o Compile checking out/src/jpeg.o Compile checking out/src/bmp.o Compile checking out/src/tcgbios.o Compile checking out/src/sha1.o Compile checking out/src/hw/pcidevice.o Compile checking out/src/hw/ahci.o Compile checking out/src/hw/pvscsi.o Compile checking out/src/hw/usb-xhci.o Compile checking out/src/hw/usb-hub.o Compile checking out/src/hw/sdcard.o Compile checking out/src/fw/coreboot.o Compile checking out/src/fw/lzmadecode.o Compile checking out/src/fw/multiboot.o Compile checking out/src/fw/csm.o Compile checking out/src/fw/biostables.o Compile checking out/src/fw/paravirt.o Compile checking out/src/fw/shadow.o In file included from src/fw/shadow.c:17: src/fw/shadow.c: In function 'qemu_reboot': src/string.h:23:16: warning: '__builtin_memcpy' offset -1048576 is out of the bounds [0, 1] of object 'code32flat_start' with type 'char' [-Warray-bounds] #define memcpy __builtin_memcpy src/fw/shadow.c:190:9: note: in expansion of macro 'memcpy' memcpy(cstart, cstart + BIOS_SRC_OFFSET, hrp - cstart); ^~~~~~ In file included from src/biosvar.h:11, from src/fw/paravirt.h:5, from src/fw/shadow.c:16: src/fw/shadow.c:176:28: note: 'code32flat_start' declared here void *cstart = VSYMBOL(code32flat_start), *cend = VSYMBOL(code32flat_end); ^~~~~~~~~~~~~~~~ src/memmap.h:18:36: note: in definition of macro 'SYMBOL' #define SYMBOL(SYM) ({ extern char SYM; (u32)&SYM; }) ^~~ src/fw/shadow.c:176:20: note: in expansion of macro 'VSYMBOL' void *cstart = VSYMBOL(code32flat_start), *cend = VSYMBOL(code32flat_end); ^~~~~~~ In file included from src/fw/shadow.c:17: src/string.h:23:16: warning: '__builtin_memcpy' offset -1048572 is out of the bounds [0, 4] of object 'HaveRunPost' with type 'int' [-Warray-bounds] #define memcpy __builtin_memcpy src/fw/shadow.c:191:9: note: in expansion of macro 'memcpy' memcpy(hrp + 4, hrp + 4 + BIOS_SRC_OFFSET, cend - (hrp + 4)); ^~~~~~ In file included from src/fw/shadow.c:18: src/util.h:193:12: note: 'HaveRunPost' declared here extern int HaveRunPost; ^~~~~~~~~~~ Compile checking out/src/fw/pciinit.o Compile checking out/src/fw/smm.o Compile checking out/src/fw/smp.o Compile checking out/src/fw/mtrr.o Compile checking out/src/fw/xen.o Compile checking out/src/fw/acpi.o Compile checking out/src/fw/mptable.o Compile checking out/src/fw/pirtable.o Compile checking out/src/fw/smbios.o Compile checking out/src/fw/romfile_loader.o Compile checking out/src/hw/virtio-ring.o Compile checking out/src/hw/virtio-pci.o Compile checking out/src/hw/virtio-blk.o Compile checking out/src/hw/virtio-scsi.o Compile checking out/src/hw/tpm_drivers.o Compile checking out/src/hw/nvme.o Compiling whole program out/ccode32flat.o In file included from out/ccode32flat.o.tmp.c:4: In function 'qemu_reboot', inlined from 'tryReboot' at ./src/resume.c:129:5, inlined from 'handle_resume32' at ./src/resume.c:156:5: ./src/string.c:156:16: warning: '__builtin_memcpy' offset -1048576 is out of the bounds [0, 1] of object 'code32flat_start' with type 'char' [-Warray-bounds] #define memcpy __builtin_memcpy ./src/fw/shadow.c:190:9: note: in expansion of macro 'memcpy' memcpy(cstart, cstart + BIOS_SRC_OFFSET, hrp - cstart); ^~~~~~ In file included from ./src/biosvar.h:11, from ./src/misc.c:8, from out/ccode32flat.o.tmp.c:1: ./src/resume.c: In function 'handle_resume32': ./src/fw/shadow.c:176:28: note: 'code32flat_start' declared here void *cstart = VSYMBOL(code32flat_start), *cend = VSYMBOL(code32flat_end); ^~~~~~~~~~~~~~~~ ./src/memmap.h:18:36: note: in definition of macro 'SYMBOL' #define SYMBOL(SYM) ({ extern char SYM; (u32)&SYM; }) ^~~ ./src/fw/shadow.c:176:20: note: in expansion of macro 'VSYMBOL' void *cstart = VSYMBOL(code32flat_start), *cend = VSYMBOL(code32flat_end); ^~~~~~~ In file included from out/ccode32flat.o.tmp.c:4: In function 'qemu_reboot', inlined from 'tryReboot' at ./src/resume.c:129:5, inlined from 'handle_resume32' at ./src/resume.c:156:5: ./src/string.c:156:16: warning: '__builtin_memcpy' offset -1048572 is out of the bounds [0, 4] of object 'HaveRunPost' with type 'int' [-Warray-bounds] #define memcpy __builtin_memcpy ./src/fw/shadow.c:191:9: note: in expansion of macro 'memcpy' memcpy(hrp + 4, hrp + 4 + BIOS_SRC_OFFSET, cend - (hrp + 4)); ^~~~~~ In file included from ./src/stacks.c:17, from out/ccode32flat.o.tmp.c:2: ./src/resume.c: In function 'handle_resume32': ./src/util.h:193:12: note: 'HaveRunPost' declared here extern int HaveRunPost; ^~~~~~~~~~~ Compiling whole program out/code32seg.o Compiling whole program out/ccode16.o Compiling to assembler out/src/asm-offsets.s Generating offset file out/asm-offsets.h Compiling (16bit) out/romlayout.o Building ld scripts Version: rel-1.11.0-25-g5adc8bd Fixed space: 0xe05b-0x10000 total: 8101 slack: 12 Percent slack: 0.1% 16bit size: 37920 32bit segmented size: 2198 32bit flat size: 38890 32bit flat init size: 80416 Lowmem size: 2240 f-segment var size: 1248 Linking out/rom16.o Stripping out/rom16.strip.o Linking out/rom32seg.o Stripping out/rom32seg.strip.o Linking out/rom.o Prepping out/bios.bin.prep Total size: 168448 Fixed: 80256 Free: 93696 (used 64.3% of 256KiB rom) Creating out/bios.bin ``` Thanks, Paul

2 1

Building with AddressSanitizer (ASAN)
by Paul Menzel 08 Mar '18

08 Mar '18

Dear SeaBIOS folks, Is it possible to build SeaBIOS with AddressSanitizer support? Adding `-fsanitize=address` to the CFLAGS, the build with gcc (Debian 7.3.0-5) 7.3.0 fails with the error `ld:out/romlayout16.lds:11: syntax error`. Please find the configuration and the file attached. Thanks, Paul

1 0

[PATCH 0/3] Support TPM2.0 devices on TIS host
by Stephen Douthit 28 Feb '18

28 Feb '18

Hello all, I ran into an issue getting a Infineon SLB9670 2.0 TPM running on an Intel Denverton platform, and traced the problem to what seems to be incorrect behavior of tis_get_tpm_version(). That function is returning the version of the interface, and it seems the device version is what is needed. The version check implemented here is based on the tpm2_probe() function in the Linux tpm_tis driver. This patch set applies on top of Marc-André and Stefan's "Add CRB TPM device" patch series currently under review I've tested this on real hardware with a SLB9670 hanging off of an Intel C3758, but have not regression tested with TPM 1.2 devices. Regards, Steve Stephen Douthit (3): tpm: Refactor duplicated wait code in tis_wait_sts() & crb_wait_reg() tpm: Wait for interface startup when probing tpm: Support 2.0 TPM devices connected to a TIS host src/hw/tpm_drivers.c | 114 +++++++++++++++++++++++++++------------------------ src/std/tcg.h | 1 + src/tcgbios.c | 2 +- src/tcgbios.h | 4 ++ 4 files changed, 66 insertions(+), 55 deletions(-) -- 2.14.3

2 15

reboot fails with QEMU "isapc" machine type
by Daniel P. Berrangé 28 Feb '18

28 Feb '18

I was experimenting with old MS-DOS 6.22 under QEMU with the 'isapc' machine type, and found it is not able to reboot the guest. Bisecting QEMU blamed the QEMU change that rebased from "rel-1.9.3", to "rel-1.10.0". Further bisecting SeaBIOS blames this change: commit b837e68d5a6c1a5945513f1995875445a1594c8a (refs/bisect/bad) Author: Kevin O'Connor <kevin(a)koconnor.net> Date: Mon Nov 9 15:00:19 2015 -0500 resume: Make KVM soft reboot loop detection more flexible Move the check for soft reboot loops from resume.c to shadow.c and directly check for the case where the copy of the BIOS in flash appears to be a memory alias instead. This prevents a hang if an external reboot request occurs during the BIOS memcpy. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> I was testing as follows: $ qemu-system-x86_64 -machine isapc -monitor stdio demo.img where 'demo.img' is a disk image with MS-DOS installed (FreeDOS shows the same problem too. Not checked any other OS). Once C:\ command prompt is showing I enter (qemu) sendkey ctrl-alt-delete in the QEMU monitor console. Nothing visible will happen - the cursor will stay flashing, but it no longer responds to input. Prior to this SeaBIOS commit it will correctly reboot. Interesting side note is that this only happens with QEMUs 'isapc' machine type. The 'pc' machine type is still rebooting fine. If I enable the isa-debugcon device in QEMU I see this when the 'isapc' machine tries to reboot: In resume (status=0) In 32bit resume Attempting a hard reboot Unable to hard-reboot machine - attempting shutdown. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

2 5

[PATCH v2 0/4] Add CRB TPM device
by Stefan Berger 28 Feb '18

28 Feb '18

The following series implements a TPM CRB driver. The TIS device with a TPM 2.0 seems to be ignored by Windows 10, so I implemented a simple CRB device that has now been integrated into QEMU. With the CRB device, Windows 10 correctly recognizes and exchanges packets with a TPM 2.0. Marc-André (and Stefan) --- v1->v2: - followed Kevin's suggestions for patch 4/4. Marc-André Lureau (4): x86: add readq() tpm: generalize init_timeout() tpm: use get_tpm_version() callback tpm: add TPM CRB device support src/hw/tpm_drivers.c | 224 ++++++++++++++++++++++++++++++++++++++++++++++++--- src/hw/tpm_drivers.h | 26 ++++++ src/x86.h | 5 ++ 3 files changed, 243 insertions(+), 12 deletions(-) -- 2.5.5

2 6

Re: [SeaBIOS] Mysterious "is VARVERIFY32INIT but used from" problem while trying to improve SeaBIOS
by Kevin O'Connor 28 Feb '18

28 Feb '18

On Sun, Feb 25, 2018 at 08:51:56PM +0300, Mike Banon wrote: > > > > Please see the developer documentation: > > > > I am afraid this documentation does not answer why this build problem > does not happen when I apply this patch to the standalone cloned seabios > while it does happens when I apply it to the seabios built by a coreboot The default seabios configuration is to build for qemu and not coreboot. So, by default it would not include that code and would not raise a compile time error. If you configured seabios to build for coreboot and it didn't raise a compile time error then that seems like a build defect. -Kevin

1 0

[PATCH 1/2] floppy: Introduce the floppy_clear_irq_flag() function
by Nikolay Nikolov 27 Feb '18

27 Feb '18

Signed-off-by: Nikolay Nikolov <nickysn(a)users.sourceforge.net> --- src/hw/floppy.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/hw/floppy.c b/src/hw/floppy.c index 9e6647d..1120d63 100644 --- a/src/hw/floppy.c +++ b/src/hw/floppy.c @@ -220,11 +220,18 @@ floppy_disable_controller(void) floppy_dor_mask(FLOPPY_DOR_IRQ | FLOPPY_DOR_RESET, 0); } -static int -floppy_wait_irq(void) +static inline void +floppy_clear_irq_flag(void) { u8 frs = GET_BDA(floppy_recalibration_status); SET_BDA(floppy_recalibration_status, frs & ~FRS_IRQ); +} + +static int +floppy_wait_irq(void) +{ + floppy_clear_irq_flag(); + u8 frs; u32 end = timer_calc(FLOPPY_IRQ_TIMEOUT); for (;;) { if (timer_check(end)) { -- 2.14.3

3 4

[PATCH v2 0/4] Add CRB TPM device
by Stefan Berger 26 Feb '18

26 Feb '18

The following series implements a TPM CRB driver. The TIS device with a TPM 2.0 seems to be ignored by Windows 10, so I implemented a simple CRB device that has now been integrated into QEMU. With the CRB device, Windows 10 correctly recognizes and exchanges packets with a TPM 2.0. Marc-André (and Stefan) Marc-André Lureau (4): x86: add readq() tpm: generalize init_timeout() tpm: use get_tpm_version() callback tpm: add TPM CRB device support src/hw/tpm_drivers.c | 226 ++++++++++++++++++++++++++++++++++++++++++++++++--- src/hw/tpm_drivers.h | 26 ++++++ src/x86.h | 5 ++ 3 files changed, 245 insertions(+), 12 deletions(-) -- 2.5.5

3 7

Re: [SeaBIOS] Mysterious "is VARVERIFY32INIT but used from" problem while trying to improve SeaBIOS
by Kevin O'Connor 26 Feb '18

26 Feb '18

On Sun, Feb 25, 2018 at 03:05:06AM +0300, Mike Banon wrote: > Friends, I need your help. While trying to improve SeaBIOS I got stuck > at this very strange problem - which does not appear when you do a > standalone build of SeaBIOS but it happens when you try building a > coreboot together with SeaBIOS. Steps to reproduce: Please see the developer documentation: https://www.seabios.org/Developer_Documentation In particular, read the "memory model" and "execution and code phase" documents. -Kevin

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS