SeaBIOS

seabios@seabios.org

3783 discussions

[PATCH] boot.c: fix 'booting' text for USB devices
by Paul Menzel 10 Mar '20

10 Mar '20

From: Matt DeVillier <matt.devillier(a)gmail.com> Date: Fri, 13 Jun 2014 17:21:57 -0500 Currently, booting from a USB device displays the same text as booting from a hard disk ('Booting from Hard Disk'). Identify USB devices based on the description string and display identifying text when booting. Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- Upstream commit from https://github.com/MrChromebox/SeaBIOS src/boot.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/src/boot.c b/src/boot.c index afeb36a..69c602f 100644 --- a/src/boot.c +++ b/src/boot.c @@ -487,6 +487,7 @@ static struct hlist_head BootList VARVERIFY32INIT; #define IPL_TYPE_FLOPPY 0x01 #define IPL_TYPE_HARDDISK 0x02 #define IPL_TYPE_CDROM 0x03 +#define IPL_TYPE_USB 0x04 #define IPL_TYPE_CBFS 0x20 #define IPL_TYPE_BEV 0x80 #define IPL_TYPE_BCV 0x81 @@ -564,8 +565,17 @@ boot_add_floppy(struct drive_s *drive, const char *desc, int prio) void boot_add_hd(struct drive_s *drive, const char *desc, int prio) { - bootentry_add(IPL_TYPE_HARDDISK, defPrio(prio, DefaultHDPrio) + char *usb = "USB"; + char short_desc[4]; + memcpy(short_desc, desc, 3); + short_desc[3]='\0'; + if (strcmp(short_desc, usb) == 0) { + bootentry_add(IPL_TYPE_USB, defPrio(prio, DefaultHDPrio) , (u32)drive, desc); + } else { + bootentry_add(IPL_TYPE_HARDDISK, defPrio(prio, DefaultHDPrio) + , (u32)drive, desc); + } } void @@ -764,7 +774,7 @@ static int HaveHDBoot, HaveFDBoot; static void add_bev(int type, u32 vector) { - if (type == IPL_TYPE_HARDDISK && HaveHDBoot++) + if ((type == IPL_TYPE_HARDDISK || type == IPL_TYPE_USB) && HaveHDBoot++) return; if (type == IPL_TYPE_FLOPPY && HaveFDBoot++) return; @@ -802,6 +812,10 @@ bcv_prepboot(void) map_hd_drive(pos->drive); add_bev(IPL_TYPE_HARDDISK, 0); break; + case IPL_TYPE_USB: + map_hd_drive(pos->drive); + add_bev(IPL_TYPE_USB, 0); + break; case IPL_TYPE_CDROM: map_cd_drive(pos->drive); // NO BREAK @@ -962,6 +976,10 @@ do_boot(int seq_nr) printf("Booting from Hard Disk...\n"); boot_disk(0x80, 1); break; + case IPL_TYPE_USB: + printf("Booting from USB Device...\n"); + boot_disk(0x80, 1); + break; case IPL_TYPE_CDROM: boot_cdrom((void*)ie->vector); break; -- 2.25.0

3 2

[PATCH 1/3] timer: factor out tsctimer_configure()
by Gerd Hoffmann 09 Mar '20

09 Mar '20

Factor out TimerKHz and ShiftTSC calculation to tsctimer_configure(). Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- src/hw/timer.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/hw/timer.c b/src/hw/timer.c index bdcb3bfca211..ce3d63cd75f6 100644 --- a/src/hw/timer.c +++ b/src/hw/timer.c @@ -58,6 +58,18 @@ u8 ShiftTSC VARFSEG; * Internal timer setup ****************************************************************/ +static void +tsctimer_configure(u64 t) +{ + while (t >= (1<<24)) { + ShiftTSC++; + t = (t + 1) >> 1; + } + TimerKHz = DIV_ROUND_UP((u32)t, 1000 * PMTIMER_TO_PIT); + TimerPort = 0; + dprintf(1, "CPU Mhz=%u\n", (TimerKHz << ShiftTSC) / 1000); +} + #define CALIBRATE_COUNT 0x800 // Approx 1.7ms // Calibrate the CPU time-stamp-counter @@ -87,14 +99,7 @@ tsctimer_setup(void) dprintf(6, "tsc calibrate start=%u end=%u diff=%u\n" , (u32)start, (u32)end, (u32)diff); u64 t = DIV_ROUND_UP(diff * PMTIMER_HZ, CALIBRATE_COUNT); - while (t >= (1<<24)) { - ShiftTSC++; - t = (t + 1) >> 1; - } - TimerKHz = DIV_ROUND_UP((u32)t, 1000 * PMTIMER_TO_PIT); - TimerPort = 0; - - dprintf(1, "CPU Mhz=%u\n", (TimerKHz << ShiftTSC) / 1000); + tsctimer_configure(t); } // Setup internal timers. -- 2.18.2

3 7

Check if Wikipedia is correct and not outdated
by Fred .Flintstone 07 Mar '20

07 Mar '20

Hi Please check if Wikipedia is correct and not outdated. The SeaBIOS article. https://en.wikipedia.org/wiki/SeaBIOS The BIOS comparison which includes SeaBIOS. https://en.wikipedia.org/wiki/BIOS#Vendors_and_products Thanks!

1 0

Re: [PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00
by Ottavio Caruso 06 Mar '20

06 Mar '20

On 06/03/2020 09:03, Gerd Hoffmann wrote: > Fixes console redirection for NetBSD primary bootloader. > > https://bugs.launchpad.net/bugs/1743191 > Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> > --- > src/sercon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/sercon.c b/src/sercon.c > index a5dadb7261af..66a1f2412e77 100644 > --- a/src/sercon.c > +++ b/src/sercon.c > @@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs) > regs->ax = 0x0100; > } else { > // Disable sercon entry point on any vesa modeset > - if (regs->al == 0x00) > + if (regs->al == 0x02) > SET_LOW(sercon_enable, 0); > } > } > Unfortunately, this patch doesn't sort it for me. It also slightly messes up with the console, see: https://i.imgur.com/3ANAQC7.png -- Ottavio Caruso

1 0

[PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00
by Gerd Hoffmann 06 Mar '20

06 Mar '20

Fixes console redirection for NetBSD primary bootloader. https://bugs.launchpad.net/bugs/1743191 Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com> --- src/sercon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sercon.c b/src/sercon.c index a5dadb7261af..66a1f2412e77 100644 --- a/src/sercon.c +++ b/src/sercon.c @@ -464,7 +464,7 @@ static void sercon_104f(struct bregs *regs) regs->ax = 0x0100; } else { // Disable sercon entry point on any vesa modeset - if (regs->al == 0x00) + if (regs->al == 0x02) SET_LOW(sercon_enable, 0); } } -- 2.18.2

3 2

[PATCH 2/2] hw/usb-hid: Don't abort if setting key repeat rate fails
by Matt DeVillier 06 Mar '20

06 Mar '20

Since the USB stack doesn't handle stalled pipes, don't abort keyboard setup if the set_idle command fails, since it's a non-critical feature. Instead, log a warning. Test: build/boot Google Pixel Slate, observe keyboard functional Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- src/hw/usb-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/usb-hid.c b/src/hw/usb-hid.c index cedec0b..9e92dfe 100644 --- a/src/hw/usb-hid.c +++ b/src/hw/usb-hid.c @@ -70,7 +70,7 @@ usb_kbd_setup(struct usbdevice_s *usbdev // Periodically send reports to enable key repeat. ret = set_idle(usbdev->defpipe, KEYREPEATMS); if (ret) - return -1; + dprintf(3, "Warning: Failed to set key repeat rate\n"); keyboard_pipe = usb_alloc_pipe(usbdev, epdesc); if (!keyboard_pipe) -- 2.20.1

3 2

[PATCH v3] hw/usb-hid: handle devices with illegal max packet size
by Matt DeVillier 06 Mar '20

06 Mar '20

Some USB keyboards report 9 or 10-byte max packet sizes, instead of the 8-byte max specified by the USB HID spec. Handle this by increasing the size of the keyevent struct to 10 bytes, and using the key array size of the usbkeyinfo struct as loop bounds rather than that of the keyevent struct (since the former will always be smaller, and within spec). Test: built/boot on Google Pixel Slate, observe keyboard functional Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- src/hw/usb-hid.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/hw/usb-hid.c b/src/hw/usb-hid.c index fa4d9a2..bce1b5f 100644 --- a/src/hw/usb-hid.c +++ b/src/hw/usb-hid.c @@ -8,6 +8,7 @@ #include "config.h" // CONFIG_* #include "output.h" // dprintf #include "ps2port.h" // ATKBD_CMD_GETID +#include <string.h> //memset #include "usb.h" // usb_ctrlrequest #include "usb-hid.h" // usb_keyboard_setup #include "util.h" // process_key @@ -59,8 +60,10 @@ usb_kbd_setup(struct usbdevice_s *usbdev // XXX - this enables the first found keyboard (could be random) return -1; - if (epdesc->wMaxPacketSize != 8) + if (epdesc->wMaxPacketSize > 10) { + dprintf(1, "USB keyboard endpoint wMaxPacketSize > 10; aborting\n"); return -1; + } // Enable "boot" protocol. int ret = set_protocol(usbdev->defpipe, 0); @@ -163,11 +166,15 @@ static u16 ModifierToScanCode[] VAR16 = { #define RELEASEBIT 0x80 -// Format of USB keyboard event data +// Format of USB keyboard event data. +// Some keyboards use a 9/10 byte packet size, +// so account for that here to prevent buffer +// overflow. We'll ignore the 9th/10th bytes +// as it's out of spec. struct keyevent { u8 modifiers; u8 reserved; - u8 keys[6]; + u8 keys[8]; }; // Translate data from KeyToScanCode[] to calls to process_key(). @@ -253,7 +260,7 @@ handle_key(struct keyevent *data) break; int j; for (j=0;; j++) { - if (j>=ARRAY_SIZE(data->keys)) { + if (j>=ARRAY_SIZE(old.keys)) { // Key released. procscankey(key, RELEASEBIT, data->modifiers); if (i+1 >= ARRAY_SIZE(old.keys) || !old.keys[i+1]) @@ -274,7 +281,7 @@ handle_key(struct keyevent *data) // Process new keys procmodkey(data->modifiers & ~old.modifiers, 0); old.modifiers = data->modifiers; - for (i=0; i<ARRAY_SIZE(data->keys); i++) { + for (i=0; i<ARRAY_SIZE(old.keys); i++) { u8 key = data->keys[i]; if (!key) continue; -- 2.20.1

2 3

Merge the SLIC patch
by Fred .Flintstone 13 Feb '20

13 Feb '20

There is a patch for ACPI Table Extraction / SeaBIOS SLIC Integration. https://github.com/ghuntley/seaslic Why isn't the SLIC patch merged into upstreams SeaBIOS?

2 4

Is Wikipedia correct?
by Fred .Flintstone 13 Feb '20

13 Feb '20

Since there are exports on this mailing lists on SeaBIOS and BIOS in general, please check if Wikipedia is correct, if any information is wrong or outdated or missing. https://en.wikipedia.org/wiki/SeaBIOS https://en.wikipedia.org/wiki/BIOS#Vendors_and_products

1 0

onboard NIC eno1
by Gisbert Haas 27 Jan '20

27 Jan '20

Hallo All, I have a proprietary application running on Debian9 with hardcoded NIC "eno1". If I would like to use virtualization I need to have the NIC show up as onboard NIC so systemd will name it eno1. I dont have access to the OS Debian9 to change anything. is there a way to have the Bios report the NIC as onboad eno1? Thanks a lot

2 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS