SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

Re: [SeaBIOS] [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug
by Andreas Färber 10 Jan '13

10 Jan '13

Am 10.01.2013 18:36, schrieb Vasilis Liaskovitis: > Btw, is the CPU link<socket> feature already implemented in a qom-cpu branch? No, the latest topology series moves fields around as preparation. There's still one CPUState per hyperthread, but as a DeviceState now. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

1 0

Re: [SeaBIOS] [RFC PATCH v4 21/30] Implement dimm-info
by Eric Blake 10 Jan '13

10 Jan '13

On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: > "query-dimm-info" and "info dimm" will give current state of all dimms in the > system e.g. > > dimm0: on > dimm1: off > dimm2: off > dimm3: on > etc. > > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> > --- > +++ b/qapi-schema.json > @@ -2914,6 +2914,32 @@ > { 'command': 'query-memory-total', 'returns': 'int' } > > ## > +# @DimmInfo: > +# > +# Information about status of a memory hotplug command > +# > +# @dimm: the Dimm associated with the result > +# > +# @result: the result of the hotplug command Here you call it 'result', > +# > +# Since: 1.4 > +# > +## > +{ 'type': 'DimmInfo', > + 'data': {'dimm': 'str', 'state': 'bool'} } but here you call it 'state'. Which is it? And does 'true' mean plugged in, or that the last command succeeded (where the last command may have been either a plug or an unplug)? My preference is that 'true' means plugged in, so more documentation would help. > + > +## > +# @query-dimm-info: > +# > +# Returns total memory in bytes, including hotplugged dimms Really? > +# > +# Returns: int Copy-and-paste error? This doesn't return an 'int', but an array of 'DimmInfo'. > +# > +# Since: 1.4 > +## > +{ 'command': 'query-dimm-info', 'returns': ['DimmInfo'] } > + > +## > # @QKeyCode: > # > # An enumeration of key name. > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

2 1

Re: [SeaBIOS] [RFC PATCH v4 19/30] Implement "info memory-total" and "query-memory-total"
by Eric Blake 10 Jan '13

10 Jan '13

On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: > Returns total physical memory available to guest in bytes, including hotplugged > memory. Note that the number reported here may be different from what the guest > sees e.g. if the guest has not logically onlined hotplugged memory. > > This functionality is provided independently of a balloon device, since a > guest can be using ACPI memory hotplug without using a balloon device. > > v3->v4: Moved qmp command implementation to vl.c. This prevents a circular > header dependency problem. Generally, patch change history should occur... > > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis(a)profitbricks.com> > --- ...here, after the --- divider. It's useful in the email chain, but does not need to be part of the final git history. > +++ b/qapi-schema.json > @@ -2903,6 +2903,17 @@ > { 'command': 'query-target', 'returns': 'TargetInfo' } > > ## > +# @query-memory-total: > +# > +# Returns total memory in bytes, including hotplugged dimms > +# > +# Returns: int > +# > +# Since: 1.4 > +## > +{ 'command': 'query-memory-total', 'returns': 'int' } Any reason you can't name this just 'query-memory', and return a JSON dictionary instead of a single int, so that in the future you can add other memory parameters into the same call? For example, down the road we may want to report some 'newstat' without adding a new QMP command: { 'type': 'MemoryInfo', 'data': { 'total': 'int', 'newstat': 'int' } } { 'command': 'query-memory', 'returns': 'MemoryInfo' } -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

2 1

Get rid of a compile time dprintf warning
by Dave Frodin 10 Jan '13

10 Jan '13

This patch gets rid of a compile time dprintf warning. A 'long int' was being passed to a '%d'. Signed-off-by: Dave Frodin <dave.frodin(a)se-eng.com> --- src/post.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/post.c b/src/post.c index 924b311..b84d19e 100644 --- a/src/post.c +++ b/src/post.c @@ -345,7 +345,7 @@ reloc_init(void) panic("No space for init relocation.\n"); // Copy code and update relocs (init absolute, init relative, and runtime) - dprintf(1, "Relocating low data from %p to %p (size %d)\n" + dprintf(1, "Relocating low data from %p to %p (size %ld)\n" , datalow_start, final_datalow_start, datalow_end - datalow_start); updateRelocs(code32flat_start, _reloc_datalow_start, _reloc_datalow_end , final_datalow_start - datalow_start); -- 1.7.9

3 6

Re: [SeaBIOS] Next release
by Peter Stuge 09 Jan '13

09 Jan '13

Fred . wrote: > I've seen other BIOS (Award, AMI) have a setting in the menu to enable > "Boot sector protection". Did you study what it actually does? > What would be possible in SeaBIOS to prevent overwrite boot sector, > mbr, partition tables? Nothing, really. An operating system can always communicate directly with the hardware and overwrite whatever sectors it wants. //Peter

1 0

Re: [SeaBIOS] Next release
by Kevin O'Connor 09 Jan '13

09 Jan '13

On Tue, Jan 08, 2013 at 01:06:31AM +0100, Fred . wrote: > Boot sector write protection. > Prevent modify boot sector, master boot record, partition tables. > > Less and less computers come with optical disk drivers to run read-only > Live distributions from. Would be nice with option to set hard disk drive > read-only. > So you can use a HDD or USB as a LiveCD/LiveDVD distribution. If someone has a patch for this, I'll consider it. I don't think it is worthwhile to hold up a release if this feature is not ready. Separately, there's no way for SeaBIOS to prevent access to the MBR, so I'm not sure how that would work. -Kevin

2 1

[PATCH] esp: enable busmaster
by Paolo Bonzini 09 Jan '13

09 Jan '13

The HBA does DMA, thus we must enable the busmaster bit, otherwise dma access will fail with recent qemu versions. Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> --- src/esp-scsi.c | 2 ++ 1 file modificato, 2 inserzioni(+) diff --git a/src/esp-scsi.c b/src/esp-scsi.c index b795012..c43e55b 100644 --- a/src/esp-scsi.c +++ b/src/esp-scsi.c @@ -202,6 +202,8 @@ init_esp_scsi(struct pci_device *pci) pci_bdf_to_bus(bdf), pci_bdf_to_dev(bdf), pci_bdf_to_fn(bdf), iobase); + pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER); + // reset outb(ESP_CMD_RESET, iobase + ESP_CMD); -- 1.7.12.1

4 10

Re: [SeaBIOS] Next release
by Kevin O'Connor 09 Jan '13

09 Jan '13

On Tue, Jan 08, 2013 at 10:54:19AM +0100, Christian Gmeiner wrote: > I will send out some geode vga patches today.. maybe they can be in the release. Sure - send them over. Could you also send the solution to your lx800 USB issues? -Kevin

1 0

Next release
by Kevin O'Connor 09 Jan '13

09 Jan '13

It's been a few months since the last SeaBIOS release. I'd like to start preparing for the next release. If you know of any defects or critical features that should go into the next release, please let me know. I'd like to target January 18th for the next release. -Kevin

4 4

Re: [SeaBIOS] [RFC PATCH v4 26/30] Implement qmp and hmp commands for notification lists
by Eric Blake 09 Jan '13

09 Jan '13

On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: > Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. > This patch implements a tail queue to store guest notifications for memory > hot-add and hot-remove requests. > > Guest responses for memory hotplug command on a per-dimm basis can be detected > with the new hmp command "info memory-hotplug" or the new qmp command > "query-memory-hotplug" > > Examples: > > (qemu) device_add dimm,id=ram0 > (qemu) info memory-hotplug > dimm: ram0 hot-add success > or > dimm: ram0 hot-add failure > > +++ b/qapi-schema.json > @@ -2940,6 +2940,32 @@ > { 'command': 'query-dimm-info', 'returns': ['DimmInfo'] } > > ## > +# @MemHpInfo: > +# > +# Information about status of a memory hotplug command > +# > +# @dimm: the Dimm associated with the result Didn't document @request. > +# > +# @result: the result of the hotplug command > +# > +# Since: 1.4 > +# > +## > +{ 'type': 'MemHpInfo', > + 'data': {'dimm': 'str', 'request': 'str', 'result': 'str'} } Instead of open-coding 'request' and 'result' as an arbitrary string, it would be nicer to have them be an enum type with a finite subset of expected values. > + > +## > +# @query-memory-hotplug: > +# > +# Returns a list of information about pending hotplug commands > +# > +# Returns: a list of @MemhpInfo s/MemhpInfo/MemHpInfo/ > +# > +# Since: 1.4 > +## > +{ 'command': 'query-memory-hotplug', 'returns': ['MemHpInfo'] } > + > +## > # @QKeyCode: > # -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS