SeaBIOS

seabios@seabios.org

4 participants
3801 discussions

[PATCH] Fix layoutrom step on i18n-equipped systems
by Patrick Georgi 03 Dec '14

03 Dec '14

objdump output parsing expects C locale strings and formatting. Make sure it gets what it requires. Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index eecb8a1..9191509 100644 --- a/Makefile +++ b/Makefile @@ -158,9 +158,9 @@ $(OUT)romlayout16.lds: $(OUT)ccode32flat.o $(OUT)code32seg.o $(OUT)ccode16.o $(O $(Q)$(CC) $(CFLAGS32FLAT) -c $(OUT)version.c -o $(OUT)version.o $(Q)$(LD) $(LD32BIT_FLAG) -r $(OUT)ccode32flat.o $(OUT)version.o -o $(OUT)code32flat.o $(Q)$(LD) $(LD32BIT_FLAG) -r $(OUT)ccode16.o $(OUT)romlayout.o -o $(OUT)code16.o - $(Q)$(OBJDUMP) -thr $(OUT)code32flat.o > $(OUT)code32flat.o.objdump - $(Q)$(OBJDUMP) -thr $(OUT)code32seg.o > $(OUT)code32seg.o.objdump - $(Q)$(OBJDUMP) -thr $(OUT)code16.o > $(OUT)code16.o.objdump + $(Q)LC_ALL=C $(OBJDUMP) -thr $(OUT)code32flat.o > $(OUT)code32flat.o.objdump + $(Q)LC_ALL=C $(OBJDUMP) -thr $(OUT)code32seg.o > $(OUT)code32seg.o.objdump + $(Q)LC_ALL=C $(OBJDUMP) -thr $(OUT)code16.o > $(OUT)code16.o.objdump $(Q)$(PYTHON) ./scripts/layoutrom.py $(OUT)code16.o.objdump $(OUT)code32seg.o.objdump $(OUT)code32flat.o.objdump $(OUT)$(KCONFIG_AUTOHEADER) $(OUT)romlayout16.lds $(OUT)romlayout32seg.lds $(OUT)romlayout32flat.lds # These are actually built by scripts/layoutrom.py above, but by pulling them -- 2.1.0

3 4

Re: [SeaBIOS] [PATCH] Fix layoutrom step on i18n-equipped systems
by Gerd Hoffmann 03 Dec '14

03 Dec '14

Hi, > > How about this: [export LC_ALL globally in Makefile] > Tested-By: Patrick Georgi <pgeorgi(a)google.com> pushed to master. cheers, Gerd

1 0

Fwd: [PATCH] Fix layoutrom step on i18n-equipped systems
by Patrick Georgi 03 Dec '14

03 Dec '14

2014-12-03 11:16 GMT+01:00 Gerd Hoffmann <kraxel(a)redhat.com>: > > I suspect this isn't going to fly as each makefile line is run > separately. Correct. We discussed that on IRC. That's probably one of make's less intuitive features. I also proposed to use a global export, but had no opportunity to test it right then. > How about this: [export LC_ALL globally in Makefile] Tested-By: Patrick Georgi <pgeorgi(a)google.com> Thanks, Patrick -- Google Germany GmbH ABC-Str. 19 20354 Hamburg Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores

1 0

[PATCH] floppy: Make sure to yield() during floppy PIO
by Kevin O'Connor 29 Nov '14

29 Nov '14

The floppy Programmed IO code really should yield while the controller is busy. Signed-off-by: Kevin O'Connor <kevin(a)koconnor.net> --- src/hw/floppy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/hw/floppy.c b/src/hw/floppy.c index aa8583d..d60362a 100644 --- a/src/hw/floppy.c +++ b/src/hw/floppy.c @@ -244,6 +244,7 @@ floppy_pio(int command, u8 *param) floppy_disable_controller(); return DISK_RET_ETIMEOUT; } + yield(); continue; } if (sts & 0x40) { @@ -277,6 +278,7 @@ floppy_pio(int command, u8 *param) floppy_disable_controller(); return DISK_RET_ETIMEOUT; } + yield(); continue; } if (i >= receive) { -- 1.9.3

1 0

Is it possible to implement a virtual CD drive in SeaBIOS and boot computer from an ISO image?
by 刘俊峰 29 Nov '14

29 Nov '14

Hi SeaBios, Since almost all OS distributions are released as ISO images, either setup CD or Live CD. Normally we need to burn the ISO image to optical disk or USB disk, but CD drives are die out and USB disk may not be compatible for a successful boot up. It will be extremely good if user can boot computer from any of these CD images with great ease. I know GRUB can load an ISO file, but once the OS on it takes over the CPU the CD no longer exists, you know, this have many restrictions . What we want is a virtual CD drive comparable to that provided by a virtual machine software(e.g. VirtualBox). So I wonder whether a virtual CD drive implemented at BIOS level can persist even after OS is boot up? Thanks, Junfeng

2 1

[PATCH 0/2] fw/pci: better support for multiple host bridges
by Marcel Apfelbaum 25 Nov '14

25 Nov '14

The series fixes some issues when more than one root primary bus is present. First patch scans all the bus range to find the extra root buses. Second patch extends memory and IO mapping for found buses. Marcel Apfelbaum (2): fw/pci: scan all buses if extraroots romfile is present fw/pci: map memory and IO regions for multiple pci root buses src/fw/pciinit.c | 123 +++++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 88 insertions(+), 35 deletions(-) -- 1.9.3

3 11

Re: [SeaBIOS] new tag request for seabios
by Kevin O'Connor 21 Nov '14

21 Nov '14

On Fri, Nov 21, 2014 at 08:03:29PM +0000, Pandey, Sunil K wrote: > > Is this the only thing preventing compilation on the Intel compiler? > Yes, this is the only problem for Intel compiler. > > I can directly use from git checkout but issue is, SeaBios is > indirectly included in many other open source applications which is > based on SeaBios release tag. Anytime, when I try to compile other > open source applications (i.e. Xen), indirectly it try to compile > SeaBios and Intel Compiler fail because of this issue. Okay. We're likely a couple of months out from the next major release. It may be a candidate for the stable branch, which Gerd maintains. Can you confirm the patch below on top of rel-1.7.5.1 fixes the issue for you? -Kevin --- a/scripts/layoutrom.py +++ b/scripts/layoutrom.py @@ -175,10 +175,7 @@ def doLayout(sections, config, genreloc): # Determine 16bit positions li.sections16 = getSectionsCategory(sections, '16') textsections = getSectionsPrefix(li.sections16, '.text.') - rodatasections = ( - getSectionsPrefix(li.sections16, '.rodata.str1.1') - + getSectionsPrefix(li.sections16, '.rodata.__func__.') - + getSectionsPrefix(li.sections16, '.rodata.__PRETTY_FUNCTION__.')) + rodatasections = getSectionsPrefix(li.sections16, '.rodata') datasections = getSectionsPrefix(li.sections16, '.data16.') fixedsections = getSectionsPrefix(li.sections16, '.fixedaddr.') @@ -191,10 +188,7 @@ def doLayout(sections, config, genreloc): # Determine 32seg positions li.sections32seg = getSectionsCategory(sections, '32seg') textsections = getSectionsPrefix(li.sections32seg, '.text.') - rodatasections = ( - getSectionsPrefix(li.sections32seg, '.rodata.str1.1') - + getSectionsPrefix(li.sections32seg, '.rodata.__func__.') - + getSectionsPrefix(li.sections32seg, '.rodata.__PRETTY_FUNCTION__.')) + rodatasections = getSectionsPrefix(li.sections32seg, '.rodata') datasections = getSectionsPrefix(li.sections32seg, '.data32seg.') li.sec32seg_start, li.sec32seg_align = setSectionsStart(

2 1

Re: [SeaBIOS] new tag request for seabios
by Kevin O'Connor 21 Nov '14

21 Nov '14

On Fri, Nov 21, 2014 at 07:04:47PM +0000, Pandey, Sunil K wrote: > Hi Kevin, > > Thanks for response. Following are specific change I'm talking > about. Compilers are not expected to create .rodata.str1.1, > .rodata.__func__ and .rodata.__PRETTY_FUNCTION__. If compiler > decide to use some other .rodata__ suffix name in place of __func__, > __PRETTY_FUNCTION__ or str1.1, it breaks the compilation. > > As you can see someone already taken out that check from SeaBios > mainline, but 1.7.5.1 still has. As a result of this assumption, > whenever I try to build SeaBios with Intel Compiler it Fail because > Intel compiler uses some other character in place of > __PRETTY_FUNCTION__ and __func__. It will be great if you can > incorporate this fix in released version. I made that change as part of commit e5749978. The change was part of a feature enhancement (compiling with -fno-merge-constants). Is this the only thing preventing compilation on the Intel compiler? Typically a feature enhancement such as e5749978 would go into the next release, and we're likely a month or so out from the next release. As Peter mentioned in another email, it should be possible to checkout a git version using the hash instead of a tag name in the interim (eg, "git checkout 9f505f71"). -Kevin

2 1

Re: [SeaBIOS] new tag request for seabios
by Kevin O'Connor 21 Nov '14

21 Nov '14

On Wed, Nov 12, 2014 at 09:20:22PM +0000, Pandey, Sunil K wrote: > Hello, > > I'm looking for a fix in > http://code.coreboot.org/p/seabios/source/tree/master/scripts/layoutrom.py > file. Apparently the fix is already in the master, but it's hard for > me to use directly from master. Currently all existing tags are old > and doesn't reflect latest layoutrom.py changes. > > Can you please create a new tag from master so that I can use it in > my project? I'm trying to compile seabios code with Intel compiler, > but it keep failing because of layoutrom.py file __func__ check. Can you post the error that you are seeing? We just tagged rel-1.7.5.1 and it included all the build bug fixes that I know of. There are changes to scripts/layoutrom.py between rel-1.7.5.1 and the current master branch, but none of those changes were thought to be bug fixes. -Kevin PS - please post in just plain text (no html) in the future.

2 1

Re: [SeaBIOS] new tag request for seabios
by Peter Stuge 21 Nov '14

21 Nov '14

Pandey, Sunil K wrote: > the fix is already in the master, but it's hard for me to use > directly from master. Currently all existing tags are old and > doesn't reflect latest layoutrom.py changes. Wherever you use a tag with git you can also provide a commit hash. It should work well to simply change your code to reference the commit with the fix instead of the tag you are currently using. Unrelated to using a commit id maybe someone will add a tag. //Peter

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SeaBIOS